Page MenuHomePhabricator
Feed All Stories

Wed, Dec 11

angelika published D14122: [native] Migrate TextMessageTooltipButton to Reanimated V2 API for review.
Wed, Dec 11, 5:27 PM
angelika published D14121: [native] Remove progress parameter from useAnimatedMessageTooltipButton for review.
Wed, Dec 11, 5:27 PM
angelika published D14120: [native] Migrate threadColorOverride in useAnimatedMessageTooltipButton to Reanimate V2 API for review.
Wed, Dec 11, 5:27 PM
angelika published D14119: [native] Migrate messageContainerStyle in useAnimatedMessageTooltipButton to Reanimate V2 API for review.
Wed, Dec 11, 5:27 PM
angelika published D14118: [native] Add progressV2 field to tooltip button types for review.
Wed, Dec 11, 5:26 PM
angelika published D14117: [native] Migrate Tooltip component to Reanimated v2 API for review.
Wed, Dec 11, 5:26 PM
ashoat accepted D14099: [native] Add reanimated makeMutable function type.
Wed, Dec 11, 5:03 PM
ashoat accepted D14098: [native] Fix reanimated cancelAnimation flow type.

Thanks for finding this. Just wondering – did you find out because something was broken through testing, or because you observed that Flow was printing an error when the code looked right?

Wed, Dec 11, 5:02 PM
ashoat requested review of D14144: [native] Stop resetting ChatThreadList on navigation.
Wed, Dec 11, 5:01 PM
ashoat added a comment to D14113: [native] Enable Flow types in Reanimated worklets.

One small thing – before landing, can you:

Wed, Dec 11, 5:00 PM
ashoat accepted D14113: [native] Enable Flow types in Reanimated worklets.

Great work on this!!

Wed, Dec 11, 4:57 PM
angelika published D14113: [native] Enable Flow types in Reanimated worklets for review.
Wed, Dec 11, 4:55 PM
angelika published D14112: [native] Move render function from Tooltip to functional component for review.
Wed, Dec 11, 4:55 PM
angelika published D14111: [native] Move methods from Tooltip to functional compononent for review.
Wed, Dec 11, 4:55 PM
angelika published D14110: [native] Move haptics in Tooltip to functional compononent for review.
Wed, Dec 11, 4:55 PM
angelika published D14109: [native] Move styles in Tooltip to functional component for review.
Wed, Dec 11, 4:54 PM
angelika published D14108: [native] Move Reanimated nodes in Tooltip to functional component for review.
Wed, Dec 11, 4:54 PM
angelika published D14107: [native] Move tooltip location getter in Tooltip to functional component for review.
Wed, Dec 11, 4:54 PM
angelika published D14106: [native] Move tooltip height getter in Tooltip to functional component for review.
Wed, Dec 11, 4:54 PM
angelika published D14104: [native] Move margin getter in Tooltip to functional component for review.
Wed, Dec 11, 4:53 PM
angelika published D14103: [native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API for review.
Wed, Dec 11, 4:53 PM
angelika published D14102: [native] Introduce positionsV2 values in OverlayNavigator for review.
Wed, Dec 11, 4:53 PM
ashoat requested review of D14143: [native] Add loading indicator at the bottom of ChatThreadList.
Wed, Dec 11, 4:53 PM
angelika published D14099: [native] Add reanimated makeMutable function type for review.
Wed, Dec 11, 4:52 PM
angelika published D14098: [native] Fix reanimated cancelAnimation flow type for review.
Wed, Dec 11, 4:52 PM
ashoat updated the diff for D13828: [lib] Only show reactions to viewer's messages in MessagePreview.

Rebase

Wed, Dec 11, 4:49 PM
ashoat updated the diff for D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.

Rebase

Wed, Dec 11, 4:48 PM
ashoat updated the diff for D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.

Rebase

Wed, Dec 11, 4:46 PM
ashoat requested review of D14142: [native] Factor out listLoadingIndicatorHeight.
Wed, Dec 11, 4:44 PM
ashoat requested review of D14141: [lib][native] Update native to use ChatThreadItemLoaderCache.
Wed, Dec 11, 4:35 PM
ashoat requested review of D14140: [lib] Introduce ChatThreadItemLoaderCache.
Wed, Dec 11, 4:27 PM
ashoat requested review of D14139: [lib] Rename useCreateChatThreadItem to useGetChatThreadItemLoader.
Wed, Dec 11, 4:18 PM
ashoat requested review of D14138: [lib] Extract initialChatThreadItem.
Wed, Dec 11, 4:10 PM
ashoat requested review of D14137: [lib] Avoid unnecessary useSelector on MessageStore in useGetLastUpdatedTimes.
Wed, Dec 11, 4:09 PM
ashoat requested review of D14136: [lib] Don't construct promises in useCreateChatThreadItem.
Wed, Dec 11, 4:03 PM
ashoat updated the diff for D13919: [lib] Don't bump thin thread timestamp for membership robotext.

Rebase

Wed, Dec 11, 3:58 PM
ashoat updated the diff for D13829: [lib] Hide membership robotext from MessagePreview in thin threads.

Rebase

Wed, Dec 11, 3:57 PM
ashoat updated the summary of D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.
Wed, Dec 11, 3:54 PM
ashoat updated the summary of D13828: [lib] Only show reactions to viewer's messages in MessagePreview.
Wed, Dec 11, 3:53 PM
ashoat updated the summary of D13910: [lib] Inline getMostRecentMessageInfo.
Wed, Dec 11, 3:30 PM
ashoat added inline comments to D13994: [native] community list item component.
Wed, Dec 11, 11:44 AM
varun added a comment to D13994: [native] community list item component.

It looks like you got a lot of this from another file. If any of my feedback here applies to the original file, can you make sure to make the changes there too?

Wed, Dec 11, 11:18 AM
ashoat added inline comments to D14105: [native] implement QR Auth context.
Wed, Dec 11, 9:40 AM
ashoat accepted D14101: [native] move `SecondaryDeviceQRCodeScanner` to `qr-auth` directory.
Wed, Dec 11, 9:38 AM
ashoat accepted D14100: [native] implement QR Auth stack navigator.
Wed, Dec 11, 9:38 AM
varun added a comment to D13986: [native] bottom sheet for exploring communities.

Nice! Just wondering, how'd you get the SVG fixed up?

Wed, Dec 11, 9:35 AM
kamil published D14116: [native] navigate to proper screen after scanning QR code for review.
Wed, Dec 11, 8:30 AM
kamil published D14115: [native] implement screen when connecting secondary device for review.
Wed, Dec 11, 8:30 AM
kamil published D14114: [native] implement screen when scanning QR code a non-primary device for review.
Wed, Dec 11, 8:29 AM
kamil updated the summary of D14105: [native] implement QR Auth context.
Wed, Dec 11, 8:28 AM
kamil published D14105: [native] implement QR Auth context for review.
Wed, Dec 11, 8:28 AM
kamil published D14101: [native] move `SecondaryDeviceQRCodeScanner` to `qr-auth` directory for review.
Wed, Dec 11, 8:28 AM
kamil published D14100: [native] implement QR Auth stack navigator for review.
Wed, Dec 11, 8:27 AM
ashoat accepted D13986: [native] bottom sheet for exploring communities.

Nice! Just wondering, how'd you get the SVG fixed up?

Wed, Dec 11, 6:44 AM
kamil closed D14083: [native] implement hook for restore.
Wed, Dec 11, 5:39 AM
kamil committed rCOMM6e8a60ade6ed: [native] implement hook for restore (authored by kamil).
[native] implement hook for restore
Wed, Dec 11, 5:39 AM
kamil closed D14081: [lib] add Identity Restore action type.
Wed, Dec 11, 5:39 AM
kamil closed D14082: [native] implement Restore protocol for Signed Device List.
Wed, Dec 11, 5:39 AM
kamil committed rCOMM3418cc2626ad: [lib] add Identity Restore action type (authored by kamil).
[lib] add Identity Restore action type
Wed, Dec 11, 5:39 AM
kamil committed rCOMMc20f2b65d0b4: [native] implement Restore protocol for Signed Device List (authored by kamil).
[native] implement Restore protocol for Signed Device List
Wed, Dec 11, 5:39 AM
kamil closed D14080: [lib] refactor `useClientBackup` to not use user identifier from the store.
Wed, Dec 11, 5:39 AM
kamil committed rCOMMde39757b9ad9: [lib] refactor `useClientBackup` to not use user identifier from the store (authored by kamil).
[lib] refactor `useClientBackup` to not use user identifier from the store
Wed, Dec 11, 5:39 AM
kamil published D14097: [CommCoreModule] avoid triggering backup upload on SQLite changes for review.
Wed, Dec 11, 5:05 AM
kamil published D14096: [native] make sure `start_backup_handler` is called only once in `BackupHandler` for review.
Wed, Dec 11, 5:05 AM
kamil published D14095: [native_rust_library] make `start_backup_handler` thread-safe for review.
Wed, Dec 11, 5:05 AM
kamil updated the diff for D14083: [native] implement hook for restore.

rebase before landing

Wed, Dec 11, 5:04 AM
kamil updated the diff for D14082: [native] implement Restore protocol for Signed Device List.

address nit

Wed, Dec 11, 5:03 AM
kamil added inline comments to D14082: [native] implement Restore protocol for Signed Device List.
Wed, Dec 11, 5:03 AM
kamil updated the diff for D14081: [lib] add Identity Restore action type.

rename to RESTORE_USER_

Wed, Dec 11, 5:00 AM
tomek accepted D14083: [native] implement hook for restore.
Wed, Dec 11, 2:45 AM
tomek accepted D14082: [native] implement Restore protocol for Signed Device List.
Wed, Dec 11, 2:38 AM

Tue, Dec 10

varun updated the diff for D13986: [native] bottom sheet for exploring communities.

remove onLayout callback that I used to calculate component height

Tue, Dec 10, 11:46 PM
Harbormaster failed remote builds in B32990: Diff 46304 for D13986: [native] bottom sheet for exploring communities!
Tue, Dec 10, 11:41 PM
varun added a comment to D13986: [native] bottom sheet for exploring communities.

Screenshot of latest version of bottom sheet

Tue, Dec 10, 11:27 PM
varun updated the diff for D13986: [native] bottom sheet for exploring communities.

address feedback

Tue, Dec 10, 11:27 PM
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM63ee7a65cc8f: [terraform] Bump keyserver image to 1.0.145 (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[terraform] Bump keyserver image to 1.0.145
Tue, Dec 10, 11:07 AM
tomek closed D14085: [native] Render SIWE restore panel.
Tue, Dec 10, 10:12 AM
tomek closed D14084: [native] Create a restore backup screen.
Tue, Dec 10, 10:12 AM
tomek committed rCOMM640505851ab4: [native] Render SIWE restore panel (authored by tomek).
[native] Render SIWE restore panel
Tue, Dec 10, 10:12 AM
tomek committed rCOMMa2c60c0a5c4a: [native] Create a restore backup screen (authored by tomek).
[native] Create a restore backup screen
Tue, Dec 10, 10:12 AM
tomek closed D14038: [native] Navigate from the QR screen to the restore screen.
Tue, Dec 10, 10:12 AM
tomek closed D14067: [native] Introduce a password account restore screen.
Tue, Dec 10, 10:12 AM
tomek committed rCOMM68d3861c3304: [native] Navigate from the QR screen to the restore screen (authored by tomek).
[native] Navigate from the QR screen to the restore screen
Tue, Dec 10, 10:12 AM
tomek committed rCOMMb4442d06880c: [native] Introduce a password account restore screen (authored by tomek).
[native] Introduce a password account restore screen
Tue, Dec 10, 10:12 AM
tomek closed D13907: [native] Introduce a restore screen.
Tue, Dec 10, 10:12 AM
tomek committed rCOMM7d5d716deae4: [native] Introduce a restore screen (authored by tomek).
[native] Introduce a restore screen
Tue, Dec 10, 10:12 AM
tomek closed D14066: [native] Extract the buttons from the logged out modal.
Tue, Dec 10, 10:12 AM
tomek closed D14064: [native] Make QR screen style consistent with the registration flow.
Tue, Dec 10, 10:12 AM
tomek committed rCOMMb298be8faf64: [native] Extract the buttons from the logged out modal (authored by tomek).
[native] Extract the buttons from the logged out modal
Tue, Dec 10, 10:12 AM
tomek committed rCOMMa7176ef9fc9d: [native] Make QR screen style consistent with the registration flow (authored by tomek).
[native] Make QR screen style consistent with the registration flow
Tue, Dec 10, 10:12 AM
tomek closed D13906: [native] Update the logged out modal.
Tue, Dec 10, 10:12 AM
tomek committed rCOMMd36b7e5eca1b: [native] Update the logged out modal (authored by tomek).
[native] Update the logged out modal
Tue, Dec 10, 10:12 AM
tomek added a comment to D14084: [native] Create a restore backup screen.

Looks okay. Would be nice to be able to show progress, but I recognize we'll probably need to wait on backup size calculation for that.

Tue, Dec 10, 9:38 AM
tomek updated the summary of D14066: [native] Extract the buttons from the logged out modal.
Tue, Dec 10, 9:33 AM
ashoat committed rCOMM988e98b5747d: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Tue, Dec 10, 8:36 AM
ashoat added a reverting change for rCOMM8c0c33cf37b5: [native] Temporary changes for staff release: rCOMM988e98b5747d: Revert "[native] Temporary changes for staff release".
Tue, Dec 10, 8:36 AM
ashoat committed rCOMMb893f8f19f08: [native] codeVersion -> 446 (authored by ashoat).
[native] codeVersion -> 446
Tue, Dec 10, 8:36 AM
ashoat committed rCOMM8c0c33cf37b5: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Tue, Dec 10, 8:36 AM
ashoat committed rCOMM9175a885bec1: [native] codeVersion -> 445 (authored by ashoat).
[native] codeVersion -> 445
Tue, Dec 10, 8:36 AM
ashoat committed rCOMM6757d026e4e4: [web][keyserver] codeVersion -> 145 (authored by ashoat).
[web][keyserver] codeVersion -> 145
Tue, Dec 10, 8:36 AM