Looks great! Please wait for Android build to complete successfully before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 27 2023
Mar 27 2023
ashoat accepted D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
marcin updated the diff for D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
- Ensure there is only one promise calling Java notifications permission code at a time.
- Use Promise.all
It wasn't initially obvious to me that this is the right approach. But after some time it seems to make sense.
inka updated subscribers of D7117: [keyserver] Add migration - process messages in our db for search.
Changes due to changes in D7076
I will continue the discussion on parsing after I scope my next goal
Address review: rename the table and give a name to the fulltext index. All indexes are named by concatenating the names of the columns they index, so I'm using this convention.
Goinng to continue the discussion on parsing in D7077
rebase before landing
address ashoats comment
ginsu updated the diff for D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.
rebase before landing
ginsu added a comment to D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.
Not familiar with that error myself, wondering what "initialization" means in this context (is it a circular dependency issue?)
Mar 26 2023
Mar 26 2023
atul added inline comments to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
change avatar !== null check to avatar truthiness check
atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
rebase before addressing all feedback
atul updated the diff for D7176: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`.
rebase and land
Accepting to unblock but the pattern of copy-paste is concerning
Please make sure @inka creates the task I requested before you land this
ashoat accepted D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.
Looks like this is just a move diff so blindly accepting. Not familiar with that error myself, wondering what "initialization" means in this context (is it a circular dependency issue?)
ginsu added inline comments to D7137: [native] render thread avatars for parent/child threads in thread settings.
ginsu updated the diff for D7137: [native] render thread avatars for parent/child threads in thread settings.
address feedback
address feedback
ginsu updated the diff for D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
address feedback
ginsu retitled D7134: [native] update message list header to new design from [native] render thread avatar in message list header title
update message list header to new desgin
No longer necessary with D7178
In D7132#212051, @ashoat wrote:Mostly questions
remove stray ?
change order
new version of useGetAvatarForThread
Mar 25 2023
Mar 25 2023
Also throwing in @kuba, since he has been looking at chat-selectors.js recently too
rebase
address review