Page MenuHomePhabricator
Feed Advanced Search

Wed, May 22

varun accepted D12178: [rust] Fix Clippy warnings about DateTime.
Wed, May 22, 7:46 AM
varun accepted D12175: [shared] Fix Clippy warnings in comm-opaque2.
Wed, May 22, 7:44 AM
varun accepted D12176: [blob] Fix Clippy warnings in Blob service.
Wed, May 22, 7:43 AM
varun resigned from D12158: [lib] Remove `getCurrentUser`.

i'm probably not a good reviewer of this code

Wed, May 22, 7:42 AM
varun resigned from D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.

i'm probably not a good reviewer of this code

Wed, May 22, 7:41 AM
varun resigned from D12150: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly` required.

i'm probably not a good reviewer of this code

Wed, May 22, 7:41 AM
varun resigned from D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.

i'm probably not a good reviewer of this code

Wed, May 22, 7:41 AM

Tue, May 21

varun requested review of D12161: [keyserver] call uploadSecondaryDeviceKeysAndLogIn.
Tue, May 21, 12:14 PM
varun requested review of D12155: [keyserver] uploadSecondaryDeviceKeysAndLogIn client method.
Tue, May 21, 9:39 AM
varun requested review of D12151: [rust-node-addon] generate_nonce client method.
Tue, May 21, 8:54 AM
varun added inline comments to D12146: [keyserver][lib][web] set up anonymous connection with tunnelbroker on keyserver and handle DEVICE_LIST_UPDATE_SUCCESS.
Tue, May 21, 8:19 AM
varun requested review of D12146: [keyserver][lib][web] set up anonymous connection with tunnelbroker on keyserver and handle DEVICE_LIST_UPDATE_SUCCESS.
Tue, May 21, 7:51 AM
varun accepted D12135: [web] Retrieve username on secondary device login.
Tue, May 21, 2:00 AM
varun accepted D12134: [native] Process username received in AuthResponse.
Tue, May 21, 2:00 AM
varun accepted D12127: [protos][identity] Add username to AuthResponse.
Tue, May 21, 1:58 AM

Mon, May 20

varun planned changes to D12128: [native] try to log in if native user is missing CSAT.
Mon, May 20, 8:42 AM
varun requested review of D12128: [native] try to log in if native user is missing CSAT.
Mon, May 20, 8:10 AM
varun closed D11910: [native] add reserved registration methods to IdentityServiceContextProvider.
Mon, May 20, 7:05 AM
varun committed rCOMM3963159ef6c5: [native] add reserved registration methods to IdentityServiceContextProvider (authored by varun).
[native] add reserved registration methods to IdentityServiceContextProvider
Mon, May 20, 7:05 AM
varun closed D11909: [native] add registerReservedWalletUser and registerReservedPasswordUser to CommRustModule.
Mon, May 20, 7:05 AM
varun committed rCOMM798826827ed8: [native] add registerReservedWalletUser and registerReservedPasswordUser to… (authored by varun).
[native] add registerReservedWalletUser and registerReservedPasswordUser to…
Mon, May 20, 7:05 AM
varun closed D11908: [native_rust_library] reserved registration client methods for wallet and password users.
Mon, May 20, 7:05 AM
varun closed D11906: [native] handler that just logs out if missing CSAT and no password.
Mon, May 20, 7:05 AM
varun committed rCOMMcc67d00576f0: [native_rust_library] reserved registration client methods for wallet and… (authored by varun).
[native_rust_library] reserved registration client methods for wallet and…
Mon, May 20, 7:05 AM
varun committed rCOMMcbf4b75886d2: [native] handler that just logs out if missing CSAT and no password (authored by varun).
[native] handler that just logs out if missing CSAT and no password
Mon, May 20, 7:05 AM
varun closed D11861: [native_rust_library] refactor helper structs to avoid duplication.
Mon, May 20, 7:05 AM
varun committed rCOMM8628ce72513c: [native_rust_library] refactor helper structs to avoid duplication (authored by varun).
[native_rust_library] refactor helper structs to avoid duplication
Mon, May 20, 7:05 AM
varun added inline comments to D11906: [native] handler that just logs out if missing CSAT and no password.
Mon, May 20, 6:41 AM
varun closed D12118: [identity] remove extra line.
Mon, May 20, 5:30 AM
varun committed rCOMMd5b5fd5fc80a: [identity] remove extra line (authored by varun).
[identity] remove extra line
Mon, May 20, 5:30 AM
varun published D12118: [identity] remove extra line for review.
Mon, May 20, 5:27 AM
varun closed D12106: [identity] fix origin validation logic.
Mon, May 20, 5:21 AM
varun committed rCOMMa6e536bd0be2: [identity] fix origin validation logic (authored by varun).
[identity] fix origin validation logic
Mon, May 20, 5:21 AM
varun updated the test plan for D12106: [identity] fix origin validation logic.
Mon, May 20, 3:59 AM
varun updated the test plan for D12106: [identity] fix origin validation logic.
Mon, May 20, 3:57 AM
varun requested review of D12106: [identity] fix origin validation logic.
Mon, May 20, 3:54 AM

May 7 2024

varun added inline comments to D11910: [native] add reserved registration methods to IdentityServiceContextProvider.
May 7 2024, 2:40 PM

May 6 2024

varun requested review of D11910: [native] add reserved registration methods to IdentityServiceContextProvider.
May 6 2024, 7:52 AM
varun planned changes to D11912: [lib] add reserved username workflow to identity login actions.

Improve test plan

May 6 2024, 7:50 AM
varun published D11912: [lib] add reserved username workflow to identity login actions for review.
May 6 2024, 7:49 AM
varun planned changes to D11911: [lib] hooks for reserved registration.
May 6 2024, 7:48 AM
varun published D11911: [lib] hooks for reserved registration for review.
May 6 2024, 7:48 AM
varun requested review of D11909: [native] add registerReservedWalletUser and registerReservedPasswordUser to CommRustModule.
May 6 2024, 7:43 AM
varun requested review of D11908: [native_rust_library] reserved registration client methods for wallet and password users.
May 6 2024, 7:38 AM
varun requested review of D11906: [native] handler that just logs out if missing CSAT and no password.
May 6 2024, 7:36 AM

May 5 2024

varun accepted D11891: [native] Don't send reserved ETH addresses to registration flow.
May 5 2024, 10:38 PM
varun closed D11860: [web] differentiate between password and wallet users in MissingCSATModal.
May 5 2024, 5:29 PM
varun committed rCOMM65d6768c3ff8: [web] differentiate between password and wallet users in MissingCSATModal (authored by varun).
[web] differentiate between password and wallet users in MissingCSATModal
May 5 2024, 5:29 PM
varun closed D11844: [web] display modal explaining why user was logged out.
May 5 2024, 5:29 PM
varun closed D11705: [web] log out if CSAT is missing.
May 5 2024, 5:29 PM
varun committed rCOMM4dcf358d2c31: [web] display modal explaining why user was logged out (authored by varun).
[web] display modal explaining why user was logged out
May 5 2024, 5:29 PM
varun committed rCOMM1c3ad32e1772: [web] log out if CSAT is missing (authored by varun).
[web] log out if CSAT is missing
May 5 2024, 5:29 PM

May 2 2024

varun requested review of D11861: [native_rust_library] refactor helper structs to avoid duplication.
May 2 2024, 10:34 PM
varun added inline comments to D11860: [web] differentiate between password and wallet users in MissingCSATModal.
May 2 2024, 10:29 PM
varun requested review of D11860: [web] differentiate between password and wallet users in MissingCSATModal.

iOS build failure looks unrelated

May 2 2024, 10:10 PM
varun accepted D11853: [terraform] metric filters for error logs in identity service.
May 2 2024, 11:37 AM
varun added inline comments to D11854: [terraform] identity service cloudwatch alarms.
May 2 2024, 11:35 AM
varun accepted D11854: [terraform] identity service cloudwatch alarms.

i think @bartek should take a look when he's back

May 2 2024, 11:34 AM
varun requested changes to D11852: [identity] Add prefixes to error logs for filtering.

I was imagining that all the prefixes (e.g. DB Error) would be defined in a module in constants.rs and then used like this:

May 2 2024, 11:29 AM
varun accepted D11848: [lib][native] Automatically retry keyserverAuth during login/registration.
May 2 2024, 5:13 AM

May 1 2024

varun accepted D11845: [lib][native] Reset login state if authoritative keyserver fails.
May 1 2024, 7:01 PM
varun accepted D11849: [native] Prevent user from leaving RegistrationTerms during registration request.
May 1 2024, 11:46 AM
varun requested changes to D11848: [lib][native] Automatically retry keyserverAuth during login/registration.

shouldn't we check that the ServerError is olm_session_creation_failure when determining whether to retry? We'll be spending one of the keyserver's OTKs unnecessarily if the error is not OLM-related

May 1 2024, 10:51 AM
varun accepted D11847: [native] Show "unknown error" alert if keyserver auth fails during registration.
May 1 2024, 10:21 AM
varun accepted D11846: [lib][native][web] Wait until database deletion before rejecting login/registration attempt.
May 1 2024, 10:21 AM
varun requested changes to D11845: [lib][native] Reset login state if authoritative keyserver fails.

what happens if identity account deletion fails after the failed keyserver auth? should we notify the user that their account was registered successfully?

May 1 2024, 10:14 AM

Apr 30 2024

varun accepted D11851: [identity] remove duplicate debug log for HTTP requests.
Apr 30 2024, 1:41 PM
varun accepted D11850: [identity] Disable external crate debug messages.
Apr 30 2024, 1:35 PM
varun requested review of D11844: [web] display modal explaining why user was logged out.
Apr 30 2024, 9:56 AM
varun added a comment to D11705: [web] log out if CSAT is missing.

logging in on web, and then flipping usingCommServicesAccessToken to true

I don't think there's a chance that a flag will flip while the app is working. Have you tried refreshing the app after the flag is set? (this would emulate receiving a new web code version)

Apr 30 2024, 9:40 AM

Apr 29 2024

varun accepted D11830: [identity] add span tracing to token.rs.
Apr 29 2024, 2:01 PM
varun accepted D11829: [identity] Add span tracing to one_time_keys.rs.
Apr 29 2024, 2:01 PM
varun accepted D11828: [identity] add span tracing to identity device_list.rs functions.
Apr 29 2024, 2:01 PM
varun updated the diff for D11705: [web] log out if CSAT is missing.

check if !commServicesAccessToken in useLogOut hook

Apr 29 2024, 2:00 PM
varun added a comment to D11705: [web] log out if CSAT is missing.

The keyserver errors:

[NODEM] ServerError: socket_deauthorized
[NODEM]     at WebSocket.<anonymous> (file:///Users/varun/Code/comm/keyserver/dist/socket/socket.js:128:17)
[NODEM]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
[NODEM]   payload: undefined,
[NODEM]   platformDetails: undefined,
[NODEM]   sanitizedInput: undefined
[NODEM] }
[NODEM] /Users/varun/Code/comm/node_modules/@commapp/olm/olm.js:19
[NODEM] if(ia)m=l?require("path").dirname(m)+"/":__dirname+"/",na=()=>{ma||(fs=require("fs"),ma=require("path"))},ja=function(b,c){na();b=ma.normalize(b);return fs.readFileSync(b,c?void 0:"utf8")},la=b=>{b=ja(b,!0);b.buffer||(b=new Uint8Array(b));return b},ka=(b,c,d)=>{na();b=ma.normalize(b);fs.readFile(b,function(e,f){e?d(e):c(f.buffer)})},1<process.argv.length&&process.argv[1].replace(/\\/g,"/"),process.argv.slice(2),process.on("uncaughtException",function(b){throw b;}),process.on("unhandledRejection",
[NODEM]                                                                                                                                                                                                                                                                                                                                                                                                                                                                           ^
[NODEM] 
[NODEM] Invariant Violation: should be set
[NODEM]     at invariant (/Users/varun/Code/comm/node_modules/invariant/invariant.js:40:15)
[NODEM]     at WebSocket.<anonymous> (file:///Users/varun/Code/comm/keyserver/dist/socket/socket.js:177:9)
[NODEM]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
[NODEM]   framesToPop: 1
[NODEM] }
[NODEM] 
[NODEM] Node.js v20.10.0
Apr 29 2024, 1:58 PM
varun added a comment to D11705: [web] log out if CSAT is missing.

Separately, I'd like to see the test plan extended. @varun, could you try to simulate what would happen to a web client the first time it sees usingCommServicesAccessToken get flipped?

Apr 29 2024, 1:55 PM
varun updated the test plan for D11705: [web] log out if CSAT is missing.
Apr 29 2024, 1:45 PM
varun added a comment to D11705: [web] log out if CSAT is missing.

That said I wouldn't be opposed to adding an || !commServicesAccessToken condition here.

Did you link the right line?

Apr 29 2024, 12:46 PM
varun updated the test plan for D11705: [web] log out if CSAT is missing.
Apr 29 2024, 12:36 PM
varun added a comment to D11705: [web] log out if CSAT is missing.

That said I wouldn't be opposed to adding an || !commServicesAccessToken condition here.

Apr 29 2024, 12:31 PM
varun accepted D11827: [identity] add span tracing to identity database.rs file.
Apr 29 2024, 10:45 AM
varun accepted D11831: [identity] add span tracing to identity farcaster.rs.
Apr 29 2024, 10:44 AM
varun accepted D11826: [identity] add span tracing to identity websocket server.
Apr 29 2024, 10:43 AM
varun accepted D11825: [identity] Add span tracing to grpc handlers.
Apr 29 2024, 10:42 AM
varun accepted D11824: [terraform] add comm_services_use_json_logs env variable for json tracing.
Apr 29 2024, 10:42 AM

Apr 26 2024

varun planned changes to D11811: [web][native] mark keys as published before uploading to identity service.
Apr 26 2024, 1:33 PM
varun updated the test plan for D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Apr 26 2024, 12:59 PM
varun updated the test plan for D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Apr 26 2024, 12:52 PM
varun requested review of D11811: [web][native] mark keys as published before uploading to identity service.
Apr 26 2024, 12:40 PM
varun requested review of D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Apr 26 2024, 12:35 PM
varun closed D11796: [identity] delete all token data on user account deletion.
Apr 26 2024, 11:31 AM
varun committed rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion (authored by varun).
[identity] delete all token data on user account deletion
Apr 26 2024, 11:31 AM
varun closed D11795: [identity] move access token table db methods to separate module.
Apr 26 2024, 11:31 AM
varun committed rCOMM0ef563d1f949: [identity] move access token table db methods to separate module (authored by varun).
[identity] move access token table db methods to separate module
Apr 26 2024, 11:31 AM

Apr 25 2024

varun accepted D11711: [identity] Add verification for replacing a device.
Apr 25 2024, 10:09 PM
varun requested review of D11796: [identity] delete all token data on user account deletion.
Apr 25 2024, 5:00 PM
varun requested review of D11795: [identity] move access token table db methods to separate module.
Apr 25 2024, 4:58 PM
varun closed D11783: [terraform] enable debug logs by default on staging.
Apr 25 2024, 12:00 PM
varun committed rCOMMbceadd1a6c21: [terraform] enable debug logs by default on staging (authored by varun).
[terraform] enable debug logs by default on staging
Apr 25 2024, 12:00 PM
varun requested review of D11783: [terraform] enable debug logs by default on staging.
Apr 25 2024, 11:26 AM