Page MenuHomePhorge
Feed Search

Apr 14 2025

ashoat committed rCOMMb96be8f55989: [native] codeVersion -> 484.
Apr 14 2025, 5:02 PM
ashoat committed rCOMM4771c5e1eb48: [native] Temporary changes for staff release.
Apr 14 2025, 5:02 PM
ashoat committed rCOMM4c4c3f8f8b9b: [native] codeVersion -> 483.
Apr 14 2025, 5:02 PM
ashoat committed rCOMMe8b1307db61d: [web][keyserver] codeVersion -> 161.
Apr 14 2025, 5:02 PM
ashoat committed rCOMM4b1e35f902ba: [shared] Update NEXT_CODE_VERSION.
Apr 14 2025, 5:02 PM
ashoat accepted D14561: [native][web] Add migrations unshimming delete messages.
Apr 14 2025, 1:41 PM
ashoat accepted D14574: [native] Fix uploading transcoded media.
Apr 14 2025, 1:38 PM

Apr 11 2025

ashoat requested changes to D14574: [native] Fix uploading transcoded media.

Apologies if the update was in progress, but passing back to you. Feel free to re-request review when the test plan has been updated (and performed) as requested above

Apr 11 2025, 11:16 PM
ashoat added a comment to D14574: [native] Fix uploading transcoded media.

It seems like you've updated the test plan to include the string "(image and video that requires and doesn't require transcoding)", which I suppose is an improvement, but very far from what I was looking for.

Apr 11 2025, 11:15 PM
ashoat added inline comments to D14574: [native] Fix uploading transcoded media.
Apr 11 2025, 7:01 PM
ashoat requested changes to D14574: [native] Fix uploading transcoded media.

In my opinion, inadequate testing of your changes is the reason our mobile releases have been blocked for the past 2 weeks.

Apr 11 2025, 7:00 PM
ashoat requested changes to D14561: [native][web] Add migrations unshimming delete messages.

A cursory glance shows that createAsyncMigrate handles calling handleReduxMigrationFailure when an exception is thrown. I wish both @tomek and @bartek had looked at the code a little closer here.

Apr 11 2025, 3:06 PM
ashoat added a comment to D14566: [native] Fix uploading images with ph-upload:// scheme.

It seems like we're discarding the processed media, since we're returning uploadURI to the caller (non-processed media). I hope I'm missing something here, as both @angelika and @bartek did not flag this...

Apr 11 2025, 2:49 PM

Apr 10 2025

ashoat accepted D14534: [lib] Add a new endpoint for deleting messages.

Accepting pending resolution of CI

Apr 10 2025, 3:59 PM
ashoat closed D14565: [keyserver] Introduce checkThreadsOr.
Apr 10 2025, 3:27 PM
ashoat committed rCOMM7fcc58529c58: [keyserver] Introduce checkThreadsOr.
Apr 10 2025, 3:27 PM
ashoat accepted D14556: [keyserver] Handle deleted messages when searching.
Apr 10 2025, 3:00 PM
ashoat added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 2:59 PM
ashoat requested changes to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 2:32 PM
ashoat published D14565: [keyserver] Introduce checkThreadsOr for review.
Apr 10 2025, 2:32 PM
ashoat added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 2:14 PM
ashoat accepted D14564: [lib] Handle deleted messages when generating notifs.
Apr 10 2025, 2:04 PM
ashoat added a reviewer for D14561: [native][web] Add migrations unshimming delete messages: bartek.
Apr 10 2025, 1:41 PM
ashoat requested changes to D14556: [keyserver] Handle deleted messages when searching.
Apr 10 2025, 1:14 PM
ashoat requested changes to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 3:12 AM
ashoat added inline comments to D14548: [native][web] Hide edit label and reactions of deleted messages.
Apr 10 2025, 3:12 AM
ashoat added a comment to D14547: [web] Disable all the actions for a deleted message.

Looks a little weird, but it's okay

Apr 10 2025, 3:07 AM
ashoat accepted D14546: [native] Update message height measurement logic to handle deleted messages.

I suppose the italics don't change the height

Apr 10 2025, 3:07 AM
ashoat accepted D14545: [native] Display a deleted message on native.
Apr 10 2025, 3:05 AM
ashoat accepted D14544: [web] Display a deleted message on web.
Apr 10 2025, 3:04 AM
ashoat accepted D14542: [native][web] Show an option to delete a message.
Apr 10 2025, 3:02 AM
ashoat added inline comments to D14534: [lib] Add a new endpoint for deleting messages.
Apr 10 2025, 3:00 AM
ashoat accepted D14561: [native][web] Add migrations unshimming delete messages.
Apr 10 2025, 2:56 AM
ashoat accepted D14560: [native][web] Add migrations unshimming delete message operations.
Apr 10 2025, 2:55 AM

Apr 8 2025

ashoat accepted D14557: [native][web] Handle deleted messages when searching.
Apr 8 2025, 1:37 PM
ashoat accepted D14556: [keyserver] Handle deleted messages when searching.
Apr 8 2025, 1:36 PM
ashoat accepted D14555: [web] Fix enum casing in sharedWorkerStatuses.
Apr 8 2025, 1:30 PM

Apr 7 2025

ashoat accepted D14554: [lib][native][web] Wait for DB reset before generating QR.
Apr 7 2025, 2:03 PM

Apr 6 2025

ashoat committed rCOMM37718763a43e: Revert "[native] Temporary changes for staff release".
Apr 6 2025, 4:14 AM
ashoat added a reverting change for rCOMM3424b6b59f06: [native] Temporary changes for staff release: rCOMM37718763a43e: Revert "[native] Temporary changes for staff release".
Apr 6 2025, 4:14 AM
ashoat committed rCOMM5749289bbc6d: [native] codeVersion -> 482.
Apr 6 2025, 4:14 AM
ashoat committed rCOMM3424b6b59f06: [native] Temporary changes for staff release.
Apr 6 2025, 4:14 AM
ashoat committed rCOMM393027b518e8: [native] codeVersion -> 481.
Apr 6 2025, 4:14 AM
ashoat added a reverting change for rCOMMd91b1ae4336a: [native] Temporary changes for staff release: rCOMMd76d961e3f04: Revert "[native] Temporary changes for staff release".
Apr 6 2025, 3:00 AM
ashoat committed rCOMMd76d961e3f04: Revert "[native] Temporary changes for staff release".
Apr 6 2025, 3:00 AM
ashoat committed rCOMMda543d4b09de: [native] codeVersion -> 480.
Apr 6 2025, 3:00 AM
ashoat committed rCOMMd91b1ae4336a: [native] Temporary changes for staff release.
Apr 6 2025, 3:00 AM
ashoat committed rCOMM3d10bcc600b1: [native] codeVersion -> 479.
Apr 6 2025, 3:00 AM
ashoat committed rCOMMe82c5972be0d: Revert "Update app icons across iOS, Android, Windows, and macOS. (#315)".
Apr 6 2025, 3:00 AM
ashoat added a reverting change for rCOMM6d563ad2695a: Update app icons across iOS, Android, Windows, and macOS. (#315): rCOMMe82c5972be0d: Revert "Update app icons across iOS, Android, Windows, and macOS. (#315)".
Apr 6 2025, 3:00 AM
ashoat committed rCOMMd7a83ca4616f: [terraform] Bump keyserver image to 1.0.160.
Apr 6 2025, 3:00 AM
ashoat committed rCOMM7269149f3bee: Revert "[native] Temporary changes for staff release".
Apr 6 2025, 2:27 AM
ashoat added a reverting change for rCOMMdef1b13a94f1: [native] Temporary changes for staff release: rCOMM7269149f3bee: Revert "[native] Temporary changes for staff release".
Apr 6 2025, 2:27 AM
ashoat committed rCOMM2abaac9461e8: [native] codeVersion -> 478.
Apr 6 2025, 2:27 AM
ashoat committed rCOMMdef1b13a94f1: [native] Temporary changes for staff release.
Apr 6 2025, 2:27 AM
ashoat committed rCOMM7596e684c7af: [native] codeVersion -> 477.
Apr 6 2025, 2:27 AM
ashoat committed rCOMMf08843305b41: [web][keyserver] codeVersion -> 160.
Apr 6 2025, 2:27 AM
ashoat closed D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.
Apr 6 2025, 2:07 AM
ashoat committed rCOMM57842e70b16f: [native] enable connect farcaster prompt, display prompt after nux tips have… (authored by varun).
Apr 6 2025, 2:07 AM
ashoat closed D14446: [native] flip showCommunityDirectory to true.
Apr 6 2025, 2:07 AM
ashoat committed rCOMM8bf0ff22ab6d: [native] flip showCommunityDirectory to true (authored by varun).
Apr 6 2025, 2:07 AM
ashoat closed D14445: [native] hide community directory prompt on dev.
Apr 6 2025, 2:07 AM
ashoat committed rCOMMcd552a917403: [native] hide community directory prompt on dev (authored by varun).
Apr 6 2025, 2:07 AM
ashoat closed D14444: [lib] launch connect farcaster prompt.
Apr 6 2025, 2:07 AM
ashoat committed rCOMMee08c2068efd: [lib] launch connect farcaster prompt (authored by varun).
Apr 6 2025, 2:07 AM
ashoat accepted D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.
Apr 6 2025, 2:01 AM

Apr 5 2025

ashoat added inline comments to D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.
Apr 5 2025, 8:14 PM

Apr 4 2025

ashoat accepted D14552: [web] Show a confirmation modal when deleting a message.
Apr 4 2025, 9:25 PM
ashoat accepted D14550: [lib] Don't show a message deleting other message in a preview.
Apr 4 2025, 9:24 PM
ashoat accepted D14551: [lib] Don't show a deleted message in a preview.
Apr 4 2025, 9:23 PM
ashoat accepted D14549: [keyserver] Handle unpinning deleted messages.
Apr 4 2025, 4:00 PM
ashoat accepted D14548: [native][web] Hide edit label and reactions of deleted messages.
Apr 4 2025, 3:57 PM
ashoat requested changes to D14542: [native][web] Show an option to delete a message.

I want to review the icon before landing, but this generally looks good

Apr 4 2025, 3:54 PM
ashoat accepted D14546: [native] Update message height measurement logic to handle deleted messages.
Apr 4 2025, 3:52 PM
ashoat accepted D14547: [web] Disable all the actions for a deleted message.

Can you share a screenshot of what a mouseover looks like in this case? Wondering if the timestamp still appears, and where it appears

Apr 4 2025, 3:50 PM
ashoat requested changes to D14545: [native] Display a deleted message on native.

Same feedback as in D14544

Apr 4 2025, 3:49 PM
ashoat requested changes to D14544: [web] Display a deleted message on web.

The white background feels like too strong of a contrast... I feel like a deleted message should be less visible than a non-deleted message. Could we try something closer to what Rahul had in his designs?

Apr 4 2025, 3:49 PM
ashoat accepted D14543: [lib] Update chat selector to return an info telling if a message was deleted.
Apr 4 2025, 3:47 PM
ashoat accepted D14541: [lib] Create a hook that can delete thin and thick messages.
Apr 4 2025, 3:45 PM
ashoat accepted D14540: [lib] Add redux actions and client side endpoint code for deleting messages.
Apr 4 2025, 3:44 PM
ashoat accepted D14539: [lib] Create a DM op spec for deleting messages operation.
Apr 4 2025, 3:44 PM
ashoat accepted D14538: [identity] Add logging to Farcaster RPCs.
Apr 4 2025, 3:42 PM
ashoat added a comment to D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.

Thanks for explaining! I can confirm the fix works for me :)

Apr 4 2025, 3:42 PM
ashoat added a comment to D14542: [native][web] Show an option to delete a message.

For web I agree the style of the icon should be more similar (outline vs fill). For native, does the action sheet only pop up if there are too many actions, and the user clicks more to see the extra actions?

Apr 4 2025, 2:21 PM
ashoat accepted D14536: [native] Add delete message spec to the C++ layer.

Do we need to do anything for it to be included in the Android build, eg. update some CMakeLists.txt file?

Apr 4 2025, 3:49 AM
ashoat accepted D14535: [lib] Add DM operation types for deleting messages.
Apr 4 2025, 3:49 AM
ashoat requested changes to D14534: [lib] Add a new endpoint for deleting messages.
Apr 4 2025, 3:38 AM
ashoat added a comment to D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.

I was asking about why the aspect ratio in the video I put in the bug report is still correct.

Apr 4 2025, 1:52 AM

Apr 2 2025

ashoat added a comment to D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.

Looking at getVideoProcessingPlan more closely, it doesn't seem to mention rotating of the video... not sure how this was handled in the old system, but I guess it was internal to FFmpeg. Sorry for the misdirection!

Apr 2 2025, 3:42 PM
ashoat accepted D14512: [native] Fix reading video files for processing.

Thanks for looking into that! I think at least we can now remove uri from the return of fetchFileInfo – can you make that change before landing?

Apr 2 2025, 3:38 PM
ashoat added a comment to D14514: [native] Handle exif data orientation when returning video size in getVideoInfo on iOS.

Two questions:

Apr 2 2025, 3:24 PM

Apr 1 2025

ashoat requested changes to D14512: [native] Fix reading video files for processing.

Nice find! I tested it and it resolves the issue for me. However, I think we can go deeper in removing the file:// URIs, since it doesn't seem like they're needed anymore.

Apr 1 2025, 5:37 PM

Mar 28 2025

ashoat accepted D14511: [lib] Introduce delete message spec.
Mar 28 2025, 1:45 PM
ashoat accepted D14510: [lib] Introduce delete message type.

Can you retitle all of the diffs in this stack to explicitly reference message deletion? Just realized that they're just generically titled.

Mar 28 2025, 1:42 PM
ashoat committed rCOMM4bcc208fde11: [terraform] Bump keyserver image to 1.0.159.
Mar 28 2025, 1:30 PM
ashoat committed rCOMM5bc75944dfc5: Revert "[native] Temporary changes for staff release".
Mar 28 2025, 4:41 AM
ashoat added a reverting change for rCOMM4e575d9d27de: [native] Temporary changes for staff release: rCOMM5bc75944dfc5: Revert "[native] Temporary changes for staff release".
Mar 28 2025, 4:41 AM
ashoat committed rCOMM39e43b678844: [native] codeVersion -> 476.
Mar 28 2025, 4:41 AM
ashoat committed rCOMM4e575d9d27de: [native] Temporary changes for staff release.
Mar 28 2025, 4:41 AM
ashoat committed rCOMM15f5d7212c96: [native] codeVersion -> 475.
Mar 28 2025, 4:41 AM