Apologies if the update was in progress, but passing back to you. Feel free to re-request review when the test plan has been updated (and performed) as requested above
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Apr 14 2025
Apr 11 2025
It seems like you've updated the test plan to include the string "(image and video that requires and doesn't require transcoding)", which I suppose is an improvement, but very far from what I was looking for.
In my opinion, inadequate testing of your changes is the reason our mobile releases have been blocked for the past 2 weeks.
Apr 10 2025
Accepting pending resolution of CI
Looks a little weird, but it's okay
I suppose the italics don't change the height
Apr 8 2025
Apr 7 2025
Apr 6 2025
Apr 5 2025
Apr 4 2025
I want to review the icon before landing, but this generally looks good
Can you share a screenshot of what a mouseover looks like in this case? Wondering if the timestamp still appears, and where it appears
Same feedback as in D14544
The white background feels like too strong of a contrast... I feel like a deleted message should be less visible than a non-deleted message. Could we try something closer to what Rahul had in his designs?
Thanks for explaining! I can confirm the fix works for me :)
For web I agree the style of the icon should be more similar (outline vs fill). For native, does the action sheet only pop up if there are too many actions, and the user clicks more to see the extra actions?
Do we need to do anything for it to be included in the Android build, eg. update some CMakeLists.txt file?
I was asking about why the aspect ratio in the video I put in the bug report is still correct.
Apr 2 2025
Looking at getVideoProcessingPlan more closely, it doesn't seem to mention rotating of the video... not sure how this was handled in the old system, but I guess it was internal to FFmpeg. Sorry for the misdirection!
Thanks for looking into that! I think at least we can now remove uri from the return of fetchFileInfo – can you make that change before landing?
Two questions:
Apr 1 2025
Nice find! I tested it and it resolves the issue for me. However, I think we can go deeper in removing the file:// URIs, since it doesn't seem like they're needed anymore.
Mar 28 2025
Can you retitle all of the diffs in this stack to explicitly reference message deletion? Just realized that they're just generically titled.