Page MenuHomePhabricator
Feed Advanced Search

Apr 16 2024

will closed D11630: [lib/native] Delete FIDProvider.
Apr 16 2024, 9:24 PM
will committed rCOMM609c93977002: [lib/native] Delete FIDProvider (authored by will).
[lib/native] Delete FIDProvider
Apr 16 2024, 9:24 PM
will closed D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Apr 16 2024, 9:24 PM
will closed D11628: [lib] Make synced metadata name field an enum.
Apr 16 2024, 9:24 PM
will committed rCOMM8ce3feec147e: [native][lib] Replace usages of FIDProvider with Synced Metadata Store (authored by will).
[native][lib] Replace usages of FIDProvider with Synced Metadata Store
Apr 16 2024, 9:24 PM
will committed rCOMM051c63bec1d7: [lib] Make synced metadata name field an enum (authored by will).
[lib] Make synced metadata name field an enum
Apr 16 2024, 9:24 PM
will closed D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.
Apr 16 2024, 9:24 PM
will committed rCOMM340733ee63e9: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear (authored by will).
Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear
Apr 16 2024, 9:24 PM
will updated the diff for D11616: [native] migrate threadActivityStore to SQLite.

rebase

Apr 16 2024, 9:04 PM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

rebase

Apr 16 2024, 8:59 PM
will updated the diff for D11614: [sqlite] Implement C++ code for native to get sqlite thread activity entries.

thread_activity_store_entry => threadActivityStoreEntry

Apr 16 2024, 8:58 PM
will requested review of D11672: create new aux user store action for clearing fids.
Apr 16 2024, 3:36 PM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.

Given that we're already checking farcaster friends in a useEffect, should we consider adding a syncing action type that not only adds new farcaster friends but also removes farcaster friends that we've unfollowed as well?

Apr 16 2024, 3:31 PM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.
Apr 16 2024, 3:29 PM
will updated the test plan for D11639: [lib] Add farcaster friend fids to sqlite.
Apr 16 2024, 3:27 PM
will updated the summary of D11639: [lib] Add farcaster friend fids to sqlite.
Apr 16 2024, 3:25 PM
will updated the diff for D11639: [lib] Add farcaster friend fids to sqlite.

update to use commFCUsers and also clear prior fids

Apr 16 2024, 3:21 PM
will requested review of D11671: Makes fid optionally null so that we can delete the fid later.
Apr 16 2024, 2:50 PM
will updated the summary of D11639: [lib] Add farcaster friend fids to sqlite.
Apr 16 2024, 2:35 PM
will added inline comments to D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Apr 16 2024, 11:50 AM
will updated the diff for D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.

create useCurrentUserFID hook instead of get function

Apr 16 2024, 11:48 AM
will accepted D11667: [lib] Fix legacy register and SIWE.
Apr 16 2024, 11:34 AM

Apr 15 2024

will updated the diff for D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.

replace useSelector with function

Apr 15 2024, 9:31 PM
will requested review of D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.
Apr 15 2024, 2:45 PM
will updated the summary of D11618: [native][web] Read thread activity entries from SQLite on app start.
Apr 15 2024, 2:30 PM
will updated the test plan for D11616: [native] migrate threadActivityStore to SQLite.
Apr 15 2024, 7:09 AM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

entrie to entries

Apr 15 2024, 6:32 AM
will updated the diff for D11578: [lib] refactor thread activity reducer to use sqlite operations.

rebase

Apr 15 2024, 6:27 AM
will updated the diff for D11584: [sqlite/native] Make C++ thread activity sqlite ops available to native.

add new line

Apr 15 2024, 5:22 AM
will updated the test plan for D11576: [native/sqlite] Create thread activity table in sqlite.
Apr 15 2024, 5:14 AM
will added a comment to D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.

It's not possible for ThreadActivityStoreEntry to be an empty object?

Apr 15 2024, 5:07 AM

Apr 12 2024

will updated the summary of D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Apr 12 2024, 9:02 AM
will closed D11640: [lib] rewrite integrityInfos ThreadHashes.
Apr 12 2024, 9:01 AM
will committed rCOMMa00666640f0d: [lib] rewrite integrityInfos ThreadHashes (authored by will).
[lib] rewrite integrityInfos ThreadHashes
Apr 12 2024, 9:01 AM

Apr 11 2024

will planned changes to D11639: [lib] Add farcaster friend fids to sqlite.
Apr 11 2024, 11:46 AM
will requested review of D11640: [lib] rewrite integrityInfos ThreadHashes.
Apr 11 2024, 11:19 AM
will requested review of D11639: [lib] Add farcaster friend fids to sqlite.
Apr 11 2024, 11:02 AM
will closed D11626: [lib] have landing send `fid` as a string and not a number.
Apr 11 2024, 10:25 AM
will committed rCOMM17bad29c6ff5: [lib] have landing send `fid` as a string and not a number (authored by will).
[lib] have landing send `fid` as a string and not a number
Apr 11 2024, 10:25 AM
will updated the diff for D11626: [lib] have landing send `fid` as a string and not a number.

remove toString() on url which is already a string

Apr 11 2024, 8:57 AM
will retitled D11626: [lib] have landing send `fid` as a string and not a number from [lib] convert `data.fid` which is a number to a string to [lib] have landing send `fid` as a string and not a number.
Apr 11 2024, 12:19 AM
will updated the diff for D11626: [lib] have landing send `fid` as a string and not a number.

toString on landing instead of after parse

Apr 11 2024, 12:17 AM
will requested review of D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Apr 11 2024, 12:01 AM

Apr 10 2024

will requested review of D11630: [lib/native] Delete FIDProvider.
Apr 10 2024, 11:54 PM
will requested review of D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.
Apr 10 2024, 11:40 PM
will requested review of D11628: [lib] Make synced metadata name field an enum.
Apr 10 2024, 11:39 PM
will requested review of D11626: [lib] have landing send `fid` as a string and not a number.
Apr 10 2024, 11:35 PM
will updated the diff for D11578: [lib] refactor thread activity reducer to use sqlite operations.

Consider case of optional fields

Apr 10 2024, 2:03 PM
will updated the diff for D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.

Make lastNavigatedTo optional as well

Apr 10 2024, 1:28 PM
will planned changes to D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.

Add lastNavigatedTo

Apr 10 2024, 12:53 PM
will retitled D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry from [lib] Make `lastPruned` or `lastNavigatedTo` type optional for thread activity entry to [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.
Apr 10 2024, 12:53 PM
will retitled D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry from [lib] Make `lastPruned` type optional for thread activity entry to [lib] Make `lastPruned` or `lastNavigatedTo` type optional for thread activity entry.
Apr 10 2024, 12:52 PM
will added a comment to D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.

The updateThreadLastNavigatedActionType action type is only dispatched by the ThreadScreenTracker react component. The messageStorePruneActionType is only dispatched by the MessageStorePruner.

Apr 10 2024, 12:46 PM
will requested review of D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.
Apr 10 2024, 11:14 AM
will updated the summary of D11575: [lib] Add thread activity store ops.
Apr 10 2024, 10:46 AM

Apr 9 2024

will requested review of D11618: [native][web] Read thread activity entries from SQLite on app start.
Apr 9 2024, 11:29 PM
will requested review of D11617: [native][web] Start processing thread activity store with sqlite operations.
Apr 9 2024, 11:23 PM
will requested review of D11616: [native] migrate threadActivityStore to SQLite.
Apr 9 2024, 11:19 PM
will requested review of D11615: [sqlite] Implement processing thread activity on web worker.
Apr 9 2024, 11:13 PM
will requested review of D11614: [sqlite] Implement C++ code for native to get sqlite thread activity entries.
Apr 9 2024, 11:10 PM
will requested review of D11584: [sqlite/native] Make C++ thread activity sqlite ops available to native.
Apr 9 2024, 10:26 AM

Apr 8 2024

will added a comment to D11576: [native/sqlite] Create thread activity table in sqlite.
In D11576#333165, @atul wrote:

Would be good to include both create_schema and migration flow in Test Plan

Apr 8 2024, 10:33 AM
will requested review of D11581: [sqlite] Implement C++ methods for thread activity.
Apr 8 2024, 7:39 AM
will requested review of D11578: [lib] refactor thread activity reducer to use sqlite operations.
Apr 8 2024, 7:30 AM
will updated the diff for D11579: [lib] return ops from thread activity reducer.

rebase

Apr 8 2024, 6:55 AM
will requested review of D11579: [lib] return ops from thread activity reducer.
Apr 8 2024, 6:51 AM
will requested review of D11576: [native/sqlite] Create thread activity table in sqlite.
Apr 8 2024, 6:33 AM
will requested review of D11575: [lib] Add thread activity store ops.
Apr 8 2024, 6:31 AM

Apr 5 2024

will closed D11566: [native] Add auxUserStore to persist blacklist.
Apr 5 2024, 4:02 PM
will committed rCOMM5ba637982dd6: [native] Add auxUserStore to persist blacklist (authored by will).
[native] Add auxUserStore to persist blacklist
Apr 5 2024, 4:02 PM
will added a reviewer for D11566: [native] Add auxUserStore to persist blacklist: kamil.
Apr 5 2024, 3:33 PM
will updated the summary of D11566: [native] Add auxUserStore to persist blacklist.
Apr 5 2024, 3:33 PM
will added a comment to D11566: [native] Add auxUserStore to persist blacklist.

Is this diff blocking native release? Is there a task tracking the rehydration warning?

Apr 5 2024, 3:20 PM
will retitled D11566: [native] Add auxUserStore to persist blacklist from [native] Add auxUserStore to persist blacklist to avoid rehydration warning to [native] Add auxUserStore to persist blacklist.
Apr 5 2024, 3:17 PM
will requested review of D11566: [native] Add auxUserStore to persist blacklist.
Apr 5 2024, 2:41 PM

Apr 4 2024

will accepted D11562: [web] Use getMessageForException in shared worker connectHandler.
Apr 4 2024, 9:48 PM
will closed D11528: [lib] Introduce aux user store reducer and action types.
Apr 4 2024, 9:42 PM
will closed D11529: [native][web] read aux user store on app startup.
Apr 4 2024, 9:42 PM
will committed rCOMM5e04b7176805: [native][web] read aux user store on app startup (authored by will).
[native][web] read aux user store on app startup
Apr 4 2024, 9:42 PM
will committed rCOMMa5988bd9d97d: [lib] Introduce aux user store reducer and action types (authored by will).
[lib] Introduce aux user store reducer and action types
Apr 4 2024, 9:42 PM
will closed D11511: [sqlite] implement processing aux user store ops on worker.
Apr 4 2024, 9:42 PM
will closed D11510: [sqlite] Implement C++ for native to get all aux user infos.
Apr 4 2024, 9:42 PM
will committed rCOMM7760faea083c: [sqlite] implement processing aux user store ops on worker (authored by will).
[sqlite] implement processing aux user store ops on worker
Apr 4 2024, 9:42 PM
will committed rCOMMd30fd946950c: [sqlite] Implement C++ for native to get all aux user infos (authored by will).
[sqlite] Implement C++ for native to get all aux user infos
Apr 4 2024, 9:42 PM
will closed D11509: [sqlite] implement C++ aux user store ops.
Apr 4 2024, 9:42 PM
will closed D11508: [sqlite] introduce aux user store C++ methods.
Apr 4 2024, 9:42 PM
will committed rCOMM3ecb8d469dc4: [sqlite] introduce aux user store C++ methods (authored by will).
[sqlite] introduce aux user store C++ methods
Apr 4 2024, 9:42 PM
will committed rCOMM5a0daf51e0c7: [sqlite] implement C++ aux user store ops (authored by will).
[sqlite] implement C++ aux user store ops
Apr 4 2024, 9:42 PM
will closed D11507: [sqlite] add aux users table for aux user store data.
Apr 4 2024, 9:42 PM
will closed D11506: [lib] introduce the aux user store ops.
Apr 4 2024, 9:42 PM
will committed rCOMMf8966e0ad79c: [sqlite] add aux users table for aux user store data (authored by will).
[sqlite] add aux users table for aux user store data
Apr 4 2024, 9:42 PM
will committed rCOMM9f3470cecb74: [lib] introduce the aux user store ops (authored by will).
[lib] introduce the aux user store ops
Apr 4 2024, 9:42 PM
will closed D11505: [lib] introduce aux user types.
Apr 4 2024, 9:42 PM
will committed rCOMM32613d400084: [lib] introduce aux user types (authored by will).
[lib] introduce aux user types
Apr 4 2024, 9:41 PM
will updated the test plan for D11507: [sqlite] add aux users table for aux user store data.
Apr 4 2024, 9:20 PM
will updated the diff for D11508: [sqlite] introduce aux user store C++ methods.

add newline

Apr 4 2024, 9:07 PM
will updated the diff for D11510: [sqlite] Implement C++ for native to get all aux user infos.

rebase before landing

Apr 4 2024, 7:36 PM
will added inline comments to D11508: [sqlite] introduce aux user store C++ methods.
Apr 4 2024, 1:28 PM
will added inline comments to D11506: [lib] introduce the aux user store ops.
Apr 4 2024, 1:25 PM
will updated the diff for D11528: [lib] Introduce aux user store reducer and action types.

rebase

Apr 4 2024, 1:23 PM