- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 1 2024
Apr 1 2024
varun requested review of D11515: [keyserver] expose getFarcasterUsers client method to JS on keyserver.
Mar 29 2024
Mar 29 2024
Mar 28 2024
Mar 28 2024
varun committed rCOMM3806a88cd6aa: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient… (authored by varun).
[lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient…
varun committed rCOMM8cda325dd924: [native] add unlinkFarcasterAccount to CommRustModule (authored by varun).
[native] add unlinkFarcasterAccount to CommRustModule
varun committed rCOMMcfc0654d4c18: [native_rust_library] unlink_farcaster_account method (authored by varun).
[native_rust_library] unlink_farcaster_account method
[identity] unlink farcaster account RPC
varun committed rCOMM7e269eae587e: [identity] on linkFarcasterUser we should return an error if the FID already… (authored by varun).
[identity] on linkFarcasterUser we should return an error if the FID already…
varun committed rCOMMc648927875bc: [identity] check if fid is already taken when registering new user (authored by varun).
[identity] check if fid is already taken when registering new user
varun committed rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user (authored by varun).
[identity] don't let linkFarcasterAccount overwrite existing fid for user
[web] add client methods to web
varun committed rCOMM046f7eed864b: [native] add linkFarcasterAccount to native IdentityServiceContextProvider (authored by varun).
[native] add linkFarcasterAccount to native IdentityServiceContextProvider
varun committed rCOMM80b046bb17c9: [native] add linkFarcasterAccount to commRustModule (authored by varun).
[native] add linkFarcasterAccount to commRustModule
varun committed rCOMM607b65279825: [native_rust_library] implement link_farcaster_account client method (authored by varun).
[native_rust_library] implement link_farcaster_account client method
varun committed rCOMMf1d96072c6f2: [identity] link farcaster account implementation (authored by varun).
[identity] link farcaster account implementation
varun committed rCOMM17638e45a66f: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider (authored by ashoat).
[lib][native] Add getFarcasterUsers to IdentityServiceContextProvider
varun committed rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method (authored by varun).
[native_rust_library] get_farcaster_users client method
varun committed rCOMM1c4801b3aae5: [native] add getFarcasterUsers to commRustModule (authored by varun).
[native] add getFarcasterUsers to commRustModule
varun committed rCOMM88d9a0987b2b: [identity] get farcaster users rpc implementation (authored by varun).
[identity] get farcaster users rpc implementation
varun committed rCOMMaa1feb75a585: [identity] db method to get users for a set of farcaster ids (authored by varun).
[identity] db method to get users for a set of farcaster ids
[terraform] add GSI for farcasterID
varun committed rCOMMcbc627ce542e: [native] expose farcaster id param to native identity service context provider (authored by varun).
[native] expose farcaster id param to native identity service context provider
varun committed rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs (authored by varun).
[identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs
varun committed rCOMM75706c132d20: [proto][identity] add optional fid to registration request messages (authored by varun).
[proto][identity] add optional fid to registration request messages
varun added inline comments to D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
do we need to change any client code now that some of these RPCs are returning "not found" ?
Mar 27 2024
Mar 27 2024
varun added a comment to D11412: [identity] check if fid is already taken when registering new user.
In D11412#329178, @ashoat wrote:
In D11410#329193, @ashoat wrote:Do we need to update anything for registerPasswordUser or registerWalletUser on web?
varun added inline comments to D11398: [native] expose farcaster id param to native identity service context provider.
varun updated the test plan for D11401: [identity] db method to get users for a set of farcaster ids.
rebase, but nothing changed
varun updated the diff for D11398: [native] expose farcaster id param to native identity service context provider.
remove TODOs. Here's the linear task, instead: https://linear.app/comm/issue/ENG-7588/replace-params-in-native-rust-library-methods-with-serialized-structs
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
varun requested review of D11412: [identity] check if fid is already taken when registering new user.
varun updated the diff for D11398: [native] expose farcaster id param to native identity service context provider.
squash with D11397
varun requested review of D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
varun requested review of D11409: [native] add linkFarcasterAccount to native IdentityServiceContextProvider.
varun requested review of D11407: [native_rust_library] implement link_farcaster_account client method.
varun requested review of D11405: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider.
varun requested review of D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.
varun requested review of D11396: [proto][identity] add optional fid to registration request messages.
what happens if the user doesn't exist? it seems like we'd want to return a "not found" tonic status in this case, but i'm not sure that's what we're doing here
Mar 25 2024
Mar 25 2024
varun committed rCOMMdfeeffe61ae5: [native] don't generate or send one time keys on login (authored by varun).
[native] don't generate or send one time keys on login
varun committed rCOMMb95b1f3a65f5: [web] don't generate or send one time keys on login (authored by varun).
[web] don't generate or send one time keys on login
varun committed rCOMM40d04cc63042: [web] factor out common code in authNewDeviceKeyUpload (authored by varun).
[web] factor out common code in authNewDeviceKeyUpload
varun committed rCOMM6121c2e62621: [lib][web] deviceKeyUpload -> newDeviceKeyUpload (authored by varun).
[lib][web] deviceKeyUpload -> newDeviceKeyUpload
varun committed rCOMMd2f01b572f83: [keyserver][lib] don't generate one time keys on identity login (authored by varun).
[keyserver][lib] don't generate one time keys on identity login
varun added inline comments to D11360: [keyserver][lib] don't generate one time keys on identity login.
varun added inline comments to D11360: [keyserver][lib] don't generate one time keys on identity login.
Mar 22 2024
Mar 22 2024