Do we still have places where we don't use hasMinCodeVersion function? Do we have to update these?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 19 2023
May 19 2023
ashoat added inline comments to D7870: [landing] fix mobile nav still being shown when window resizes.
ginsu updated the test plan for D7871: [landing] fix mobile nav bar peeking into screen when quickly resizing window.
May 18 2023
May 18 2023
Generally looks good, but confused about some of the changes to existing modals...
update breakpoint width
address comments (the comments regarding the typography were adddressed in the design channel where we decided to continue using the current implmentation)
- Pass address in as well. This can be concluded from the message, but processing that seems wasteful since we have the data in SIWEPanel
- Now that we have 3 strings, I'm using an object instead of a list of params
atul added inline comments to D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission.
atul requested review of D7862: [web] Remove unnecessary `newThreadResult` check in `CommunityCreationModal`.
ashoat added inline comments to D7813: Implement function to encrypt relevant parts of iOS notification.
Fix mistakes made during conflict resolution
ashoat added inline comments to D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
marcin updated the diff for D7813: Implement function to encrypt relevant parts of iOS notification.
Return apn.Notifications object in case of encryption failure. Previous apprhac used '...' syntax, and it failed further since the returned object didn't have 'length()' method.
Add newline
atul committed rCOMM8d48103aa50d: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
[native] `codeVersion` -> 218
[native] Temporary changes for staff release
[native] `codeVersion` -> 217
Rebase
Rebase
Rebase
Rebase
Rebase
Rebase
Rebase
Rebase
Good find @michal! It seems like simply adding the focus-trap-react NPM package, and then wrapping web/modals/modal.react.js in a <FocusTrap> component would make all of our modals "trap focus". This is probably a good thing to do for all modals, and I think it would solve the problem here.
ashoat added inline comments to D7797: Implement olm session updater that has encrypting functionality.
(I think we should do this in a callback rather than an effect, but I think I mentioned that in another diff where I requested changes)
Address review feedback
Thanks for iterating on the types so much! Some small comments inline; please address before landing
Mostly questions
marcin added a comment to D7860: Handle client response to initial notifications encrypted message request.
Added @atul as blocking reviewer for entire substack since he implemented very similar diffs for SignedIdentityKeysBlob.
marcin added 1 blocking reviewer(s) for D7860: Handle client response to initial notifications encrypted message request: atul.
marcin added 1 blocking reviewer(s) for D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request: atul.
marcin added 1 blocking reviewer(s) for D7858: Add initial notifications encrypted message generator to client responses selector on native: atul.
marcin added 1 blocking reviewer(s) for D7856: Add request and response types for the keyserver to request first encrypted message for e2e notifs: atul.
Rebase
Rebase
marcin updated the diff for D7860: Handle client response to initial notifications encrypted message request.
Rebase
marcin updated the diff for D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
Rebase
marcin updated the diff for D7856: Add request and response types for the keyserver to request first encrypted message for e2e notifs.
Rebase
Merged with diff https://phab.comm.dev/D7828
Added setting error state, merged with next diff
I think you could merge this one too. Thanks!
marcin requested review of D7860: Handle client response to initial notifications encrypted message request.
Fixed one thing