Address review
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 20 2023
May 20 2023
Rebsae
May 19 2023
May 19 2023
atul committed rCOMMebdfde6841a5: [web] Introduce `CommunityCreationKeyserverLabel` (authored by atul).
[web] Introduce `CommunityCreationKeyserverLabel`
rebase and land
Ah dang, good thing ' didn't work...
ashoat committed rCOMM4e95e6590db7: [native] Introduce theme reducer to reset theme on log out (authored by ashoat).
[native] Introduce theme reducer to reset theme on log out
ashoat committed rCOMM9be03d1a6ee3: [native] Change border color of KeyserverSelection text input when focused (authored by ashoat).
[native] Change border color of KeyserverSelection text input when focused
ashoat committed rCOMM1ad09c3b0c78: [native] Add explicit borderColor for non-selected RegistrationTile (authored by ashoat).
[native] Add explicit borderColor for non-selected RegistrationTile
ashoat committed rCOMMc4391ebe1f85: [native] Make panelSecondaryForeground light mode correspond to dark mode (authored by ashoat).
[native] Make panelSecondaryForeground light mode correspond to dark mode
ashoat committed rCOMM57c179eba9db: [native] Update panelSecondaryForeground to shadesBlack80 (authored by ashoat).
[native] Update panelSecondaryForeground to shadesBlack80
ashoat committed rCOMMf29fd00ada06: [native] Add code to log user in via ExistingEthereumAccount (authored by ashoat).
[native] Add code to log user in via ExistingEthereumAccount
ashoat committed rCOMM1f14b3067b31: [native] Add wallet identifier tile to ExistingEthereumAccount (authored by ashoat).
[native] Add wallet identifier tile to ExistingEthereumAccount
ashoat committed rCOMMf633c4d64f5d: [native] Introduce ExistingEthereumAccount screen (authored by ashoat).
[native] Introduce ExistingEthereumAccount screen
ashoat committed rCOMM032d7f7f610f: [keyserver][lib] Plumbing for new exact user search endpoint (authored by ashoat).
[keyserver][lib] Plumbing for new exact user search endpoint
ashoat committed rCOMMf973d528ffd1: [native] Factor out success behavior in SIWEPanel (authored by ashoat).
[native] Factor out success behavior in SIWEPanel
In D7893#233851, @ashoat wrote:The whole point of using ' is so that we're using the apostrophe character, not the single-quote character. Please use ’
’ instead of '
The whole point of using ' is so that we're using the apostrophe character, not the single-quote character. Please use ’
atul committed rCOMMb003298adfc8: [web] Increase `font-size` of `formNotice` in `CommunityCreationModal` (authored by atul).
[web] Increase `font-size` of `formNotice` in `CommunityCreationModal`
Nice! Thanks
atul published D7892: [web] Increase `font-size` of `formNotice` in `CommunityCreationModal` for review.
ashoat requested review of D7890: [native] Change border color of KeyserverSelection text input when focused.
ashoat requested review of D7889: [native] Add explicit borderColor for non-selected RegistrationTile.
atul committed rCOMMc4004c4faaec: [web] Introduce `CommunityCreationMembersModal` (authored by atul).
[web] Introduce `CommunityCreationMembersModal`
Cool, thank you for the screen shots to provide context!
rebase and land
Sounds good, thanks for letting me know! These grays are similar enough that updating the calendar is fine.
ashoat requested review of D7888: [native] Make panelSecondaryForeground light mode correspond to dark mode.
Maybe I'm missing something, but could we just have the MobileNav set to display: none at higher breakpoint?
Animations look smooth (I think removing the star background improved "performance" a lot)
In D7866#233348, @ashoat wrote:Generally looks good, but confused about some of the changes to existing modals...
Can you explain what the impact is there, ideally with some screenshots?
tomek requested review of D7733: [native] Display a button and navigate to invite links if they are present.
The code changed significantly. It is much simpler, though.
tomek updated the diff for D7733: [native] Display a button and navigate to invite links if they are present.
Extract button component
[web] Add `subtitle` to `Modal`
atul committed rCOMM2bd45c48ebb9: [web] Remove unnecessary `newThreadResult` check in `CommunityCreationModal` (authored by atul).
[web] Remove unnecessary `newThreadResult` check in `CommunityCreationModal`
rebase and land
Use redux instead of local state. The colors still need to be updated.
atul updated the diff for D7862: [web] Remove unnecessary `newThreadResult` check in `CommunityCreationModal`.
rebase and land
Back to your queue for one question
ashoat added inline comments to D7874: Encrypt Android notifications on the keyserver before sending them.
marcin requested review of D7874: Encrypt Android notifications on the keyserver before sending them.