Do we still have places where we don't use hasMinCodeVersion function? Do we have to update these?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 19 2023
May 18 2023
Generally looks good, but confused about some of the changes to existing modals...
update breakpoint width
address comments (the comments regarding the typography were adddressed in the design channel where we decided to continue using the current implmentation)
- Pass address in as well. This can be concluded from the message, but processing that seems wasteful since we have the data in SIWEPanel
- Now that we have 3 strings, I'm using an object instead of a list of params
Fix mistakes made during conflict resolution
Return apn.Notifications object in case of encryption failure. Previous apprhac used '...' syntax, and it failed further since the returned object didn't have 'length()' method.
Add newline
Rebase
Rebase
Rebase
Rebase
Rebase
Rebase
Rebase
Rebase
Good find @michal! It seems like simply adding the focus-trap-react NPM package, and then wrapping web/modals/modal.react.js in a <FocusTrap> component would make all of our modals "trap focus". This is probably a good thing to do for all modals, and I think it would solve the problem here.
(I think we should do this in a callback rather than an effect, but I think I mentioned that in another diff where I requested changes)
Address review feedback
Thanks for iterating on the types so much! Some small comments inline; please address before landing
Mostly questions
Added @atul as blocking reviewer for entire substack since he implemented very similar diffs for SignedIdentityKeysBlob.
Rebase
Rebase
Rebase
Rebase
Rebase
Merged with diff https://phab.comm.dev/D7828
Added setting error state, merged with next diff
I think you could merge this one too. Thanks!
Fixed one thing