Realized useFocusEffect doesn't work because there are two other auxiliary screens we use for setting avatars. Reworked it to enable registrationMode while any of the 3 relevant screens are in focus
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 9 2023
Jun 9 2023
address comments
ginsu updated the diff for D8132: [landing] add faq section and request access section to keyserver page.
address comments
Thanks for the annotations
If the avatar upload fails, we'll log the user in anyways, and display an error Alert. The user can then go and change their avatar using the normal flow. I opted for this approach because I figured trying to "undo" the registration would be more complicated, and leaving the registration in a half-complete state would be confusing to the user.
ashoat abandoned D8151: [native] Don't show loading spinner during avatar server call in registration screen.
Following D8163, we no longer do the server call from AvatarSelection, so this diff is no longer necessary
ashoat added inline comments to D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes.
address feedback
Did you try animation-timing-function: ease-in-out; by chance? Think it might look better for this sort of thing
rohan requested review of D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes.
rohan requested review of D8158: [native] Create a ChangeRolesHeaderLeftButton to cancel role changes.
rohan requested review of D8156: [native] Create a new screen that will show the role change information.
Rebase on D8136
rohan updated the diff for D8140: [web] Add functionality on save to actually change a member's role.
Rebase on D8136
rohan updated the diff for D8139: [web] Confirm a user wants to exit if changes are made in the modal.
Rebase on D8136
rohan updated the diff for D8138: [web] Create a modal that allows admins to change a member's role (dropdown menu, actionable buttons).
Rebase on D8136
rohan updated the diff for D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
Rebase on D8136
Expect role to be non-null
ESLint
Harbormaster failed remote builds in B20126: Diff 27576 for D8136: [web] Implement a custom dropdown menu component!
Use invariant
Makes sense. To address replay attacks we should definitely make sure that the signature has a recent timestamp
address feedback
Fix comment
Address feedback
Jun 8 2023
Jun 8 2023
ashoat requested review of D8154: [native] Add cached user selection state into RegistrationContext.
rebase and land
atul updated the diff for D8130: [native] Navigate to newly created community after successful creation.
rebase and land
atul updated the diff for D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
address feedback
rohan updated the diff for D8068: [native] Refactor the members list to support any variety of role labels.
Preemptively remove the check for a parent admin. Tested with the changes
made in D8072
rohan updated the diff for D8067: [web] Refactor the members modal to support any variety of role labels.
Preemptively remove the check for a parent admin. Tested with the changes
made in D8072
ashoat requested review of D8149: [native] Introduce code to call keyserver for registration in new flow.
ashoat requested review of D8150: [native] Make callback param optional in useUploadSelectedMedia avatar hook.
just some clarifying questions inline
rohan added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
ashoat added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
rohan updated the diff for D8067: [web] Refactor the members modal to support any variety of role labels.
Use a variant prop to style the label. Did a quick search prior to
confirm no other instances of Label pass in a custom color or bg
prop, so it would be safe to remove. Also confirmed the existing uses of
Label still look the same
atul updated the diff for D8122: [native] Pass `threadID` of newly created community to `CommunityCreationMembers`.
rebase and land
Rebase
rohan updated the diff for D8140: [web] Add functionality on save to actually change a member's role.
Rebase
rohan updated the diff for D8139: [web] Confirm a user wants to exit if changes are made in the modal.
Rebase
rohan updated the diff for D8138: [web] Create a modal that allows admins to change a member's role (dropdown menu, actionable buttons).
Rebase
rohan updated the diff for D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
Address feedback
Fix errorMessage string literal