Rebase before landing
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 12 2023
Jun 12 2023
Harbormaster failed remote builds in B20179: Diff 27644 for D8114: Provided detailed error messages on olm functions failures in CryptoModule!
marcin updated the diff for D8114: Provided detailed error messages on olm functions failures in CryptoModule.
Harbormaster failed remote builds in B20177: Diff 27642 for D8161: [native] Prevent the only admin role from being changed!
Harbormaster failed remote builds in B20176: Diff 27641 for D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes!
Rebase
rohan updated the diff for D8160: [native] Create a ChangeRolesHeaderRightButton to save role changes.
Address feedback
marcin updated the diff for D8113: Refactor android notifications native and JavaScript code so that JS can register for events using native constants.
Rebase before landing
marcin updated the diff for D8106: Refactor CommIOSNotifications native and JavaScript code so that JavaScript registers to events using getConstants object instead of hardcoded strings.
Rebase before landing
The output validation looks good but you also need to modify the input logic.
kamil added inline comments to D8165: [landing] redesign keyserver company section on keyserver page.
Jun 11 2023
Jun 11 2023
Jun 9 2023
Jun 9 2023
ginsu requested review of D8175: [landing] fix the scroll to top behavior and animation on keyserver page.
looks good thanks for addressing my feedback!
Harbormaster failed remote builds in B20163: Diff 27613 for D8164: [native] Style RegistrationTerms!
Increase comm-swoosh.png resolution
Harbormaster failed remote builds in B20157: Diff 27607 for D8034: [landing] introduce competitor comparison!
update --modal-overlay color value to match a value on web (this was the closet color to the original #010101bf)
bump opacity of not selected logos by 10%
Rebase (fixed the import in the previous diff now)
Remove memberIsAdmin import
atul retitled D8138: [web] Create a modal that allows admins to change a member's role (dropdown menu, actionable buttons) from [web] Create a model that allows admins to change a member's role (dropdown menu, actionable buttons)
purpleLink instead of purpleButton
If you'd prefer I can remove the import in the previous diff instead
In D8136#241242, @atul wrote:Requesting changes for clarification on memberIsAdmin import change.
Also adding @ginsu as blocking to take another look
atul added 1 blocking reviewer(s) for D8136: [web] Implement a custom dropdown menu component: ginsu.
Requesting changes for clarification on memberIsAdmin import change.