Page MenuHomePhabricator
Differential D10807

[lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos`
ClosedPublic
Actions

Authored by atul on Jan 24 2024, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:56 AM
Unknown Object (File)
Thu, Nov 7, 3:51 AM
Unknown Object (File)
Oct 15 2024, 10:06 PM
Unknown Object (File)
Oct 15 2024, 10:06 PM
Unknown Object (File)
Oct 15 2024, 10:06 PM
Unknown Object (File)
Oct 15 2024, 10:06 PM
Unknown Object (File)
Oct 15 2024, 10:06 PM
Unknown Object (File)
Oct 15 2024, 10:06 PM
View All 72 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM74f697975705: [lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos`
Summary

Gets things to a much more readable place again.

Based this on the "before" code from D10235 (https://phab.comm.dev/file/data/m6qxcyyopjoqtkp4vuls/PHID-FILE-uwkm4w7aiiwdont5iviy/lib_selectors_user-selectors.js)

Depends on D10806

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 24 2024, 9:54 PM
Harbormaster completed remote builds in B26142: Diff 36118.Jan 24 2024, 10:14 PM
atul requested review of this revision.Jan 24 2024, 10:14 PM
atul added a child revision: D10810: Remove branching on `.minimallyEncoded` where no longer relevant.Jan 24 2024, 10:19 PM
tomek accepted this revision.Jan 25 2024, 2:53 AM
tomek added inline comments.
lib/selectors/user-selectors.js
71–83

I think we can keep relativeMemberInfo variable

This revision is now accepted and ready to land.Jan 25 2024, 2:53 AM
atul updated this revision to Diff 36327.Jan 29 2024, 3:14 PM

rebase

Harbormaster completed remote builds in B26287: Diff 36327.Jan 29 2024, 3:33 PM
atul added inline comments.Jan 29 2024, 4:53 PM
lib/selectors/user-selectors.js
71–83

True! Will update, thanks for suggestion.

atul updated this revision to Diff 36336.Jan 29 2024, 4:53 PM

address feedback from @tomek

Harbormaster completed remote builds in B26294: Diff 36336.Jan 29 2024, 5:13 PM
Closed by commit rCOMM74f697975705: [lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos` (authored by atul). · Explain WhyJan 29 2024, 5:36 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM74f697975705: [lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos`.

Revision Contents
Changeset List

PathSize
lib/
selectors/
59 lines

Diff 36118

View Options

lib/selectors/user-selectors.js

Loading...