Page MenuHomePhabricator

[keyserver] fetchMediaForThread should return string ids
ClosedPublic

Authored by michal on May 4 2023, 3:40 AM.
Tags
None
Referenced Files
F3370765: D7709.id26064.diff
Tue, Nov 26, 3:55 AM
F3370170: D7709.diff
Tue, Nov 26, 1:14 AM
Unknown Object (File)
Tue, Nov 12, 10:33 AM
Unknown Object (File)
Fri, Nov 8, 7:52 AM
Unknown Object (File)
Sun, Nov 3, 1:19 PM
Unknown Object (File)
Mon, Oct 28, 8:38 AM
Unknown Object (File)
Oct 16 2024, 12:21 AM
Unknown Object (File)
Sep 28 2024, 3:34 PM
Subscribers

Details

Summary

There was a mismatch between flow types and actual object returned by fetchMediaForThread. Instead of returning string ids it returned numbers. This diff changes all the ids to strings before returning them. On the client side the id was only used as keys and was converted to string so there should be no changes in behaviour.

Depends on D7685

Test Plan

Check if media gallery works fine on native and web.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage