Introduce ServerUpdateInfo validator with inner validators and tests.
Depends on D7572
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMM512692827a6a: [lib] Introduce server update info validators
Run yarn jest
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/types/validation.test.js | ||
|---|---|---|
| 736 ↗ | (On Diff #25827) | Can we use constants? |
| lib/types/validation.test.js | ||
|---|---|---|
| 749–751 ↗ | (On Diff #26062) | Why do we have to use _findKey? Can't we just access the property of an object? |
| lib/types/validation.test.js | ||
|---|---|---|
| 736–744 ↗ | (On Diff #26062) | Reminder to use constants |
Comment Actions
Use constants
| lib/types/validation.test.js | ||
|---|---|---|
| 749–751 ↗ | (On Diff #26062) | We want to get the update name from export const updateTypes = Object.freeze({
DELETE_ACCOUNT: 0,
UPDATE_THREAD: 1,
UPDATE_THREAD_READ_STATUS: 2,
DELETE_THREAD: 3,
JOIN_THREAD: 4,
BAD_DEVICE_TOKEN: 5,
UPDATE_ENTRY: 6,
UPDATE_CURRENT_USER: 7,
UPDATE_USER: 8,
});while knowing only the numerical value from validatorByUpdateType. |