[keyserver] Introduce input id conversion
ClosedPublic
Actions

Authored by michal on May 4 2023, 8:21 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM3627da4d3211: [keyserver] Introduce input id conversion

Summary

Modifies the validateInput function to also convert the id schema (conversion is locked behind a flag for now)

Now validateInput asserts the flow type of the input after validation which allows us to change any to mixed in responder input and remove the cast
In two places in user-responders validateInput was called with null validator and input. To simplify the validateInput function generic typing I've replaced them with direct calls to verifyClientSupported, which is what was happening anyways

Depends on D7713

Test Plan

Test web app and ios emulator and check for any server errors.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.May 4 2023, 8:21 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 4 2023, 8:21 AM

Harbormaster completed remote builds in B19040: Diff 26072.May 4 2023, 8:40 AM

michal requested review of this revision.May 4 2023, 8:40 AM

tomek accepted this revision.May 5 2023, 12:55 AM

tomek added inline comments.

lib/types/entry-types.js
99	Why are we adding these?

This revision is now accepted and ready to land.May 5 2023, 12:55 AM

Sorry should have mentioned this. There are added because flow types and validators are not in sync. These properties were removed at one point and aren't used. They still exist in the validators so we can support older clients.
Now that tShape<T> is checking if properties count and names match between the flow type and the validator we get an error. Adding empty makes them match, while still blocks the rest of the code from using these values, because they are empty.

michal added a child revision: D7749: [keyserver] Validate websocket output.May 9 2023, 1:37 AM

Closed by commit rCOMM3627da4d3211: [keyserver] Introduce input id conversion (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 15 2023, 5:00 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM3627da4d3211: [keyserver] Introduce input id conversion.