Page MenuHomePhabricator
Differential D7786

[web] Validate website responder
ClosedPublic
Actions

Authored by michal on May 10 2023, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 3:28 PM
Unknown Object (File)
Mon, Mar 31, 5:11 PM
Unknown Object (File)
Thu, Mar 27, 3:27 AM
Unknown Object (File)
Wed, Mar 26, 11:48 AM
Unknown Object (File)
Tue, Mar 25, 11:45 AM
Unknown Object (File)
Tue, Mar 25, 11:45 AM
Unknown Object (File)
Tue, Mar 25, 11:45 AM
Unknown Object (File)
Tue, Mar 25, 11:45 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
kamil
tomek
Commits
rCOMM43cec14ab91e: [web] Validate website responder
Summary

Validate website responder by adding an intial redux state validator. It's not a full (Web)AppState validator because we don't need it for this purpose.

Depends on D7785

Test Plan

Load the web app and check if there were any errors. Repeat with a few other accounts.

Diff Detail

Repository
rCOMM Comm
Branch
michal/id-schema
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.May 10 2023, 10:20 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 10 2023, 10:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 10 2023, 10:37 AM
Harbormaster failed remote builds in B19258: Diff 26360!
michal edited parent revisions, added: D7788: [lib] Move update type enum into a separate file; removed: D7785: [lib] Move socket errors to errors.js.May 11 2023, 2:17 AM
michal updated this revision to Diff 26364.May 11 2023, 2:18 AM
michal added a parent revision: D7785: [lib] Move socket errors to errors.js.

Retrigger CI

Harbormaster completed remote builds in B19262: Diff 26364.May 11 2023, 2:35 AM
michal requested review of this revision.May 11 2023, 2:35 AM
tomek accepted this revision.May 15 2023, 2:19 AM
This revision is now accepted and ready to land.May 15 2023, 2:19 AM
michal added a child revision: D7805: [keyserver] Use platform details in validateOutput.May 15 2023, 3:48 AM
Closed by commit rCOMM43cec14ab91e: [web] Validate website responder (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 15 2023, 5:00 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM43cec14ab91e: [web] Validate website responder.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
103 lines
lib/
types/
5 lines
22 lines
33 lines
utils/
37 lines
web/
types/
27 lines

Diff 26364

View Options

keyserver/src/responders/website-responders.js

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines
} }
// Get messages from devices // Get messages from devices
message GetRequest { message GetRequest {
string sessionID = 1; string sessionID = 1;
} }
message GetResponse { message GetResponseMessage {
string fromDeviceID = 1; string fromDeviceID = 1;
bytes payload = 2; bytes payload = 2;
repeated string blobHashes = 3; repeated string blobHashes = 3;
} }
message GetResponse {
oneof data {
GetResponseMessage responseMessage = 1;
google.protobuf.Empty ping = 2;
}
}
// Common messages structures for the MessagesStream // Common messages structures for the MessagesStream
message ProcessedMessages { message ProcessedMessages {
repeated string messageID = 1; repeated string messageID = 1;
} }
// The messages from the Client to the Tunnelbroker // The messages from the Client to the Tunnelbroker
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

lib/types/entry-types.js

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines
} }
// Get messages from devices // Get messages from devices
message GetRequest { message GetRequest {
string sessionID = 1; string sessionID = 1;
} }
message GetResponse { message GetResponseMessage {
string fromDeviceID = 1; string fromDeviceID = 1;
bytes payload = 2; bytes payload = 2;
repeated string blobHashes = 3; repeated string blobHashes = 3;
} }
message GetResponse {
oneof data {
GetResponseMessage responseMessage = 1;
google.protobuf.Empty ping = 2;
}
}
// Common messages structures for the MessagesStream // Common messages structures for the MessagesStream
message ProcessedMessages { message ProcessedMessages {
repeated string messageID = 1; repeated string messageID = 1;
} }
// The messages from the Client to the Tunnelbroker // The messages from the Client to the Tunnelbroker
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

lib/types/message-types.js

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines
} }
// Get messages from devices // Get messages from devices
message GetRequest { message GetRequest {
string sessionID = 1; string sessionID = 1;
} }
message GetResponse { message GetResponseMessage {
string fromDeviceID = 1; string fromDeviceID = 1;
bytes payload = 2; bytes payload = 2;
repeated string blobHashes = 3; repeated string blobHashes = 3;
} }
message GetResponse {
oneof data {
GetResponseMessage responseMessage = 1;
google.protobuf.Empty ping = 2;
}
}
// Common messages structures for the MessagesStream // Common messages structures for the MessagesStream
message ProcessedMessages { message ProcessedMessages {
repeated string messageID = 1; repeated string messageID = 1;
} }
// The messages from the Client to the Tunnelbroker // The messages from the Client to the Tunnelbroker
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

lib/types/thread-types.js

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines
} }
// Get messages from devices // Get messages from devices
message GetRequest { message GetRequest {
string sessionID = 1; string sessionID = 1;
} }
message GetResponse { message GetResponseMessage {
string fromDeviceID = 1; string fromDeviceID = 1;
bytes payload = 2; bytes payload = 2;
repeated string blobHashes = 3; repeated string blobHashes = 3;
} }
message GetResponse {
oneof data {
GetResponseMessage responseMessage = 1;
google.protobuf.Empty ping = 2;
}
}
// Common messages structures for the MessagesStream // Common messages structures for the MessagesStream
message ProcessedMessages { message ProcessedMessages {
repeated string messageID = 1; repeated string messageID = 1;
} }
// The messages from the Client to the Tunnelbroker // The messages from the Client to the Tunnelbroker
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

lib/utils/entity-text.js

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines
} }
// Get messages from devices // Get messages from devices
message GetRequest { message GetRequest {
string sessionID = 1; string sessionID = 1;
} }
message GetResponse { message GetResponseMessage {
string fromDeviceID = 1; string fromDeviceID = 1;
bytes payload = 2; bytes payload = 2;
repeated string blobHashes = 3; repeated string blobHashes = 3;
} }
message GetResponse {
oneof data {
GetResponseMessage responseMessage = 1;
google.protobuf.Empty ping = 2;
}
}
// Common messages structures for the MessagesStream // Common messages structures for the MessagesStream
message ProcessedMessages { message ProcessedMessages {
repeated string messageID = 1; repeated string messageID = 1;
} }
// The messages from the Client to the Tunnelbroker // The messages from the Client to the Tunnelbroker
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines
View Options

web/types/nav-types.js

Loading...