Page MenuHomePhabricator
Differential D7921

[lib] refactor types to allow returning report store operations
ClosedPublic
Actions

Authored by kamil on May 22 2023, 10:54 AM.
Tags
None
Referenced Files
F3515434: D7921.id27132.diff
Sun, Dec 22, 8:54 AM
F3515303: D7921.id26805.diff
Sun, Dec 22, 8:23 AM
F3514068: D7921.diff
Sun, Dec 22, 3:23 AM
Unknown Object (File)
Wed, Dec 18, 1:05 AM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
View All 97 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM409049567986: [lib] refactor types to allow returning report store operations
Summary

This adds only types, operations will be generated later in stack.

Depends on D7920

Test Plan

Flow / tests

Diff Detail

Repository
rCOMM Comm
Branch
reports-native
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 22 2023, 10:54 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 10:54 AM
kamil added a child revision: D7922: [lib] add operation for removing all reports on login/logout.May 22 2023, 10:57 AM
Harbormaster failed remote builds in B19610: Diff 26805!May 22 2023, 11:07 AM
kamil updated this revision to Diff 26836.May 23 2023, 1:08 AM

rebase

Harbormaster completed remote builds in B19628: Diff 26836.May 23 2023, 1:26 AM
kamil published this revision for review.May 23 2023, 1:51 AM
tomek accepted this revision.May 24 2023, 2:09 AM
This revision is now accepted and ready to land.May 24 2023, 2:09 AM
kamil updated this revision to Diff 27132.May 29 2023, 3:43 AM

rebase

Harbormaster completed remote builds in B19813: Diff 27132.May 29 2023, 4:00 AM
Closed by commit rCOMM409049567986: [lib] refactor types to allow returning report store operations (authored by kamil). · Explain WhyMay 29 2023, 4:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM409049567986: [lib] refactor types to allow returning report store operations.

Revision Contents
Changeset List

PathSize
lib/
reducers/
13 lines
58 lines
61 lines
types/
2 lines

Diff 26805

View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/reducers/report-store-reducer.js

Loading...
View Options

lib/reducers/report-store-reducer.test.js

Loading...
View Options

lib/types/store-ops-types.js

Loading...