Page MenuHomePhabricator
Differential D7922

[lib] add operation for removing all reports on login/logout
ClosedPublic
Actions

Authored by kamil on May 22 2023, 10:57 AM.
Tags
None
Referenced Files
F3514912: D7922.diff
Sun, Dec 22, 6:56 AM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:58 PM
Unknown Object (File)
Sun, Dec 15, 11:57 PM
Unknown Object (File)
Sun, Dec 15, 11:49 PM
Unknown Object (File)
Thu, Dec 5, 12:47 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM6cb19536ba78: [lib] add operation for removing all reports on login/logout
Summary

In this case this change is very simple - so generating only db operations without calling processReportStoreOperations

Depends on D7921

Test Plan
  1. Logout/login user (create some reports previously)
  2. tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 22 2023, 10:57 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 10:57 AM
kamil added a child revision: D7923: [lib] refactor updating enabled reports for using operations.May 22 2023, 11:04 AM
Harbormaster failed remote builds in B19611: Diff 26806!May 22 2023, 11:10 AM
kamil updated this revision to Diff 26837.May 23 2023, 1:17 AM

rebase

Harbormaster completed remote builds in B19629: Diff 26837.May 23 2023, 1:36 AM
kamil published this revision for review.May 23 2023, 1:52 AM
tomek accepted this revision.May 24 2023, 2:10 AM
tomek added inline comments.
lib/reducers/report-store-reducer.js
83

Are you sure we should remove these on login?

This revision is now accepted and ready to land.May 24 2023, 2:10 AM
kamil updated this revision to Diff 27133.May 29 2023, 3:44 AM

rebase

lib/reducers/report-store-reducer.js
83

yes, operations should maintain previous logic, and on the login queuedReports was returned as an empty array

Harbormaster completed remote builds in B19814: Diff 27133.May 29 2023, 4:02 AM
Closed by commit rCOMM6cb19536ba78: [lib] add operation for removing all reports on login/logout (authored by kamil). · Explain WhyMay 29 2023, 4:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM6cb19536ba78: [lib] add operation for removing all reports on login/logout.

Revision Contents
Changeset List

PathSize
lib/
reducers/
4 lines

Diff 26837

View Options

lib/reducers/report-store-reducer.js

Loading...