Page MenuHomePhabricator

[lib] add operation for removing all reports on login/logout
ClosedPublic

Authored by kamil on May 22 2023, 10:57 AM.
Tags
None
Referenced Files
F6235114: D7922.diff
Thu, Apr 24, 2:04 PM
Unknown Object (File)
Tue, Apr 22, 3:52 AM
Unknown Object (File)
Sat, Apr 19, 7:39 AM
Unknown Object (File)
Sat, Apr 19, 4:05 AM
Unknown Object (File)
Fri, Apr 18, 12:14 PM
Unknown Object (File)
Fri, Apr 18, 4:31 AM
Unknown Object (File)
Thu, Apr 17, 11:00 PM
Unknown Object (File)
Thu, Apr 17, 7:14 AM
Subscribers

Details

Summary

In this case this change is very simple - so generating only db operations without calling processReportStoreOperations

Depends on D7921

Test Plan
  1. Logout/login user (create some reports previously)
  2. tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 23 2023, 1:52 AM
tomek added inline comments.
lib/reducers/report-store-reducer.js
83

Are you sure we should remove these on login?

This revision is now accepted and ready to land.May 24 2023, 2:10 AM

rebase

lib/reducers/report-store-reducer.js
83

yes, operations should maintain previous logic, and on the login queuedReports was returned as an empty array