Page MenuHomePhabricator
Differential D7937

[native] start processing report store operations on database
ClosedPublic
Actions

Authored by kamil on May 23 2023, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 10:45 AM
Unknown Object (File)
Sun, Oct 27, 8:45 PM
Unknown Object (File)
Sep 29 2024, 4:55 AM
Unknown Object (File)
Sep 29 2024, 1:18 AM
Unknown Object (File)
Sep 29 2024, 1:18 AM
Unknown Object (File)
Sep 29 2024, 1:18 AM
Unknown Object (File)
Sep 29 2024, 1:17 AM
Unknown Object (File)
Sep 29 2024, 1:10 AM
View All 96 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM3294c18298d0: [native] start processing report store operations on database
Summary

Enable running ops on SQLite.

Depends on D7936, D7933

Test Plan

Create some ops in reducer and check if they're properly processed on SQLite

Diff Detail

Repository
rCOMM Comm
Branch
reports-native
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 23 2023, 3:28 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 3:28 AM
kamil added a child revision: D7938: [native] fetch reports from SQLite and dispatch to store.May 23 2023, 3:44 AM
Harbormaster completed remote builds in B19649: Diff 26857.May 23 2023, 3:46 AM
kamil published this revision for review.May 23 2023, 4:55 PM
tomek accepted this revision.May 24 2023, 3:11 AM
tomek added inline comments.
lib/ops/report-store-ops.js
90

Should we e.g. throw when an unsupported operation appears?

This revision is now accepted and ready to land.May 24 2023, 3:11 AM
kamil edited parent revisions, added: D7977: [native] migrate reports to SQLite; removed: D7936: [CommCoreModule] implement getting report store from database.May 25 2023, 7:57 AM
kamil updated this revision to Diff 27297.May 31 2023, 8:28 AM
kamil added a parent revision: D7936: [CommCoreModule] implement getting report store from database.

rebase before landing

lib/ops/report-store-ops.js
90

In other cases we throw from C++ level, I'll follow current approach

kamil removed a parent revision: D7936: [CommCoreModule] implement getting report store from database.May 31 2023, 8:29 AM
Harbormaster completed remote builds in B19922: Diff 27297.May 31 2023, 8:48 AM
Closed by commit rCOMM3294c18298d0: [native] start processing report store operations on database (authored by kamil). · Explain WhyMay 31 2023, 9:24 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM3294c18298d0: [native] start processing report store operations on database.

Revision Contents
Changeset List

PathSize
lib/
ops/
21 lines
native/
redux/
3 lines
13 lines

Diff 26857

View Options

lib/ops/report-store-ops.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

native/redux/redux-utils.js

Loading...