Page MenuHomePhabricator
Differential D7910

[lib] extract local id field before sending report
ClosedPublic
Actions

Authored by kamil on May 22 2023, 6:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:32 AM
Unknown Object (File)
Tue, Mar 18, 2:31 AM
Unknown Object (File)
Tue, Mar 18, 2:24 AM
Unknown Object (File)
Mon, Mar 17, 5:38 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMM2a202a6053d1: [lib] extract local id field before sending report
Summary

This field is needed only on client, also by this we're making sure that request validation on server will not fail.

Depends on D7909

Test Plan

Attach id field to report and try sending this and see if it's properly validated on keyserver.

Diff Detail

Repository
rCOMM Comm
Branch
land-rs
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 22 2023, 6:37 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 6:37 AM
kamil added a child revision: D7912: [lib] add local id field to existing reports.May 22 2023, 6:41 AM
Harbormaster completed remote builds in B19592: Diff 26777.May 22 2023, 6:54 AM
kamil published this revision for review.May 23 2023, 1:36 AM
tomek accepted this revision.May 23 2023, 3:12 AM
tomek added inline comments.
lib/actions/report-actions.js
42–46 ↗(On Diff #26777)

Using term raw might be confusing, as it has a special meaning in our codebase. How about clientReport vs serverReport?

This revision is now accepted and ready to land.May 23 2023, 3:12 AM
kamil updated this revision to Diff 27119.May 29 2023, 1:46 AM

rename variable

lib/actions/report-actions.js
42–46 ↗(On Diff #26777)

fair point

kamil updated this revision to Diff 27120.May 29 2023, 1:54 AM

move code directly to migration

Harbormaster completed remote builds in B19805: Diff 27119.May 29 2023, 2:03 AM
Harbormaster completed remote builds in B19806: Diff 27120.May 29 2023, 2:12 AM
kamil updated this revision to Diff 27121.May 29 2023, 2:15 AM

fix committed code

Harbormaster completed remote builds in B19807: Diff 27121.May 29 2023, 2:34 AM
Closed by commit rCOMM2a202a6053d1: [lib] extract local id field before sending report (authored by kamil). · Explain WhyMay 29 2023, 3:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2a202a6053d1: [lib] extract local id field before sending report.
kamil mentioned this in D9893: [Flow] improve report related types.Nov 15 2023, 4:07 AM
kamil mentioned this in rCOMMb9ee04633890: [Flow] improve report related types.Nov 15 2023, 5:21 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
9 lines

Diff 27119

View Options

lib/actions/report-actions.js

Show All 20 Linesimport {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { registerConfig } from 'lib/utils/config.js'; import { registerConfig } from 'lib/utils/config.js';
import { infoFromURL } from 'lib/utils/url-utils.js'; import { infoFromURL } from 'lib/utils/url-utils.js';
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 LinesregisterConfig({
resolveInvalidatedCookie: null, resolveInvalidatedCookie: null,
setSessionIDOnRequest: true, setSessionIDOnRequest: true,
// Never reset the calendar range // Never reset the calendar range
calendarRangeInactivityLimit: null, calendarRangeInactivityLimit: null,
platformDetails: { platformDetails: {
platform: electron?.platform ?? 'web', platform: electron?.platform ?? 'web',
codeVersion: 42, codeVersion: 42,
stateVersion: persistConfig.version, stateVersion: persistConfig.version,
majorDesktopVersion: electron?.version
? extractMajorDesktopVersion(electron?.version)
: null,
michalUnsubmitted
Not Done
Inline Actions

Related to my other comment, but I think it would be better to just not pass anything on web instead of null. majorDesktopVersion doesn't apply to the web in the same way as it doesn't apply to native.

michal: Related to my other comment, but I think it would be better to just not pass anything on web…
}, },
}); });
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines