Page MenuHomePhabricator
Differential D7983

[web-db] implement SQL queries for report store
ClosedPublic
Actions

Authored by kamil on May 25 2023, 10:28 AM.
Tags
None
Referenced Files
F6244665: D7983.id27309.diff
Fri, Apr 25, 1:48 AM
Unknown Object (File)
Thu, Apr 24, 9:10 PM
Unknown Object (File)
Thu, Apr 24, 9:06 PM
Unknown Object (File)
Thu, Apr 24, 4:02 AM
Unknown Object (File)
Thu, Apr 24, 3:54 AM
Unknown Object (File)
Fri, Apr 18, 2:59 PM
Unknown Object (File)
Fri, Apr 18, 2:38 PM
Unknown Object (File)
Fri, Apr 18, 10:16 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMMc34f13c3fa14: [web-db] implement SQL queries for report store
Summary

Mapping native structure and logic

Depends on D7982

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 25 2023, 10:28 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 25 2023, 10:28 AM
kamil added a child revision: D7984: [web-db] add report table on web.May 25 2023, 10:29 AM
Harbormaster completed remote builds in B19776: Diff 27068.May 25 2023, 10:46 AM
kamil published this revision for review.May 25 2023, 1:46 PM
michal accepted this revision.May 30 2023, 8:26 AM
michal added inline comments.
web/database/queries/report-queries.test.js
25 ↗(On Diff #27068)

Shouldn't we setupSQLiteDB in the beforeAll?

76 ↗(On Diff #27068)

I think you missed the name

This revision is now accepted and ready to land.May 30 2023, 8:26 AM
kamil updated this revision to Diff 27309.May 31 2023, 9:49 AM

add missing name

web/database/queries/report-queries.test.js
25 ↗(On Diff #27068)

because tests are concentrated on the reports table (created via createReportTable()) it doesn't really make any difference, I'll remove this

76 ↗(On Diff #27068)

oversight, fixing

Harbormaster completed remote builds in B19929: Diff 27309.May 31 2023, 10:09 AM
Closed by commit rCOMMc34f13c3fa14: [web-db] implement SQL queries for report store (authored by kamil). · Explain WhyMay 31 2023, 10:12 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc34f13c3fa14: [web-db] implement SQL queries for report store.

Revision Contents
Changeset List

PathSize
web/
database/
queries/
72 lines
86 lines

Diff 27309

View Options

web/database/queries/report-queries.js

  • This file was added.
fn main() -> Result<(), Box<dyn std::error::Error>> {
karolUnsubmitted
Not Done
Inline Actions

so Box<dyn std::error::Error> is automatically returned via ? used in the next line?

karol: so `Box<dyn std::error::Error>` is automatically returned via `?` used in the next line?
varunAuthorUnsubmitted
Done
Inline Actions

The following line is doing a lot. compile_protos returns a Result enum, which has two variants, Ok(r) and Err(e). If compilation is successful, the function returns Ok(r) and the ? unwraps the enum. If it fails, the function returns Err(e), and the ? calls into (a trait method) to convert the error to Box<dyn std::error::Error>. The reason we Box the error here is to preserve the original error.

varun: The following line is doing a lot. `compile_protos` returns a `Result` enum, which has two…
karolUnsubmitted
Not Done
Inline Actions

I think I get it, thanks.

karol: I think I get it, thanks.
tonic_build::compile_protos("proto/identity.proto")?;
Ok(())
}
View Options

web/database/queries/report-queries.test.js

  • This file was added.
fn main() -> Result<(), Box<dyn std::error::Error>> {
karolUnsubmitted
Not Done
Inline Actions

so Box<dyn std::error::Error> is automatically returned via ? used in the next line?

karol: so `Box<dyn std::error::Error>` is automatically returned via `?` used in the next line?
varunAuthorUnsubmitted
Done
Inline Actions

The following line is doing a lot. compile_protos returns a Result enum, which has two variants, Ok(r) and Err(e). If compilation is successful, the function returns Ok(r) and the ? unwraps the enum. If it fails, the function returns Err(e), and the ? calls into (a trait method) to convert the error to Box<dyn std::error::Error>. The reason we Box the error here is to preserve the original error.

varun: The following line is doing a lot. `compile_protos` returns a `Result` enum, which has two…
karolUnsubmitted
Not Done
Inline Actions

I think I get it, thanks.

karol: I think I get it, thanks.
tonic_build::compile_protos("proto/identity.proto")?;
Ok(())
}