Page MenuHomePhabricator
Differential D10807

[lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos`
ClosedPublic
Actions

Authored by atul on Jan 24 2024, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 3:04 PM
Unknown Object (File)
Wed, Mar 26, 11:14 AM
Unknown Object (File)
Tue, Mar 25, 9:50 AM
Unknown Object (File)
Feb 21 2025, 7:40 PM
Unknown Object (File)
Feb 21 2025, 7:40 PM
Unknown Object (File)
Feb 21 2025, 7:40 PM
Unknown Object (File)
Feb 21 2025, 7:40 PM
Unknown Object (File)
Feb 21 2025, 7:40 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM74f697975705: [lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos`
Summary

Gets things to a much more readable place again.

Based this on the "before" code from D10235 (https://phab.comm.dev/file/data/m6qxcyyopjoqtkp4vuls/PHID-FILE-uwkm4w7aiiwdont5iviy/lib_selectors_user-selectors.js)

Depends on D10806

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D10807 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 24 2024, 9:54 PM
Harbormaster completed remote builds in B26142: Diff 36118.Jan 24 2024, 10:14 PM
atul requested review of this revision.Jan 24 2024, 10:14 PM
atul added a child revision: D10810: Remove branching on `.minimallyEncoded` where no longer relevant.Jan 24 2024, 10:19 PM
tomek accepted this revision.Jan 25 2024, 2:53 AM
tomek added inline comments.
lib/selectors/user-selectors.js
71–83 ↗(On Diff #36118)

I think we can keep relativeMemberInfo variable

This revision is now accepted and ready to land.Jan 25 2024, 2:53 AM
atul updated this revision to Diff 36327.Jan 29 2024, 3:14 PM

rebase

Harbormaster completed remote builds in B26287: Diff 36327.Jan 29 2024, 3:33 PM
atul added inline comments.Jan 29 2024, 4:53 PM
lib/selectors/user-selectors.js
71–83 ↗(On Diff #36118)

True! Will update, thanks for suggestion.

atul updated this revision to Diff 36336.Jan 29 2024, 4:53 PM

address feedback from @tomek

Harbormaster completed remote builds in B26294: Diff 36336.Jan 29 2024, 5:13 PM
Closed by commit rCOMM74f697975705: [lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos` (authored by atul). · Explain WhyJan 29 2024, 5:36 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM74f697975705: [lib] Remove support for `LegacyRawThreadInfo` in `getRelativeMemberInfos`.

Revision Contents
Changeset List

PathSize
lib/
selectors/
76 lines

Diff 36336

View Options

lib/selectors/user-selectors.js

{ {
"name": "lib", "name": "lib",
"version": "0.0.1", "version": "0.0.1",
"type": "module", "type": "module",
"private": true, "private": true,
"license": "BSD-3-Clause", "license": "BSD-3-Clause",
"scripts": { "scripts": {
"clean": "rm -rf node_modules/", "clean": "rm -rf node_modules/",
"test": "jest" "test": "jest"
}, },
"devDependencies": { "devDependencies": {
"buffer": "^6.0.3",
"@babel/core": "^7.13.14", "@babel/core": "^7.13.14",
"@babel/plugin-proposal-class-properties": "^7.13.0", "@babel/plugin-proposal-class-properties": "^7.13.0",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.13.8", "@babel/plugin-proposal-nullish-coalescing-operator": "^7.13.8",
"@babel/plugin-proposal-object-rest-spread": "^7.13.8", "@babel/plugin-proposal-object-rest-spread": "^7.13.8",
"@babel/plugin-proposal-optional-chaining": "^7.13.12", "@babel/plugin-proposal-optional-chaining": "^7.13.12",
"@babel/plugin-transform-runtime": "^7.13.10", "@babel/plugin-transform-runtime": "^7.13.10",
"@babel/preset-env": "^7.13.12", "@babel/preset-env": "^7.13.12",
"@babel/preset-flow": "^7.13.13", "@babel/preset-flow": "^7.13.13",
"@babel/preset-react": "^7.13.13", "@babel/preset-react": "^7.13.13",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.10", "@pmmmwh/react-refresh-webpack-plugin": "^0.5.10",
"babel-jest": "^26.6.3", "babel-jest": "^26.6.3",
"babel-loader": "^9.1.2", "babel-loader": "^9.1.2",
"buffer": "^6.0.3",
"clean-webpack-plugin": "^4.0.0", "clean-webpack-plugin": "^4.0.0",
"css-loader": "^6.7.3", "css-loader": "^6.7.3",
"css-minimizer-webpack-plugin": "^4.2.2", "css-minimizer-webpack-plugin": "^4.2.2",
"flow-bin": "^0.182.0", "flow-bin": "^0.182.0",
"flow-typed": "^3.2.1", "flow-typed": "^3.2.1",
"mini-css-extract-plugin": "^2.7.2", "mini-css-extract-plugin": "^2.7.2",
"react-refresh": "^0.14.0", "react-refresh": "^0.14.0",
"style-loader": "^3.3.1", "style-loader": "^3.3.1",
Show All 14 Lines "dependencies": {
"lodash": "^4.17.21", "lodash": "^4.17.21",
"react": "18.1.0", "react": "18.1.0",
"react-icomoon": "^2.5.7", "react-icomoon": "^2.5.7",
"react-redux": "^7.1.1", "react-redux": "^7.1.1",
"redux-persist": "^6.0.0", "redux-persist": "^6.0.0",
"reselect": "^4.0.0", "reselect": "^4.0.0",
"reselect-map": "^1.0.5", "reselect-map": "^1.0.5",
"simple-markdown": "^0.7.2", "simple-markdown": "^0.7.2",
"siwe": "^1.1.6",
"string-hash": "^1.1.3", "string-hash": "^1.1.3",
"tcomb": "^3.2.29", "tcomb": "^3.2.29",
"siwe": "^1.1.6",
"tinycolor2": "^1.4.1", "tinycolor2": "^1.4.1",
"tokenize-text": "^1.1.3", "tokenize-text": "^1.1.3",
"util-inspect": "^0.1.8", "util-inspect": "^0.1.8",
"utils-copy-error": "^1.0.1", "utils-copy-error": "^1.0.1",
"uuid": "^3.4.0",
"wagmi": "^0.12.16" "wagmi": "^0.12.16"
}, },
"jest": { "jest": {
"transform": { "transform": {
"\\.js$": "babel-jest" "\\.js$": "babel-jest"
}, },
"transformIgnorePatterns": [ "transformIgnorePatterns": [
"/node_modules/(?!@babel/runtime)" "/node_modules/(?!@babel/runtime)"
] ]
} }
} }