remove delete from chat-thread-list.css

In D3409#92233, @ashoat wrote:

In particular, I'm worried that I don't see you mention anything about checking the code for these CSS classes. You should be running git grep for each of these class names to make sure we're not still using them somewhere that uses chat-thread-list.css. This is an example of what I was talking about in our 1:1 – don't just do simple testing, also rely on thorough analyses of the codebase to make sure your changes don't have side effects. (You didn't detail any "simple testing" in your test plan either, though...)

Didn't mean to resign, just wanted to leave comments.

I don't have that much context here. My only suggestion would be to make this diff smaller. @ashoat -- When moving code, do you suggest we break each function into its own diff? Rather than moving multiple functions? Or is that a bit of overkill? I personally find it harder to review with multiple functions.

I didn't do a full review. But, these were a couple of things I thought were worth looking at before landing.

clean up

address diff comments

In D3398#91898, @atul wrote:

Minor nit but if I remember correctly (cc @ashoat), the team generally avoids multi-line comments with /* and */ and instead prefers starting each line with //

Not sure of the reasoning or context, but I vaguely remember something like that being a "rule"

update with diff review

In D3405#92013, @palys-swm wrote:

I hard-coded a color but will remove it in future diffs, along with other unneeded styles. I just didn't want to break existing functionality.

If removing the div requires adding these colors, then adding them was ok, but I think we should still use variables instead of hardcoded values.

I also think this color transition is a bit aggressive. I assume @ashoat is okay with the user experience.

In D3391#91577, @atul wrote:

btw can we use the icons that already exist in lib/shared/swmansion-icon-config.json?

removing myself from review here. I wasn't a part of any of the initial review. Feel free to add me if you think I should still be a reviewer.

Sorry everyone, I should have waited for the build to finish after rebasing. This won't happen again.

rebase

before and after look the same to me.

I don't knot why having display: inline-block on icons is an issue... it sounds reasonable, and if we want a different behavior, we should wrap it in a tag with different display. Regarding the icon pack, I would need to ask some people. This project on github isn't hosted on official Software Mansion account - not sure what's the reason for that.

remove line

update svg in buttons site wide to align correctly