Page MenuHomePhorge
Feed Search

Jul 25 2023

tomek added a comment to D8527: [keyserver] Handle offensive words in invite links.

Can you provide some more context on the selection of this package? I noticed it hasn't been updated in 3 years and has some unaddressed GitHub issues, but I'm guessing your research showed that it's the best option.

Jul 25 2023, 10:58 AM
tomek accepted D8604: [CommCoreModule] implement C++ DraftStore.
Jul 25 2023, 10:17 AM
tomek accepted D8603: [CommCoreModule] introduce BaseDataStore template class.
Jul 25 2023, 10:10 AM
tomek accepted D8586: [native] Use currently selected theme for alerts..

Looks great!

Jul 25 2023, 9:30 AM

Jul 24 2023

tomek added a comment to D8494: [keyserver][web][native] Handle link creation / update errors.

Let's actually capitalize the first letter. We should probably do the same in log-in form, but to be fair it's a little different visually... the errors there are shorter, and are not given their own full-width container (if I recall correctly)

Jul 24 2023, 2:30 PM
tomek updated the diff for D8494: [keyserver][web][native] Handle link creation / update errors.

Capitalize the first letters of error messages

Jul 24 2023, 2:29 PM
tomek accepted D8552: [web] add `std::vector` (C++) <-> `Array` (JS) marshalling.

Looks ok, but I don't know C++ enough to be sure

Jul 24 2023, 1:30 PM
tomek accepted D8548: [web] Add web Logger implementation.
Jul 24 2023, 1:06 PM
tomek requested changes to D8586: [native] Use currently selected theme for alerts..

Is there a diff where we start using this instead of the default Alert?

Jul 24 2023, 12:54 PM

Jul 18 2023

tomek requested review of D8527: [keyserver] Handle offensive words in invite links.
Jul 18 2023, 11:32 AM

Jul 17 2023

tomek accepted D8519: [lib] Update genesis constant id to new schema.
Jul 17 2023, 1:03 PM
tomek accepted D8495: [lib] Don't send activity updates for pending threads.
Jul 17 2023, 12:08 PM
tomek accepted D8492: [keyserver] Always fetch the latest message for threads.
Jul 17 2023, 11:54 AM
tomek accepted D8487: [native] replace `folly::Optional` with `std::optional`.
Jul 17 2023, 11:43 AM
tomek accepted D8514: [keyserver] Filter fetchThreadInfos queries to only look at viewer's threads.
Jul 17 2023, 11:40 AM
tomek accepted D8513: [keyserver] Replace raw SQL predicate to fetchThreadInfos with filter object.
Jul 17 2023, 11:07 AM
tomek accepted D8512: [keyserver] Introduce index to optimize new fetchThreadInfos query.
Jul 17 2023, 10:57 AM
tomek accepted D8499: [keyserver] Improve fetchKnownUserInfos query performance.
Jul 17 2023, 10:49 AM

Jul 13 2023

tomek requested review of D8494: [keyserver][web][native] Handle link creation / update errors.
Jul 13 2023, 1:15 PM
tomek closed D8485: [native] Handle long invite links.
Jul 13 2023, 9:03 AM
tomek closed D8486: [keyserver] Remove target blank.
Jul 13 2023, 9:03 AM
tomek committed rCOMM041958e44a76: [keyserver] Remove target blank.
Jul 13 2023, 9:03 AM
tomek committed rCOMMd14c68917875: [native] Handle long invite links.
Jul 13 2023, 9:03 AM
tomek closed D8484: [web] Keep modal width constant.
Jul 13 2023, 9:03 AM
tomek committed rCOMM94248127be59: [web] Keep modal width constant.
Jul 13 2023, 9:03 AM
tomek accepted D8355: [lib] Generate converters from validators.

Thanks!

Jul 13 2023, 8:25 AM
tomek accepted D8271: [native] Unblock scrolling when continuing editing.
Jul 13 2023, 8:18 AM

Jul 12 2023

tomek added inline comments to D8271: [native] Unblock scrolling when continuing editing.
Jul 12 2023, 11:27 AM
tomek requested changes to D8355: [lib] Generate converters from validators.

There's actually another problem: the generated functions can't be typed with our types because they will get out of sync. What I mean by that is that these functions operate on data that is stored in sqlite/redux at this point in time. If in the future someone modifies e.g. RawMessageInfo then this new type could conflict with the generated functions' body and make a flow error.

That makes sense, and we're assuming state type in our migrations, so it seems consistent.

Jul 12 2023, 10:07 AM
tomek requested review of D8486: [keyserver] Remove target blank.
Jul 12 2023, 9:52 AM
tomek requested review of D8485: [native] Handle long invite links.
Jul 12 2023, 9:30 AM
tomek requested review of D8484: [web] Keep modal width constant.
Jul 12 2023, 9:17 AM

Jul 11 2023

tomek closed D8465: [keyserver] Use blank target in invite link.
Jul 11 2023, 2:27 PM
tomek committed rCOMM4eabcb008b16: [keyserver] Use blank target in invite link.
Jul 11 2023, 2:27 PM
tomek added inline comments to D8271: [native] Unblock scrolling when continuing editing.
Jul 11 2023, 10:59 AM

Jul 10 2023

tomek requested review of D8465: [keyserver] Use blank target in invite link.
Jul 10 2023, 2:30 PM
tomek added inline comments to D8419: [web] Introduce disable link modal.
Jul 10 2023, 2:26 PM
tomek added inline comments to D8419: [web] Introduce disable link modal.
Jul 10 2023, 2:24 PM
tomek closed D8462: [native] Specify https as an application query scheme.
Jul 10 2023, 12:49 PM
tomek committed rCOMM84958a80a5fd: [native] Specify https as an application query scheme.
Jul 10 2023, 12:49 PM
tomek closed D8461: [lib] Fix primary links reducer.
Jul 10 2023, 12:49 PM
tomek closed D8444: [native] Make manage links modal consistent with web.
Jul 10 2023, 12:49 PM
tomek committed rCOMM3ff8ce6b0c19: [lib] Fix primary links reducer.
Jul 10 2023, 12:49 PM
tomek committed rCOMMaafdbef2ec76: [native] Make manage links modal consistent with web.
Jul 10 2023, 12:49 PM
tomek closed D8423: [web][native] Update invite link copy.
Jul 10 2023, 12:49 PM
tomek committed rCOMMea404a7f7f31: [web][native] Update invite link copy.
Jul 10 2023, 12:49 PM
tomek closed D8419: [web] Introduce disable link modal.
Jul 10 2023, 12:49 PM
tomek closed D8417: [web] Call update or create invite link endpoint.
Jul 10 2023, 12:49 PM
tomek committed rCOMMc38470e72f08: [web] Introduce disable link modal.
Jul 10 2023, 12:49 PM
tomek committed rCOMM1c1c441933e7: [web] Call update or create invite link endpoint.
Jul 10 2023, 12:49 PM
tomek closed D8416: [lib] Extract invite links actions.
Jul 10 2023, 12:49 PM
tomek committed rCOMM88fc1560e536: [lib] Extract invite links actions.
Jul 10 2023, 12:49 PM
tomek closed D8415: [web] Introduce edit link modal.
Jul 10 2023, 12:49 PM
tomek closed D8414: [web] Split modal into multiple components.
Jul 10 2023, 12:49 PM
tomek closed D8413: [web] Create manage links modal.
Jul 10 2023, 12:48 PM
tomek committed rCOMM5e19f016d6b8: [web] Introduce edit link modal.
Jul 10 2023, 12:48 PM
tomek committed rCOMMb3529340de90: [web] Split modal into multiple components.
Jul 10 2023, 12:48 PM
tomek committed rCOMM6fee9ffa8b7c: [web] Create manage links modal.
Jul 10 2023, 12:48 PM
tomek closed D8412: [web] Extract copy link button.
Jul 10 2023, 12:48 PM
tomek closed D8307: [web] Add manage invite links menu item.
Jul 10 2023, 12:48 PM
tomek committed rCOMM518cd63dd905: [web] Add manage invite links menu item.
Jul 10 2023, 12:48 PM
tomek committed rCOMM5e63da8e2298: [web] Extract copy link button.
Jul 10 2023, 12:48 PM
tomek closed D8306: [web] Allow other types of icons in menu item.
Jul 10 2023, 12:48 PM
tomek committed rCOMM3ea12fe1fe4c: [web] Allow other types of icons in menu item.
Jul 10 2023, 12:48 PM
tomek requested review of D8462: [native] Specify https as an application query scheme.
Jul 10 2023, 12:18 PM
tomek requested review of D8461: [lib] Fix primary links reducer.
Jul 10 2023, 11:00 AM
tomek added inline comments to D8423: [web][native] Update invite link copy.
Jul 10 2023, 8:28 AM
tomek added inline comments to D8419: [web] Introduce disable link modal.
Jul 10 2023, 8:24 AM
tomek attached a referenced file: F624863: web-disable-link-gap.png.
Jul 10 2023, 8:02 AM

Jul 7 2023

tomek requested review of D8444: [native] Make manage links modal consistent with web.
Jul 7 2023, 1:29 PM
tomek accepted D8429: [web] Change search button clickable area.

Looks good! This diff is simple so it doesn't matter that much, but usually we're including a screenshot of the result in a test plan / summary.

Jul 7 2023, 12:19 PM
tomek added inline comments to D8419: [web] Introduce disable link modal.
Jul 7 2023, 9:44 AM
tomek updated the diff for D8419: [web] Introduce disable link modal.

Use gap

Jul 7 2023, 9:42 AM
tomek attached a referenced file: F624807: web-edit-link-gap.png.
Jul 7 2023, 9:33 AM
tomek added inline comments to D8415: [web] Introduce edit link modal.
Jul 7 2023, 9:33 AM
tomek updated the diff for D8415: [web] Introduce edit link modal.

Use 12px gap instead of new line chars

Jul 7 2023, 9:33 AM
tomek accepted D8377: Encrypt rescinds.
Jul 7 2023, 9:05 AM
tomek requested changes to D8429: [web] Change search button clickable area.

It is usually a good idea for a parent to position their children instead of children positioning themselves. Concretely, we should prefer to set gap on flex container instead of setting margin on arbitrarily chosen component.

Jul 7 2023, 8:47 AM
tomek attached a referenced file: F623247: manage-new-title.png.
Jul 7 2023, 7:58 AM

Jul 6 2023

tomek attached a referenced file: F623452: new-navite-disable.png.
Jul 6 2023, 3:00 PM
tomek added inline comments to D8419: [web] Introduce disable link modal.
Jul 6 2023, 2:59 PM
tomek added inline comments to D8423: [web][native] Update invite link copy.
Jul 6 2023, 2:41 PM
tomek added inline comments to D8419: [web] Introduce disable link modal.
Jul 6 2023, 2:34 PM
tomek updated the diff for D8417: [web] Call update or create invite link endpoint.

Rebase

Jul 6 2023, 2:08 PM
tomek updated the diff for D8415: [web] Introduce edit link modal.

Rebase

Jul 6 2023, 2:04 PM
tomek updated the diff for D8414: [web] Split modal into multiple components.

Rebase

Jul 6 2023, 1:58 PM
tomek added inline comments to D8413: [web] Create manage links modal.
Jul 6 2023, 1:50 PM
tomek updated the diff for D8413: [web] Create manage links modal.

Update modal name

Jul 6 2023, 1:50 PM
tomek accepted D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jul 6 2023, 12:19 PM
tomek requested changes to D8377: Encrypt rescinds.
Jul 6 2023, 11:58 AM

Jul 5 2023

tomek attached a referenced file: F621698: web-disable-link.png.
Jul 5 2023, 11:50 AM
tomek attached a referenced file: F621700: native-disable-description.png.
Jul 5 2023, 11:50 AM
tomek attached a referenced file: F621703: native-design-disable.png.
Jul 5 2023, 11:50 AM
tomek attached a referenced file: F621702: web-design-disable.png.
Jul 5 2023, 11:50 AM
tomek added inline comments to D8419: [web] Introduce disable link modal.
Jul 5 2023, 11:49 AM
tomek updated the diff for D8419: [web] Introduce disable link modal.

Update copy and button props

Jul 5 2023, 11:49 AM
tomek updated the diff for D8417: [web] Call update or create invite link endpoint.

Rebase

Jul 5 2023, 11:23 AM
tomek added inline comments to D8417: [web] Call update or create invite link endpoint.
Jul 5 2023, 11:22 AM
tomek updated the summary of D8417: [web] Call update or create invite link endpoint.
Jul 5 2023, 11:21 AM
tomek added inline comments to D8416: [lib] Extract invite links actions.
Jul 5 2023, 11:19 AM