In D8527#251416, @ashoat wrote:Can you provide some more context on the selection of this package? I noticed it hasn't been updated in 3 years and has some unaddressed GitHub issues, but I'm guessing your research showed that it's the best option.
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jul 25 2023
Jul 25 2023
Looks great!
Jul 24 2023
Jul 24 2023
In D8494#250498, @ashoat wrote:Let's actually capitalize the first letter. We should probably do the same in log-in form, but to be fair it's a little different visually... the errors there are shorter, and are not given their own full-width container (if I recall correctly)
Capitalize the first letters of error messages
Looks ok, but I don't know C++ enough to be sure
Is there a diff where we start using this instead of the default Alert?
Jul 18 2023
Jul 18 2023
Jul 17 2023
Jul 17 2023
Jul 13 2023
Jul 13 2023
Jul 12 2023
Jul 12 2023
There's actually another problem: the generated functions can't be typed with our types because they will get out of sync. What I mean by that is that these functions operate on data that is stored in sqlite/redux at this point in time. If in the future someone modifies e.g. RawMessageInfo then this new type could conflict with the generated functions' body and make a flow error.
That makes sense, and we're assuming state type in our migrations, so it seems consistent.
Jul 11 2023
Jul 11 2023
Jul 10 2023
Jul 10 2023
Jul 7 2023
Jul 7 2023
Looks good! This diff is simple so it doesn't matter that much, but usually we're including a screenshot of the result in a test plan / summary.
Use 12px gap instead of new line chars
It is usually a good idea for a parent to position their children instead of children positioning themselves. Concretely, we should prefer to set gap on flex container instead of setting margin on arbitrarily chosen component.
Jul 6 2023
Jul 6 2023
Rebase
Rebase
Update modal name
Jul 5 2023
Jul 5 2023
Update copy and button props
Rebase