Rebase and fix a new error

Rebase

Rebase

Even better!

Thanks for identifying / fixing this

I'm guessing that threadHasPermission should also be updated to "go through" permissionLookup?

These diffs are hard to review because I can't tell where this is going to be used. Please be extra careful with your work

If this is still relevant, should I update hasPermission to always ensure that KNOW_OF bit is set?

1. We didn't update the validators to match this
2. The types should've been optional for the "server" versions, since the keyserver still has to support older clients

Rebase

API looks good to me! Deferring to others on Rust

Okay that makes sense. And it doesn't matter if that changes in the past, since this migration won't be run in the future

This feels like a super hacky approach and I think you're applying it in the wrong part of the stack

Rebase

Rebase

Rebase

Rebase

Glazed through most of this, trusting you did the find-replaces correctly

We should also make sure we don't log out if we're already logged out

This is a good start, but we should be doing the same stuff we do for the client_version_unsupported error from the keyserver:

Build iOS app and sends some notifications ensure that logging line is called at least every 4 - 5 notifications.

This technically works, but something is going on where an ESLint rule isn't firing... you COULD ignore that and the component will work fine, but it's best to follow the conventions to avoid potential future pitfalls

I did some spot-checking but didn't review each line

Oh whoa, so the original change actually makes shadesBlack60 and some others more accurate.

I strongly suspect that you have a circular dependency issue and you are papering over it. I spent about 20min pulling down your changes locally and then removing this diff. I can see it failing once you introduce the hasPermission check in thread-utils.js. Then I looked through the code and I think there's an import cycle here:

Not looking too closely; trusting Flow to catch any issues

This is super hacky – can you spend some more time explaining the error you're seeing and what you've tried?

Didn't really review... assuming this is just a move

Looks right. This stuff is hard to review, hoping you were thorough when writing / testing

This change makes sense, but we'll need to make sure we handle it in updateRoles, modifyRole, createInitialRolesForNewThread, etc. Assume you'll put those diffs up later and land them together with this one.

Thanks for explaining. Let's keep the new color, but I'd like an answer to my question about the arithmetic. You're making an opinionated change here by changing our existing colors (eg. 80 -> 70) – that change should be an informed one.

Yeah that's what I meant!

Rebase

Replace string[] with Array<string>

Rebase

Rebase

I don't love the naming here. The issue starts with the proto file names... "client" vs. "authenticated" isn't a clear dichotomy. The use of "client" in this file makes more sense, but adds further confusion.

Please justify this change more

Same concerns as I laid out in D9789

1. It seems like "90" and "80" are super close. Are you sure we need this new color? Can you explain / justify its introduction a bit more?
2. Is 50 / 60 / 70 / 80 / 90 actually arithmetically accurate? I have a suspicion it's not. If we actually took real mathematic percentages of pure black, what would it really be?

Can you add this to all of the JS builds?

D9776