Page MenuHomePhabricator
Feed Advanced Search

May 22 2024

marcin added inline comments to D12164: [lib] Migrate remaining actions.
May 22 2024, 7:29 AM
marcin added inline comments to D12162: [lib] Replace merging entries with an ops approach.
May 22 2024, 7:26 AM
marcin accepted D12177: [lib] Stop checking for entry store inconsistencies.
May 22 2024, 7:19 AM
marcin updated the test plan for D12177: [lib] Stop checking for entry store inconsistencies.
May 22 2024, 7:19 AM
marcin updated the test plan for D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.
May 22 2024, 7:17 AM
marcin accepted D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.
May 22 2024, 7:17 AM
marcin accepted D12169: [web] Replace persisted entries with the ones from initial redux state.
May 22 2024, 7:15 AM
marcin added inline comments to D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.
May 22 2024, 7:08 AM
marcin added inline comments to D12162: [lib] Replace merging entries with an ops approach.
May 22 2024, 7:06 AM
marcin added inline comments to D12162: [lib] Replace merging entries with an ops approach.
May 22 2024, 6:49 AM
marcin added inline comments to D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
May 22 2024, 5:32 AM
marcin updated the test plan for D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
May 22 2024, 5:32 AM
marcin requested changes to D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.
May 22 2024, 3:14 AM
marcin added inline comments to D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
May 22 2024, 3:09 AM
marcin accepted D12153: [native] Persist only lastUserInteractionCalendar from the entry store.

Accepting but for now we have to hold this diff.

May 22 2024, 3:01 AM
marcin accepted D12157: [native] Add a migration that moves entries to SQLite.
May 22 2024, 2:53 AM
marcin accepted D12152: [lib] Schedule entry store ops processing.
May 22 2024, 2:49 AM
marcin accepted D12147: [lib] Handle setClientDBStoreActionType for entries.
May 22 2024, 2:48 AM
marcin accepted D12143: [lib] Refactor the entries reducer to return an object.
May 22 2024, 2:41 AM

May 21 2024

marcin accepted D12159: [native] Avoid calling our custom Alert from reducers.
May 21 2024, 1:29 PM
marcin requested review of D12148: Connect pipes between C++ and JS for entry store.
May 21 2024, 12:26 PM
marcin updated the diff for D12142: Implement JSI for EntryStore.

Fix build failure

May 21 2024, 8:02 AM
marcin updated the diff for D12142: Implement JSI for EntryStore.

Rebase

May 21 2024, 7:47 AM
marcin updated the diff for D12138: Implement SQLite API to handle entry store.

Rebase

May 21 2024, 7:47 AM
marcin updated the diff for D12142: Implement JSI for EntryStore.

entry_info -> entry

May 21 2024, 6:55 AM
marcin updated the diff for D12138: Implement SQLite API to handle entry store.

entry_info -> entry

May 21 2024, 6:55 AM
marcin requested review of D12142: Implement JSI for EntryStore.
May 21 2024, 6:35 AM
marcin accepted D12141: [lib] Create entry store handler.
May 21 2024, 6:34 AM
marcin added inline comments to D12141: [lib] Create entry store handler.
May 21 2024, 6:34 AM
marcin requested review of D12138: Implement SQLite API to handle entry store.
May 21 2024, 3:40 AM
marcin accepted D12137: [lib] Create entry store operations.

It would be convenient if you could create a function that converts EntryInfo (of RawEntryInfo) into ClientDBEntryInfo - it will help me write tests for first C++ diff.

May 21 2024, 2:36 AM

May 20 2024

marcin updated the diff for D12034: Change SIWE panel props to enable passing complete SIWE message.

Extract constants and fix typos

May 20 2024, 10:21 AM
marcin updated the diff for D12033: Introduce new header to siwe endpoint.
  1. Fix typo
  2. Remove unused function.
May 20 2024, 10:20 AM
marcin updated the diff for D12032: Extract shared logci for SIWE panel state handling.

Add suggested memoization.

May 20 2024, 10:19 AM
marcin added inline comments to D12036: Enable backup restoration for SIWE users via testing buttons.
May 20 2024, 10:18 AM
marcin added inline comments to D12033: Introduce new header to siwe endpoint.
May 20 2024, 9:57 AM
marcin added a reverting change for D11836: [CryptoModule] remove `(char *)` casting: rCOMM3d71d5afcc79: Revert "[CryptoModule] remove `(char *)` casting".
May 20 2024, 8:27 AM
marcin committed rCOMM3d71d5afcc79: Revert "[CryptoModule] remove `(char *)` casting" (authored by marcin).
Revert "[CryptoModule] remove `(char *)` casting"
May 20 2024, 8:27 AM
marcin added a reverting change for rCOMM411a2456aa6b: [CryptoModule] remove `(char *)` casting: rCOMM3d71d5afcc79: Revert "[CryptoModule] remove `(char *)` casting".
May 20 2024, 8:27 AM
marcin accepted D12104: [native] Fix error propagation in AESCryptoModule.
May 20 2024, 3:39 AM
marcin added inline comments to D12013: [native] Verify if the backup version is correct.
May 20 2024, 3:30 AM
marcin accepted D12013: [native] Verify if the backup version is correct.
May 20 2024, 3:29 AM

May 17 2024

marcin accepted D12080: [lib] implement Outbound P2P Messages API in `SQLiteAPI`.
May 17 2024, 6:36 AM
marcin accepted D12079: [native] implement Outbound P2P Messages API in JSI.
May 17 2024, 6:36 AM
marcin accepted D12078: [web] implement Outbound P2P Messages API on worker.
May 17 2024, 6:35 AM
marcin accepted D12075: [SQLite] remove `deviceID` param when getting all Outbound P2P messages.
May 17 2024, 6:33 AM
marcin added inline comments to D12074: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`.
May 17 2024, 6:28 AM
marcin added inline comments to D12071: [SQLite] add query to mark outbound P2P message as sent.
May 17 2024, 6:22 AM
marcin added inline comments to D12070: [SQLite] add query to set ciphertext for outbound P2P message.
May 17 2024, 6:20 AM
marcin accepted D12069: [SQLite] add table with inbound P2P messages to backup blocklist.
May 17 2024, 6:16 AM
marcin added inline comments to D12050: [lib] Create a compaction after schema-changing migration.
May 17 2024, 5:28 AM
marcin updated subscribers of D12050: [lib] Create a compaction after schema-changing migration.
May 17 2024, 4:37 AM
marcin added inline comments to D12050: [lib] Create a compaction after schema-changing migration.
May 17 2024, 4:02 AM
marcin added inline comments to D12069: [SQLite] add table with inbound P2P messages to backup blocklist.
May 17 2024, 3:33 AM
marcin accepted D12068: [SQLite] recreate table for Outbound P2P messages.
May 17 2024, 3:30 AM
marcin added inline comments to D12050: [lib] Create a compaction after schema-changing migration.
May 17 2024, 3:27 AM
marcin accepted D12049: [lib] Add a way of marking migrations as schema-changing.
May 17 2024, 3:15 AM
marcin accepted D12048: [web] Run backup migrations.
May 17 2024, 3:14 AM
marcin accepted D12016: [native] Run backup migrations.
May 17 2024, 3:04 AM
marcin added inline comments to D12013: [native] Verify if the backup version is correct.
May 17 2024, 1:02 AM
marcin accepted D12037: [native] Adjust copy in backup message generation screen.
May 17 2024, 12:42 AM
marcin updated the diff for D12036: Enable backup restoration for SIWE users via testing buttons.
  1. Update to reflect changes deeper in the stack
  2. Address comments about copy
May 17 2024, 12:41 AM
marcin updated the diff for D12035: Modify Rust restore code to avoid fetching latest backup id twice.
  1. Address comment about Optional
  2. Add additional siwe message parsing to avoid having to do it in JS (where we have no tools for that)
May 17 2024, 12:40 AM
marcin updated the diff for D12034: Change SIWE panel props to enable passing complete SIWE message.
  1. Address comments about memoization.
  2. Modify SIWE panel to possibly take nonce, statement and issuedAt from external source and skip nonce generation in such a case. This is necessary for SIWE restore
May 17 2024, 12:39 AM
marcin updated the diff for D12033: Introduce new header to siwe endpoint.

Modify landing handler to take optional issuedAt property for SIWE. This will be needed for SIWE restore

May 17 2024, 12:37 AM
marcin updated the diff for D12032: Extract shared logci for SIWE panel state handling.

Rebase master

May 17 2024, 12:36 AM
marcin added inline comments to D12036: Enable backup restoration for SIWE users via testing buttons.
May 17 2024, 12:34 AM

May 16 2024

marcin added a comment to D12033: Introduce new header to siwe endpoint.

So is the new plan for keyserver to parse the message that is passed in, extract nonce and issuedAt, and then insert that into the JS?

May 16 2024, 12:27 PM
marcin added a comment to D12033: Introduce new header to siwe endpoint.

Why can't we just generate the message in landing/siwe.react.js, like we do in the existing code?

May 16 2024, 12:08 PM
marcin accepted D12044: [web] improve handling of non-existing olm sessions.
May 16 2024, 8:52 AM
marcin added inline comments to D12050: [lib] Create a compaction after schema-changing migration.
May 16 2024, 7:37 AM
marcin added a comment to D12033: Introduce new header to siwe endpoint.

I have refactored the entire stack locally to use decomposition of siwe message on native to learn that it is not possible on native. This is because siwe library uses Buffer object when parsing string into structured message object. There are two solutions now:

  1. Pass message on native to WebView and perform decomposition in landing-handler.
  2. Use siwe create from Rust to parse the message and expose it vie C++ to JS. - it should be entire day of work.
May 16 2024, 7:25 AM
marcin added inline comments to D12033: Introduce new header to siwe endpoint.
May 16 2024, 7:20 AM
marcin closed D12051: Ensure that the same ETH account is used for each signature.
May 16 2024, 3:56 AM
marcin committed rCOMM16cd530ee676: Ensure that the same ETH account is used for each signature (authored by marcin).
Ensure that the same ETH account is used for each signature
May 16 2024, 3:56 AM
marcin updated the diff for D12051: Ensure that the same ETH account is used for each signature.
  1. Address Ashoat's sugestions.
  2. Rebase before landing
May 16 2024, 3:44 AM

May 15 2024

marcin added a comment to D12033: Introduce new header to siwe endpoint.

This design seems very unsafe to me. Can we find a way forward that doesn't allow the client to pass in any message to be signed?

Two alternatives that I can think of are:

  1. Decompose siweMessageToSign in siwe-panel before passing to headers and then re-construct it in siwe.react.js
  2. Make direct HTTP request to backup service from siwe.react.js. - don't know if it will work.

Both are significant changes to entire stack so I would like to understand what exact dangers are we risking by passing full message to sign.

May 15 2024, 7:09 AM
marcin requested review of D12051: Ensure that the same ETH account is used for each signature.
May 15 2024, 6:53 AM
marcin added inline comments to D12033: Introduce new header to siwe endpoint.
May 15 2024, 6:50 AM

May 14 2024

marcin requested review of D12035: Modify Rust restore code to avoid fetching latest backup id twice.
May 14 2024, 9:38 AM
marcin updated the diff for D12036: Enable backup restoration for SIWE users via testing buttons.

changes from parent diff

May 14 2024, 9:25 AM
marcin requested review of D12036: Enable backup restoration for SIWE users via testing buttons.
May 14 2024, 9:17 AM
marcin requested review of D12034: Change SIWE panel props to enable passing complete SIWE message.
May 14 2024, 9:04 AM
marcin requested review of D12033: Introduce new header to siwe endpoint.
May 14 2024, 8:58 AM
marcin requested review of D12032: Extract shared logci for SIWE panel state handling.
May 14 2024, 8:51 AM

May 13 2024

marcin accepted D11993: [native] Revise SIWE backup copy.
May 13 2024, 2:58 AM

May 9 2024

marcin closed D11858: Specify android notification priority based on its visual action.
May 9 2024, 7:42 AM
marcin committed rCOMM03f006e33bf1: Specify android notification priority based on its visual action (authored by marcin).
Specify android notification priority based on its visual action
May 9 2024, 7:42 AM
marcin updated the diff for D11858: Specify android notification priority based on its visual action.

Rebase before landing

May 9 2024, 7:22 AM
marcin closed D11968: Bump staging backup service version.
May 9 2024, 7:01 AM
marcin committed rCOMMda2381adc0b0: Bump staging backup service version (authored by marcin).
Bump staging backup service version
May 9 2024, 7:01 AM
marcin closed D11735: Introduce new JSI call to retrieve backup message for latest siwe backup.
May 9 2024, 7:01 AM
marcin closed D11733: Update latest backup id search index to include 'msgBackup'.
May 9 2024, 7:00 AM
marcin closed D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.
May 9 2024, 7:00 AM
marcin committed rCOMMdf80d4d44147: Introduce new JSI call to retrieve backup message for latest siwe backup (authored by marcin).
Introduce new JSI call to retrieve backup message for latest siwe backup
May 9 2024, 7:00 AM
marcin committed rCOMMb5133e10780b: Update latest backup id search index to include 'msgBackup' (authored by marcin).
Update latest backup id search index to include 'msgBackup'
May 9 2024, 7:00 AM
marcin committed rCOMMe95762eb3911: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse' (authored by marcin).
Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'
May 9 2024, 7:00 AM
marcin closed D11716: Enable backup creation and upload for SIWE users from JS.
May 9 2024, 7:00 AM
marcin committed rCOMMbfc1f2c9c4ba: Enable backup creation and upload for SIWE users from JS (authored by marcin).
Enable backup creation and upload for SIWE users from JS
May 9 2024, 7:00 AM
marcin closed D11715: Update native backup code to handle siwe backup message.
May 9 2024, 7:00 AM