Page MenuHomePhorge
Feed Search

Jul 17 2023

jon committed rCOMM0955edc89f9b: [Keyserver/rust] Remove legacy auth_token configuration.
Jul 17 2023, 2:39 AM
jon committed rCOMM2961e68cfce7: [Keyserver/rust] Enable logging of rust addon.
Jul 17 2023, 2:39 AM
jon closed D8401: [Identity] Allow for setting logging levels through env.
Jul 17 2023, 2:39 AM
jon closed D8402: [Identity] Fix opaque login.
Jul 17 2023, 2:39 AM
jon committed rCOMM57cf5dbdec07: [Identity] Allow for setting logging levels through env.
Jul 17 2023, 2:39 AM
jon committed rCOMM6dc2a953186c: [Identity] Fix opaque login.
Jul 17 2023, 2:39 AM
jon closed D8400: [Keyserver] Apply DB Migrations.
Jul 17 2023, 2:39 AM
jon committed rCOMM06a3b6b3ff76: [Keyserver] Apply DB Migrations.
Jul 17 2023, 2:39 AM
jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

Rebase on master

Jul 17 2023, 2:15 AM
jon updated the diff for D8404: [Keyserver/rust] Remove legacy auth_token configuration.

Rebase on master

Jul 17 2023, 2:14 AM
jon updated the diff for D8403: [Keyserver/rust] Enable logging of rust addon.

Rebase on master

Jul 17 2023, 2:14 AM
jon updated the diff for D8402: [Identity] Fix opaque login.

Rebase on master

Jul 17 2023, 2:14 AM
jon updated the diff for D8401: [Identity] Allow for setting logging levels through env.

Rebase on master

Jul 17 2023, 2:13 AM
jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Rebase on master

Jul 17 2023, 2:13 AM
jon added inline comments to D8402: [Identity] Fix opaque login.
Jul 17 2023, 2:07 AM
jon updated the diff for D8402: [Identity] Fix opaque login.

Remove unused import

Jul 17 2023, 2:05 AM

Jul 14 2023

jon updated the diff for D8475: [Keyserver] Refactor identity utilities.

Remove extra async

Jul 14 2023, 10:37 PM
jon added inline comments to D8475: [Keyserver] Refactor identity utilities.
Jul 14 2023, 10:33 PM
jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

remove extra async keyword

Jul 14 2023, 10:28 PM
jon added inline comments to D8400: [Keyserver] Apply DB Migrations.
Jul 14 2023, 10:25 PM
jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Fix whitespace

Jul 14 2023, 10:24 PM
jon accepted D8500: [identity] helper functions for removing data from DDB.
Jul 14 2023, 10:12 PM
jon accepted D8469: [CI] Buildkite for web emscripten build.
Jul 14 2023, 10:11 PM

Jul 13 2023

jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Improve error handling

Jul 13 2023, 9:48 PM
jon added inline comments to D8473: [Keyserver/rust] Add publish_prekeys implementation.
Jul 13 2023, 9:09 PM
jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Address feedback, refactor auth client into self-contained module

Jul 13 2023, 9:09 PM
jon added inline comments to D8464: [Identity] Implement RefreshUserPreKey.
Jul 13 2023, 5:19 PM
jon updated the diff for D8464: [Identity] Implement RefreshUserPreKey.

Address feedback

Jul 13 2023, 5:19 PM
jon added inline comments to D8463: [Services-test/identity] Refactor create_device.
Jul 13 2023, 5:05 PM
jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Address feedback

Jul 13 2023, 5:05 PM
jon added inline comments to D8434: [Identity] Add authenticated gRPC service.
Jul 13 2023, 5:05 PM
jon added inline comments to D8405: [Keyserver] Attempt login to identity service.
Jul 13 2023, 4:45 PM
jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

Address feedback

Jul 13 2023, 4:45 PM
jon added inline comments to D8401: [Identity] Allow for setting logging levels through env.
Jul 13 2023, 4:17 PM
jon updated the diff for D8401: [Identity] Allow for setting logging levels through env.

Address feedback, fix parent diff

Jul 13 2023, 4:17 PM
jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Address feedback

Jul 13 2023, 4:14 PM

Jul 11 2023

jon added inline comments to D8405: [Keyserver] Attempt login to identity service.
Jul 11 2023, 6:12 PM
jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Fix accidental rebase error

Jul 11 2023, 6:00 PM
jon updated the diff for D8476: [Keyserver] Publish prekeys to identity service for cron job.

Rebase on other work

Jul 11 2023, 5:55 PM
jon updated the diff for D8473: [Keyserver/rust] Add publish_prekeys implementation.

Rebase on other work

Jul 11 2023, 5:54 PM
jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

Address feedback

Jul 11 2023, 5:53 PM
jon added a comment to D8402: [Identity] Fix opaque login.

Continuing on :)

Jul 11 2023, 5:44 PM
jon added a comment to D8400: [Keyserver] Apply DB Migrations.

I think we'll need this check for new setups as well.

Jul 11 2023, 5:43 PM
jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Address feedback

Jul 11 2023, 5:42 PM
jon requested review of D8475: [Keyserver] Refactor identity utilities.
Jul 11 2023, 5:29 PM
jon requested review of D8476: [Keyserver] Publish prekeys to identity service for cron job.
Jul 11 2023, 5:26 PM
jon requested review of D8474: [Keyserver] Refactor prekey lifecycle logic.
Jul 11 2023, 5:18 PM
jon requested review of D8473: [Keyserver/rust] Add publish_prekeys implementation.
Jul 11 2023, 5:13 PM
jon accepted D8390: [shell] script to generate WASM database code.
Jul 11 2023, 4:59 PM
jon accepted D8446: [Nix] Explicitly set emscripten cache.
Jul 11 2023, 3:51 PM
jon resigned from D8455: [blob-service] Implement upload logic with new db.

rust LGTM, would like for someone else to take a look

Jul 11 2023, 1:21 AM
jon resigned from D8459: [blob-service] Delete old database code from http module.

rust LGTM, would like for someone else to take a look

Jul 11 2023, 1:20 AM
jon resigned from D8458: [blob-service] Call service methods from handlers.

rust LGTM, would like for someone else to take a look

Jul 11 2023, 1:20 AM
jon resigned from D8457: [blob-service] Support new abstraction in HTTP.

rust LGTM, would like for someone else to take a look

Jul 11 2023, 1:18 AM
jon resigned from D8456: [blob-service] Implement holder management with new db.

rust LGTM, would like for someone else to take a look

Jul 11 2023, 1:18 AM
jon resigned from D8454: [blob-service] Implement download logic with new db.

rust LGTM, would like for someone else to take a look

Jul 11 2023, 1:17 AM
jon resigned from D8453: [blob-service] Create business logic abstraction.

rust LGTM, would like for someone else to take a look

Jul 11 2023, 1:07 AM
jon resigned from D8452: [blob-service] DB: Add remaining client methods.

rust LGTM, would like for someone else to take a look

Jul 11 2023, 12:35 AM

Jul 10 2023

jon requested review of D8468: [Docs/nix] Document how to update flake and push artifacts.
Jul 10 2023, 10:14 PM
jon resigned from D8451: [blob-service] DB: Add holder management methods.

Rust looks fine to me, but would like other to take a look

Jul 10 2023, 6:11 PM
jon resigned from D8450: [blob-service] Introduce database client.

going to resign as I would like some of the others to review as well

Jul 10 2023, 5:45 PM
jon accepted D8450: [blob-service] Introduce database client.

otherwise the rest of the rust stuff looks fine to me.

Jul 10 2023, 5:45 PM
jon accepted D8447: [identity] hard-code the platform type for the identity docker image.
Jul 10 2023, 3:48 PM
jon updated the diff for D8434: [Identity] Add authenticated gRPC service.

Update parent diff

Jul 10 2023, 2:38 PM
jon closed D8312: [Docs] Document how to build and deploy tunnelbroker.
Jul 10 2023, 2:31 PM
jon committed rCOMM64b6154ef565: [Docs] Document how to build and deploy tunnelbroker.
Jul 10 2023, 2:31 PM
jon requested review of D8464: [Identity] Implement RefreshUserPreKey.
Jul 10 2023, 1:56 PM
jon requested review of D8463: [Services-test/identity] Refactor create_device.
Jul 10 2023, 1:51 PM
jon requested review of D8434: [Identity] Add authenticated gRPC service.
Jul 10 2023, 1:42 PM

Jul 7 2023

jon requested review of D8446: [Nix] Explicitly set emscripten cache.
Jul 7 2023, 7:16 PM
jon requested changes to D8390: [shell] script to generate WASM database code.
Jul 7 2023, 6:56 PM

Jul 6 2023

jon added inline comments to D8400: [Keyserver] Apply DB Migrations.
Jul 6 2023, 11:00 PM
jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Address feedback

Jul 6 2023, 10:57 PM
jon updated the diff for D8312: [Docs] Document how to build and deploy tunnelbroker.

ran -> run

Jul 6 2023, 10:43 PM
jon closed D8326: [Docs] Mention Chrome needs to be restarted.
Jul 6 2023, 10:41 PM
jon committed rCOMM8d63c6591600: [Docs] Mention Chrome needs to be restarted.
Jul 6 2023, 10:41 PM
jon accepted D8390: [shell] script to generate WASM database code.

Bash LGTM

Jul 6 2023, 10:40 PM
jon added 1 blocking reviewer(s) for D8402: [Identity] Fix opaque login: bartek.
Jul 6 2023, 6:33 PM
jon added a comment to D8402: [Identity] Fix opaque login.

should we just change the index projection to INCLUDE or ALL?

Jul 6 2023, 6:33 PM
jon updated the diff for D8405: [Keyserver] Attempt login to identity service.

Address feedback

Jul 6 2023, 5:59 PM
jon updated the diff for D8402: [Identity] Fix opaque login.

Address feedback

Jul 6 2023, 5:26 PM
jon closed D8399: [Keyserver/rust] Ignore debug version of napi build.
Jul 6 2023, 5:22 PM
jon closed D8366: [Keyserver/rust] Add device login and register.
Jul 6 2023, 5:22 PM
jon committed rCOMM47e3232b9532: [Keyserver/rust] Ignore debug version of napi build.
Jul 6 2023, 5:22 PM
jon committed rCOMMaf11c5973624: [Keyserver/rust] Add device login and register.
Jul 6 2023, 5:22 PM
jon closed D8365: [Keyserver] Remove legacy tunnelbroker types.
Jul 6 2023, 5:22 PM
jon committed rCOMMea1ac74c0ee1: [Keyserver] Remove legacy tunnelbroker types.
Jul 6 2023, 5:22 PM
jon updated the summary of D8401: [Identity] Allow for setting logging levels through env.
Jul 6 2023, 5:21 PM
jon updated the diff for D8401: [Identity] Allow for setting logging levels through env.

Address feedback

Jul 6 2023, 5:17 PM
jon updated the diff for D8400: [Keyserver] Apply DB Migrations.

Rebase, address feedback

Jul 6 2023, 5:11 PM
jon added a comment to D8400: [Keyserver] Apply DB Migrations.

Is there anybody else you can ask to help with review? Best to avoid having me as a solo reviewer. I've been getting pulled into a ton of diff reviews lately (more than before) and my time for them is very limited..

Jul 6 2023, 5:08 PM
jon edited reviewers for D8400: [Keyserver] Apply DB Migrations, added: kamil, michal; removed: ashoat.
Jul 6 2023, 5:08 PM
jon updated the diff for D8366: [Keyserver/rust] Add device login and register.

Address feedback, rebase

Jul 6 2023, 4:36 PM
jon added a comment to D8404: [Keyserver/rust] Remove legacy auth_token configuration.

After this lands, I can remove identity_auth_token from my production keyserver config, yeah?

Jul 6 2023, 4:31 PM
jon added a comment to D8399: [Keyserver/rust] Ignore debug version of napi build.

how do you generate rust-node-addon.node? i ran yarn build:debug and don't see it

Jul 6 2023, 4:29 PM

Jul 4 2023

jon added inline comments to D8312: [Docs] Document how to build and deploy tunnelbroker.
Jul 4 2023, 8:21 PM
jon updated the diff for D8312: [Docs] Document how to build and deploy tunnelbroker.

Address feedback

Jul 4 2023, 8:17 PM
jon added inline comments to D8312: [Docs] Document how to build and deploy tunnelbroker.
Jul 4 2023, 8:17 PM
jon added a comment to D8326: [Docs] Mention Chrome needs to be restarted.

Address feedback

Jul 4 2023, 8:12 PM
jon updated the diff for D8326: [Docs] Mention Chrome needs to be restarted.

Mention for both extensions

Jul 4 2023, 8:12 PM