Page MenuHomePhabricator
Feed Advanced Search

Jul 31 2023

ginsu committed rCOMMac613f40749b: [lib/native/web] update getMessageLabel parameters (authored by ginsu).
[lib/native/web] update getMessageLabel parameters
Jul 31 2023, 1:19 PM
ginsu committed rCOMMf29bf4eed7b4: [lib/native] update heightMeasurerKey function to consider inline engagement… (authored by ginsu).
[lib/native] update heightMeasurerKey function to consider inline engagement…
Jul 31 2023, 1:19 PM
ginsu closed D8610: [native] introduce DummyInlineEngagementNode.
Jul 31 2023, 1:19 PM
ginsu closed D8609: [lib/native/web] convert useInlineEngagementText to getInlineEngagmentSidebarText.
Jul 31 2023, 1:19 PM
ginsu committed rCOMMada7dd8d209f: [native] introduce DummyInlineEngagementNode (authored by ginsu).
[native] introduce DummyInlineEngagementNode
Jul 31 2023, 1:19 PM
ginsu closed D8578: [native] introduce functionality to send a reaction by pressing on the reaction pill..
Jul 31 2023, 1:19 PM
ginsu closed D8600: [native] show which reactions the viewer has already selected in the inline engagement.
Jul 31 2023, 1:19 PM
ginsu committed rCOMM9c5f41a61b9b: [lib/native/web] convert useInlineEngagementText to… (authored by ginsu).
[lib/native/web] convert useInlineEngagementText to…
Jul 31 2023, 1:19 PM
ginsu committed rCOMMb23bb9048b28: [native] show which reactions the viewer has already selected in the inline… (authored by ginsu).
[native] show which reactions the viewer has already selected in the inline…
Jul 31 2023, 1:19 PM
ginsu committed rCOMM0a4ed9961bc4: [native] introduce functionality to send a reaction by pressing on the reaction… (authored by ginsu).
[native] introduce functionality to send a reaction by pressing on the reaction…
Jul 31 2023, 1:19 PM
ginsu closed D8576: [native] make reactions prop for InlineEngagement requried.
Jul 31 2023, 1:19 PM
ginsu closed D8575: [native] add spacing in between each reaction pill.
Jul 31 2023, 1:19 PM
ginsu closed D8539: [native] seperate out each reaction into their own pill.
Jul 31 2023, 1:19 PM
ginsu committed rCOMM104bf7c713c4: [native] make reactions prop for InlineEngagement requried (authored by ginsu).
[native] make reactions prop for InlineEngagement requried
Jul 31 2023, 1:19 PM
ginsu committed rCOMM37a49bd1df75: [native] add spacing in between each reaction pill (authored by ginsu).
[native] add spacing in between each reaction pill
Jul 31 2023, 1:19 PM
ginsu committed rCOMM2e1a4bb63e4e: [native] seperate out each reaction into their own pill (authored by ginsu).
[native] seperate out each reaction into their own pill
Jul 31 2023, 1:19 PM
ginsu closed D8496: [native] clean up InlineEngagement component.
Jul 31 2023, 1:19 PM
ginsu closed D8497: [native] split the inline engagement pill into two.
Jul 31 2023, 1:19 PM
ginsu committed rCOMM2d893db09936: [native] clean up InlineEngagement component (authored by ginsu).
[native] clean up InlineEngagement component
Jul 31 2023, 1:19 PM
ginsu committed rCOMM14a54ad05d59: [native] split the inline engagement pill into two (authored by ginsu).
[native] split the inline engagement pill into two
Jul 31 2023, 1:19 PM
ginsu closed D8317: [lib] add reply/replies back to sidebar inline engagement.
Jul 31 2023, 1:19 PM
ginsu committed rCOMM206d67e9da1c: [lib] add reply/replies back to sidebar inline engagement (authored by ginsu).
[lib] add reply/replies back to sidebar inline engagement
Jul 31 2023, 1:19 PM
ginsu updated the diff for D8634: [native] correctly measure multimedia messages that have an inline engagement.

add some comments + rebase before landing

Jul 31 2023, 1:09 PM
ginsu updated the diff for D8632: [native] update heightMeasurerKey function to consider inline engagement for text messages.

rebase before landing

Jul 31 2023, 12:35 PM
ginsu updated the diff for D8630: [native] update dummyNodeForTextMessageHeightMeasurement to use dummy inline engagement component.

rebase before landing

Jul 31 2023, 12:33 PM
ginsu updated the diff for D8629: [lib/native/web] update getMessageLabel parameters.

rebase before landing

Jul 31 2023, 12:31 PM
ginsu updated the diff for D8628: [lib/native] update heightMeasurerKey function to consider inline engagement for robotext messages.

rebase before landing

Jul 31 2023, 12:30 PM
ginsu updated the diff for D8610: [native] introduce DummyInlineEngagementNode.

fix duplicate style for inline engagement container + rebase before landing

Jul 31 2023, 12:28 PM
ginsu published D8684: [web] clean up edited label for review.
Jul 31 2023, 11:50 AM
ginsu updated the diff for D8609: [lib/native/web] convert useInlineEngagementText to getInlineEngagmentSidebarText.

rebase before landing

Jul 31 2023, 11:40 AM
ginsu updated the diff for D8600: [native] show which reactions the viewer has already selected in the inline engagement.

rebase before landing

Jul 31 2023, 11:39 AM
ginsu updated the diff for D8578: [native] introduce functionality to send a reaction by pressing on the reaction pill..

rebase before landing

Jul 31 2023, 11:38 AM
ginsu updated the diff for D8576: [native] make reactions prop for InlineEngagement requried.

rebase before landing

Jul 31 2023, 11:37 AM
ginsu updated the diff for D8575: [native] add spacing in between each reaction pill.

rebase before landing

Jul 31 2023, 11:35 AM
ginsu updated the diff for D8539: [native] seperate out each reaction into their own pill.

rebase before landing

Jul 31 2023, 11:34 AM
ginsu updated the diff for D8497: [native] split the inline engagement pill into two.

rebase before landing

Jul 31 2023, 11:32 AM
ginsu updated the diff for D8496: [native] clean up InlineEngagement component.

rebase before landing

Jul 31 2023, 11:31 AM
ginsu updated the diff for D8317: [lib] add reply/replies back to sidebar inline engagement.

rebase before landing

Jul 31 2023, 11:29 AM
ginsu published D8678: [web] split the inline engagement pill into two for review.
Jul 31 2023, 7:27 AM
ginsu published D8677: [web] clean up InlineEngagement component for review.
Jul 31 2023, 7:19 AM

Jul 30 2023

ginsu updated the diff for D8600: [native] show which reactions the viewer has already selected in the inline engagement.

simplify

Jul 30 2023, 2:43 PM

Jul 28 2023

ginsu accepted D8445: [native] Prevent duplicate role names in one community on the client.

thanks for addressing my feedback!

Jul 28 2023, 1:49 PM

Jul 27 2023

ginsu added inline comments to D8634: [native] correctly measure multimedia messages that have an inline engagement.
Jul 27 2023, 10:57 PM
ginsu updated the diff for D8634: [native] correctly measure multimedia messages that have an inline engagement.

address comments

Jul 27 2023, 10:52 PM
ginsu added inline comments to D8634: [native] correctly measure multimedia messages that have an inline engagement.
Jul 27 2023, 10:06 PM
ginsu closed D8599: [native] upgrade rn-emoji-keyboard to v1.5.0.
Jul 27 2023, 1:28 PM
ginsu committed rCOMM41939d6ed964: [native] upgrade rn-emoji-keyboard to v1.5.0 (authored by ginsu).
[native] upgrade rn-emoji-keyboard to v1.5.0
Jul 27 2023, 1:28 PM
ginsu updated the diff for D8599: [native] upgrade rn-emoji-keyboard to v1.5.0.

rebase before landing

Jul 27 2023, 1:27 PM
ginsu accepted D8574: [keyserver/lib] Enable the option to delete custom roles.

Thanks for breaking this diff up!

Jul 27 2023, 12:06 AM

Jul 26 2023

ginsu requested changes to D8445: [native] Prevent duplicate role names in one community on the client.

I like the red text experience a lot better, thanks for iterating on that! Requesting changes on a few things I left comments for inline

Jul 26 2023, 10:18 PM
ginsu updated subscribers of D8634: [native] correctly measure multimedia messages that have an inline engagement.
Jul 26 2023, 3:53 PM
ginsu added inline comments to D8630: [native] update dummyNodeForTextMessageHeightMeasurement to use dummy inline engagement component.
Jul 26 2023, 3:35 PM
ginsu added inline comments to D8610: [native] introduce DummyInlineEngagementNode.
Jul 26 2023, 3:29 PM
ginsu updated the diff for D8610: [native] introduce DummyInlineEngagementNode.

address duplicating styles concern

Jul 26 2023, 3:25 PM
ginsu added inline comments to D8610: [native] introduce DummyInlineEngagementNode.
Jul 26 2023, 2:45 PM
ginsu updated the diff for D8496: [native] clean up InlineEngagement component.

address comments

Jul 26 2023, 1:11 PM
ginsu added inline comments to D8496: [native] clean up InlineEngagement component.
Jul 26 2023, 1:04 PM
ginsu retitled D8317: [lib] add reply/replies back to sidebar inline engagement from [native] add reply/replies back to sidebar inline engagement to [lib] add reply/replies back to sidebar inline engagement.
Jul 26 2023, 11:40 AM

Jul 25 2023

ginsu added a comment to D8574: [keyserver/lib] Enable the option to delete custom roles.

A lot of the code in this diff is the scaffolding for the deletion API, so I decided that covering it all in one diff would be more logical and easier to review.

Jul 25 2023, 11:19 PM
ginsu requested review of D8634: [native] correctly measure multimedia messages that have an inline engagement.
Jul 25 2023, 11:13 PM
ginsu accepted D8592: [web] Display a Roles option in the community menu.

agree with @rohan that isDev check shouldn't be necessary if we are landing stack all at once

Jul 25 2023, 11:09 PM
ginsu resigned from D8564: [native] Support the edit_role action on the keyserver.

resigning since I don't have enough context on roles/permissions to give this a proper review

Jul 25 2023, 11:09 PM
ginsu requested review of D8632: [native] update heightMeasurerKey function to consider inline engagement for text messages.
Jul 25 2023, 2:43 PM
ginsu requested review of D8630: [native] update dummyNodeForTextMessageHeightMeasurement to use dummy inline engagement component.
Jul 25 2023, 1:56 PM
ginsu requested review of D8629: [lib/native/web] update getMessageLabel parameters.
Jul 25 2023, 1:23 PM
ginsu requested review of D8628: [lib/native] update heightMeasurerKey function to consider inline engagement for robotext messages.
Jul 25 2023, 12:39 PM
ginsu added inline comments to D8539: [native] seperate out each reaction into their own pill.
Jul 25 2023, 12:07 PM
ginsu updated the diff for D8539: [native] seperate out each reaction into their own pill.

fix center aligned inline engagement

Jul 25 2023, 12:05 PM

Jul 24 2023

ginsu attached a referenced file: F652135: Screenshot 2023-07-24 at 10.46.20 PM.png.
Jul 24 2023, 7:59 PM
ginsu attached a referenced file: F652147: Screenshot 2023-07-24 at 10.56.19 PM.png.
Jul 24 2023, 7:59 PM
ginsu added inline comments to D8610: [native] introduce DummyInlineEngagementNode.
Jul 24 2023, 7:58 PM
ginsu attached a referenced file: F652127: Screenshot 2023-07-24 at 9.33.43 PM.png.
Jul 24 2023, 7:45 PM
ginsu attached a referenced file: F652128: Screenshot 2023-07-24 at 9.36.34 PM.png.
Jul 24 2023, 7:45 PM
ginsu updated the summary of D8610: [native] introduce DummyInlineEngagementNode.
Jul 24 2023, 7:44 PM
ginsu requested review of D8610: [native] introduce DummyInlineEngagementNode.
Jul 24 2023, 7:39 PM
ginsu requested review of D8609: [lib/native/web] convert useInlineEngagementText to getInlineEngagmentSidebarText.
Jul 24 2023, 4:39 PM

Jul 21 2023

ginsu accepted D8591: [web] Rename invite-links-menu to community-actions-menu.
Jul 21 2023, 1:04 PM
ginsu requested review of D8600: [native] show which reactions the viewer has already selected in the inline engagement.
Jul 21 2023, 12:39 PM
ginsu updated the diff for D8575: [native] add spacing in between each reaction pill.

forgot to fix reactionStyle

Jul 21 2023, 11:49 AM
ginsu updated the diff for D8576: [native] make reactions prop for InlineEngagement requried.

rebase

Jul 21 2023, 11:48 AM
ginsu updated the diff for D8575: [native] add spacing in between each reaction pill.

address feedback

Jul 21 2023, 11:47 AM
ginsu added inline comments to D8575: [native] add spacing in between each reaction pill.
Jul 21 2023, 11:46 AM
ginsu accepted D8522: [native] Show a menu button next to each role except admins.

looks good!

Jul 21 2023, 11:43 AM
ginsu requested review of D8599: [native] upgrade rn-emoji-keyboard to v1.5.0.
Jul 21 2023, 11:19 AM

Jul 20 2023

ginsu accepted D8523: [native] Display an action sheet with the 'edit role' option.

accepting so I don't block this diff and also my concerns are outside the scope of this diff; however, it is becoming very obvious that we need our own shared action sheet component that abstracts a lot of the similar patterns surrounding the actions sheet (only showing cancel for iOS in options, the cancelButtonIndex, the userInterfaceStyle, etc). This task should help with addressing this concern too since we should be able to deprecate most of this logic in favor for our own custom bottomsheet.

Jul 20 2023, 3:24 PM
ginsu requested changes to D8522: [native] Show a menu button next to each role except admins.
Jul 20 2023, 3:01 PM
ginsu accepted D8478: [lib] Add unit tests for user-facing permissions to verify the result.

seems good, but would feel better if @atul could also take a look too when he's back

Jul 20 2023, 2:57 PM

Jul 19 2023

ginsu requested review of D8578: [native] introduce functionality to send a reaction by pressing on the reaction pill..
Jul 19 2023, 3:51 PM
ginsu requested review of D8576: [native] make reactions prop for InlineEngagement requried.
Jul 19 2023, 3:35 PM
ginsu requested review of D8575: [native] add spacing in between each reaction pill.
Jul 19 2023, 2:42 PM

Jul 18 2023

ginsu requested review of D8539: [native] seperate out each reaction into their own pill.
Jul 18 2023, 3:17 PM
ginsu updated the diff for D8033: [landing] introduce telegram competitor data.

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Jul 18 2023, 2:10 PM
ginsu updated the diff for D8032: [landing] introduce slack competitor data.

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Jul 18 2023, 2:09 PM
ginsu updated the diff for D8030: [landing] introduce Matrix competitor data.

update copy + change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Jul 18 2023, 2:07 PM
ginsu updated the diff for D8031: [landing] introduce keybase competitor data.

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Jul 18 2023, 2:05 PM
ginsu updated the diff for D8029: [landing] introduce Discord competitor data.

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Jul 18 2023, 2:04 PM
ginsu updated the diff for D7904: [landing] introduce signal competitor data.

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Jul 18 2023, 2:00 PM
ginsu updated the summary of D8025: [landing] introduce feature modal component.
Jul 18 2023, 1:57 PM
ginsu updated the summary of D8025: [landing] introduce feature modal component.
Jul 18 2023, 1:56 PM
ginsu attached a referenced file: F642946: Screenshot 2023-07-18 at 4.36.35 PM.png.
Jul 18 2023, 1:55 PM