- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jul 31 2023
add some comments + rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
fix duplicate style for inline engagement container + rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase before landing
Jul 30 2023
simplify
Jul 28 2023
thanks for addressing my feedback!
Jul 27 2023
address comments
rebase before landing
Thanks for breaking this diff up!
Jul 26 2023
I like the red text experience a lot better, thanks for iterating on that! Requesting changes on a few things I left comments for inline
address duplicating styles concern
address comments
Jul 25 2023
A lot of the code in this diff is the scaffolding for the deletion API, so I decided that covering it all in one diff would be more logical and easier to review.
agree with @rohan that isDev check shouldn't be necessary if we are landing stack all at once
resigning since I don't have enough context on roles/permissions to give this a proper review
fix center aligned inline engagement
Jul 24 2023
Jul 21 2023
forgot to fix reactionStyle
rebase
address feedback
looks good!
Jul 20 2023
accepting so I don't block this diff and also my concerns are outside the scope of this diff; however, it is becoming very obvious that we need our own shared action sheet component that abstracts a lot of the similar patterns surrounding the actions sheet (only showing cancel for iOS in options, the cancelButtonIndex, the userInterfaceStyle, etc). This task should help with addressing this concern too since we should be able to deprecate most of this logic in favor for our own custom bottomsheet.
seems good, but would feel better if @atul could also take a look too when he's back
Jul 19 2023
Jul 18 2023
change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.
change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.
update copy + change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.
change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.
change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.
change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.