Page MenuHomePhabricator
Feed All Stories

Mar 31 2024

ashoat requested review of D11495: [lib][native] Pass FID from useRegistrationServerCall to identity service during registration.
Mar 31 2024, 10:15 AM
ashoat requested review of D11494: [lib][native] Update useRegistrationServerCall to set FID in FIDContext.
Mar 31 2024, 10:14 AM
ashoat updated the diff for D11492: [lib] Add Coinbase Wallet support.

Only introduce it on web. See comment here

Mar 31 2024, 5:59 AM

Mar 30 2024

ashoat requested review of D11492: [lib] Add Coinbase Wallet support.
Mar 30 2024, 5:58 PM
ashoat requested review of D11491: [native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates.
Mar 30 2024, 5:52 PM
ashoat requested review of D11490: [lib][web][landing] Don't include injectedWallet in mobile experience.
Mar 30 2024, 5:52 PM
ashoat requested review of D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.
Mar 30 2024, 5:44 PM
ashoat requested review of D11493: [buildkite] Update image used in Buildkite JS workflows to Node 20.
Mar 30 2024, 5:21 PM
ashoat committed rCOMM221d6fe6b8f3: [desktop] codeVersion → 12.0.0 (authored by ashoat).
[desktop] codeVersion → 12.0.0
Mar 30 2024, 4:52 PM
ashoat committed rCOMM5e7349fa7fed: [web] ESLint fix for NEXT_CODE_VERSION commit below (authored by ashoat).
[web] ESLint fix for NEXT_CODE_VERSION commit below
Mar 30 2024, 4:52 PM
ashoat committed rCOMMc7cdae5a807d: [web][keyserver] codeVersion -> 76 (authored by ashoat).
[web][keyserver] codeVersion -> 76
Mar 30 2024, 4:27 PM
ashoat committed rCOMM9a1a84aea24f: [keyserver] Update NEXT_CODE_VERSION to 12 for desktop (authored by ashoat).
[keyserver] Update NEXT_CODE_VERSION to 12 for desktop
Mar 30 2024, 4:27 PM
ashoat requested review of D11488: [native] Allow us to open a bunch of other wallets.
Mar 30 2024, 3:36 PM
ashoat added inline comments to D11465: [protos] Add RPC to log in existing device.
Mar 30 2024, 1:02 PM
ashoat added a comment to D11484: [native] update FarcasterPrompt based on if the fid is set or not.

Will this affect the experience when FarcasterPrompt is used from the registration flow?

Mar 30 2024, 1:00 PM
ashoat added inline comments to D11483: [native] introduce farcaster account settings profile row.
Mar 30 2024, 12:59 PM
bartek added inline comments to D11465: [protos] Add RPC to log in existing device.
Mar 30 2024, 1:02 AM

Mar 29 2024

ashoat requested review of D11486: [lib] Switch to Sepolia for ENSCache unit tests.

Looks like the Buildkite CI actually is running the ENSCache tests somehow? Anyways, the tests aren't supposed to pass until the next diff, and they do appear to be passing there

Mar 29 2024, 9:18 PM
ashoat requested review of D11487: [lib] Allow getNamesForAddresses to be called without ReverseRecords smart contract.
Mar 29 2024, 7:54 PM
ashoat requested review of D11485: [lib][native][web][keyserver][landing] Update to Ethers.js 6.
Mar 29 2024, 7:28 PM
ginsu planned changes to D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Mar 29 2024, 3:09 PM
ginsu requested review of D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Mar 29 2024, 2:52 PM
ginsu requested review of D11483: [native] introduce farcaster account settings profile row.
Mar 29 2024, 2:45 PM
ginsu closed D11463: [native] introduce already connected button to farcaster connect.
Mar 29 2024, 2:20 PM
ginsu committed rCOMMddfda1a8134d: [native] introduce already connected button to farcaster connect (authored by ginsu).
[native] introduce already connected button to farcaster connect
Mar 29 2024, 2:20 PM
ginsu closed D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.
Mar 29 2024, 2:20 PM
ginsu committed rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step (authored by ginsu).
[native] implement onSuccess callback for ConnectFarcaster registration step
Mar 29 2024, 2:20 PM
ginsu closed D11461: [native] add the connect farcaster step into the registration flow.
Mar 29 2024, 2:20 PM
ginsu committed rCOMM1a098f200daa: [native] add the connect farcaster step into the registration flow (authored by ginsu).
[native] add the connect farcaster step into the registration flow
Mar 29 2024, 2:20 PM
ginsu closed D11442: [native] introduce ConnectFarcaster registration screen.
Mar 29 2024, 2:20 PM
ginsu committed rCOMMc29ed7da457a: [native] introduce ConnectFarcaster registration screen (authored by ginsu).
[native] introduce ConnectFarcaster registration screen
Mar 29 2024, 2:20 PM
ginsu closed D11441: [native] introduce FarcasterPrompt.
Mar 29 2024, 2:20 PM
ginsu committed rCOMMe2063fce5e81: [native] introduce FarcasterPrompt (authored by ginsu).
[native] introduce FarcasterPrompt
Mar 29 2024, 2:20 PM
michal requested review of D11482: [web/native] Migrate keyserverStore to new tables.
Mar 29 2024, 2:02 PM
ginsu closed D11479: [keyserver] add file-type dep.
Mar 29 2024, 1:58 PM
ginsu committed rCOMM194afd3f0228: [keyserver] add file-type dep (authored by ginsu).
[keyserver] add file-type dep
Mar 29 2024, 1:58 PM
michal requested review of D11481: [sqlite/lib] Split keyserver ops for backed and non-backed up data.
Mar 29 2024, 1:58 PM
ashoat accepted D11480: [native] Turn migration 64 into noop.

It would be good to add some more context on why we're doing it, either as a comment in the code, or at least here

Mar 29 2024, 1:56 PM
ashoat accepted D11479: [keyserver] add file-type dep.
Mar 29 2024, 1:56 PM
michal requested review of D11473: [sqlite] Add keyservers_synced_data table.
Mar 29 2024, 1:52 PM
atul accepted D11463: [native] introduce already connected button to farcaster connect.
Mar 29 2024, 1:28 PM
atul accepted D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.
Mar 29 2024, 1:19 PM
atul accepted D11461: [native] add the connect farcaster step into the registration flow.
Mar 29 2024, 1:18 PM
atul published D11480: [native] Turn migration 64 into noop for review.
Mar 29 2024, 1:16 PM
ginsu requested review of D11479: [keyserver] add file-type dep.
Mar 29 2024, 1:15 PM
ashoat closed D11477: [native] Make thumbnail failed when main upload fails.
Mar 29 2024, 12:48 PM
ashoat closed D11476: [native] Avoid passing in localMediaID to onUploadFailed every time.
Mar 29 2024, 12:48 PM
ashoat committed rCOMM0b5e3cf676b0: [native] Avoid passing in localMediaID to onUploadFailed every time (authored by ashoat).
[native] Avoid passing in localMediaID to onUploadFailed every time
Mar 29 2024, 12:48 PM
ashoat committed rCOMM25d58e70ef2b: [native] Make thumbnail failed when main upload fails (authored by ashoat).
[native] Make thumbnail failed when main upload fails
Mar 29 2024, 12:48 PM
ashoat closed D11475: [native] Make sure we don't start message creation until thumbnail concludes.
Mar 29 2024, 12:48 PM
ashoat committed rCOMM03f0820671a9: [native] Make sure we don't start message creation until thumbnail concludes (authored by ashoat).
[native] Make sure we don't start message creation until thumbnail concludes
Mar 29 2024, 12:48 PM
atul closed D11478: [GH Actions] Include `actions/setup-python` action when using `pip`.
Mar 29 2024, 12:47 PM
atul committed rCOMM2d22d1e42168: [GH Actions] Include `actions/setup-python` action when using `pip` (authored by atul).
[GH Actions] Include `actions/setup-python` action when using `pip`
Mar 29 2024, 12:47 PM
ashoat accepted D11478: [GH Actions] Include `actions/setup-python` action when using `pip`.
Mar 29 2024, 12:46 PM
atul published D11478: [GH Actions] Include `actions/setup-python` action when using `pip` for review.
Mar 29 2024, 12:44 PM
atul accepted D11442: [native] introduce ConnectFarcaster registration screen.
Mar 29 2024, 12:31 PM
atul accepted D11441: [native] introduce FarcasterPrompt.

Looks good

Mar 29 2024, 12:28 PM
atul accepted D11475: [native] Make sure we don't start message creation until thumbnail concludes.
Mar 29 2024, 12:28 PM
atul accepted D11477: [native] Make thumbnail failed when main upload fails.
Mar 29 2024, 12:27 PM
atul accepted D11476: [native] Avoid passing in localMediaID to onUploadFailed every time.
Mar 29 2024, 12:26 PM
ashoat requested review of D11477: [native] Make thumbnail failed when main upload fails.
Mar 29 2024, 12:26 PM
ashoat requested review of D11476: [native] Avoid passing in localMediaID to onUploadFailed every time.
Mar 29 2024, 12:26 PM
ashoat requested review of D11475: [native] Make sure we don't start message creation until thumbnail concludes.
Mar 29 2024, 12:25 PM
varun accepted D11465: [protos] Add RPC to log in existing device.
Mar 29 2024, 12:21 PM
varun accepted D11464: [commtest] Add test for FindUserIdentity RPC.
Mar 29 2024, 12:20 PM
will added inline comments to D11472: [native] Blocklist for backed up tables.
Mar 29 2024, 12:15 PM
atul closed D11474: [GH Actions] Fix pip issue.
Mar 29 2024, 12:13 PM
atul committed rCOMM06810553e7d8: [GH Actions] Fix pip issue (authored by atul).
[GH Actions] Fix pip issue
Mar 29 2024, 12:13 PM
ashoat updated subscribers of D11472: [native] Blocklist for backed up tables.
Mar 29 2024, 12:05 PM
ashoat accepted D11474: [GH Actions] Fix pip issue.
Mar 29 2024, 11:55 AM
ashoat added inline comments to D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Mar 29 2024, 11:53 AM
atul published D11474: [GH Actions] Fix pip issue for review.
Mar 29 2024, 11:53 AM
ashoat accepted D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.

Thanks for doing this! It makes sense to me. Agree with @varun's proposal in ENG-7598, and separately I think it would be good to address ENG-7532 soon to avoid breaking changes to this RPC (due to the use of Identity)

Mar 29 2024, 11:49 AM
ashoat accepted D11465: [protos] Add RPC to log in existing device.
Mar 29 2024, 10:48 AM
ashoat accepted D11435: [protos] Reorder some RPCs.

Seems reasonable

Mar 29 2024, 10:47 AM
ashoat closed D11460: [lib] Hook everything together in FarcasterDataHandler.
Mar 29 2024, 8:34 AM
ashoat committed rCOMMd82eed21584e: [lib] Hook everything together in FarcasterDataHandler (authored by ashoat).
[lib] Hook everything together in FarcasterDataHandler
Mar 29 2024, 8:34 AM
michal requested review of D11472: [native] Blocklist for backed up tables.
Mar 29 2024, 7:03 AM
tomek closed D11440: [lib] Set default state when wiping out a keyserver store.
Mar 29 2024, 6:52 AM
tomek committed rCOMMb174bc063ee3: [lib] Set default state when wiping out a keyserver store (authored by tomek).
[lib] Set default state when wiping out a keyserver store
Mar 29 2024, 6:52 AM
michal accepted D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.
Mar 29 2024, 6:40 AM
michal accepted D11447: [web] update `decrypt` method use `EncryptedData`.
Mar 29 2024, 6:29 AM
michal accepted D11445: [web] update `encrypt` method to return `EncryptedData`.
Mar 29 2024, 6:27 AM
kamil published D11451: [native] update `olm` session creation code use `EncryptedData` for review.
Mar 29 2024, 5:46 AM
kamil published D11450: [web] update `olm` session creation code use `EncryptedData` for review.
Mar 29 2024, 5:46 AM
kamil published D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData` for review.
Mar 29 2024, 5:46 AM
kamil published D11448: [native] update `decrypt` method use `EncryptedData` for review.
Mar 29 2024, 5:45 AM
kamil published D11447: [web] update `decrypt` method use `EncryptedData` for review.
Mar 29 2024, 5:45 AM
kamil published D11446: [native] update `encrypt` method to return `EncryptedData` for review.
Mar 29 2024, 5:45 AM
kamil published D11445: [web] update `encrypt` method to return `EncryptedData` for review.
Mar 29 2024, 5:45 AM
inka closed D11394: [lib][web][native] Handle idnentity login in reducers.
Mar 29 2024, 4:58 AM
inka closed D11437: [lib] Wipe keyserver store on login.
Mar 29 2024, 4:58 AM
inka committed rCOMM8ba944173c98: [lib] Wipe keyserver store on login (authored by inka).
[lib] Wipe keyserver store on login
Mar 29 2024, 4:58 AM
inka committed rCOMM362fadd02e70: [lib][web][native] Handle idnentity login in reducers (authored by inka).
[lib][web][native] Handle idnentity login in reducers
Mar 29 2024, 4:58 AM
inka closed D11393: [lib] Add preRequestUserState to identity login.
Mar 29 2024, 4:58 AM
inka committed rCOMM4b6ffdaba055: [lib] Add preRequestUserState to identity login (authored by inka).
[lib] Add preRequestUserState to identity login
Mar 29 2024, 4:58 AM
inka added inline comments to D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Mar 29 2024, 4:29 AM
michal accepted D11437: [lib] Wipe keyserver store on login.
Mar 29 2024, 4:08 AM
inka accepted D11440: [lib] Set default state when wiping out a keyserver store.

I think this is fine. And this also addresses the fact that we forgot to include wiping activeSessionRecovery here

Mar 29 2024, 1:44 AM
inka updated the diff for D11393: [lib] Add preRequestUserState to identity login.

Simplify

Mar 29 2024, 1:37 AM