Some comments/proposals appeared in ENG-7598 that we need to take into account here. Requesting review now to open discussions
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 29 2024
Mar 29 2024
bartek published D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response for review.
Mar 28 2024
Mar 28 2024
will make sure the ci passes before landing
ginsu requested review of D11462: [native] implement onSuccess callback for ConnectFarcaster registration step.
will make sure ci passes before landing
ginsu requested review of D11461: [native] add the connect farcaster step into the registration flow.
lgtm
ashoat committed rCOMMa0cab739d3ff: [native] Fix up project.pbxproj after yarn cleaninstall (authored by ashoat).
[native] Fix up project.pbxproj after yarn cleaninstall
I previously reviewed this code in person
review feedback
We have ENG-7514 to track improving the robotext here, so that it mentions the user's Farcaster username
Just as a note, planning on removing this file from project.pbxproj. Context: https://phab.comm.dev/D11417?id=38396#inline-69092
varun committed rCOMM3806a88cd6aa: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient… (authored by varun).
[lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient…
varun committed rCOMM8cda325dd924: [native] add unlinkFarcasterAccount to CommRustModule (authored by varun).
[native] add unlinkFarcasterAccount to CommRustModule
varun committed rCOMMcfc0654d4c18: [native_rust_library] unlink_farcaster_account method (authored by varun).
[native_rust_library] unlink_farcaster_account method
[identity] unlink farcaster account RPC
varun committed rCOMM7e269eae587e: [identity] on linkFarcasterUser we should return an error if the FID already… (authored by varun).
[identity] on linkFarcasterUser we should return an error if the FID already…
varun committed rCOMMc648927875bc: [identity] check if fid is already taken when registering new user (authored by varun).
[identity] check if fid is already taken when registering new user
varun committed rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user (authored by varun).
[identity] don't let linkFarcasterAccount overwrite existing fid for user
[web] add client methods to web
varun committed rCOMM046f7eed864b: [native] add linkFarcasterAccount to native IdentityServiceContextProvider (authored by varun).
[native] add linkFarcasterAccount to native IdentityServiceContextProvider
varun committed rCOMM80b046bb17c9: [native] add linkFarcasterAccount to commRustModule (authored by varun).
[native] add linkFarcasterAccount to commRustModule
varun committed rCOMM607b65279825: [native_rust_library] implement link_farcaster_account client method (authored by varun).
[native_rust_library] implement link_farcaster_account client method
varun committed rCOMMf1d96072c6f2: [identity] link farcaster account implementation (authored by varun).
[identity] link farcaster account implementation
varun committed rCOMM17638e45a66f: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider (authored by ashoat).
[lib][native] Add getFarcasterUsers to IdentityServiceContextProvider
varun committed rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method (authored by varun).
[native_rust_library] get_farcaster_users client method
varun committed rCOMM1c4801b3aae5: [native] add getFarcasterUsers to commRustModule (authored by varun).
[native] add getFarcasterUsers to commRustModule
varun committed rCOMM88d9a0987b2b: [identity] get farcaster users rpc implementation (authored by varun).
[identity] get farcaster users rpc implementation
varun committed rCOMMaa1feb75a585: [identity] db method to get users for a set of farcaster ids (authored by varun).
[identity] db method to get users for a set of farcaster ids
[terraform] add GSI for farcasterID
varun committed rCOMMcbc627ce542e: [native] expose farcaster id param to native identity service context provider (authored by varun).
[native] expose farcaster id param to native identity service context provider
varun committed rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs (authored by varun).
[identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs
varun committed rCOMM75706c132d20: [proto][identity] add optional fid to registration request messages (authored by varun).
[proto][identity] add optional fid to registration request messages
varun added inline comments to D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
will abandoned D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
atul requested review of D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.
update
atul published D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts` for review.
do we need to change any client code now that some of these RPCs are returning "not found" ?
will requested review of D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
will added a reverting change for D11359: [lib] integrity reducer tests: D11456: Revert "[lib] integrity reducer tests".
will added a reverting change for rCOMM2c577fabda21: [lib] integrity reducer tests: D11456: Revert "[lib] integrity reducer tests".
[native] introduce FarcasterLogo
ginsu committed rCOMMaabf91724a80: [landing/lib/native] introduce FarcasterWebView (authored by ginsu).
[landing/lib/native] introduce FarcasterWebView