- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 4 2024
Rebase
Rebase
Rebase
Rebase
Fix compilation error
Jun 3 2024
Rebase
Rebase
Rebase
Rebase
Update wasm
Rebase and handle missing version
Rebase
Rebase
Rebase
Depends on https://phab.comm.dev/D12249
Setting a dependency on the URL doesn't work - we have to use just the diff id D12249
Since we don't want the users to be able to add users to community roots, we probably want to
May 29 2024
Fix indentation
Update commit message
Don't create a private thread
Don't create a thread with commbot - this is a DM and shouldn't be created on a non-auth keyserver
Currently, the data is stored in both SQLite and redux-persist. We use the data from SQLite only when checking for inconsistencies - the state in Redux is always based on redux-persist. The plan is to keep this approach for a couple of weeks and then start using SQLite as the source of truth - this is handled by the last three diffs in this stack and tracked in https://linear.app/comm/issue/ENG-8234/finish-migrating-entry-store-to-sqlite.
May 28 2024
This solution has one issue: we always send requests for all the users even if we've just asked for some of them. The following scenario shows the issue:
- New unknown users appear in the store with IDs e.g. [1,2,3]
- We send a request to identity asking about [1,2,3]
- A new unknown user 4 appears
- We send a request to identity asking about [1,2,3,4]
- Identity responds with [1,2,3]
- Identity responds with [1,2,3,4]
In D12060#344877, @kamil wrote:One question:
If I remember correctly CommunityStore was introduced directly for SQLite which means web clients should have it - so there is no need to fetch and return it again as this is a duplication of data client should have.
If communityStore changed in keyserver DB we should have some mechanism (updates/state sync/handler which fetches it) to get the newest data.If my suspicion is correct this diff is not needed but I wasn't reviewing the rest of the stack and I am missing some context so sorry for confusing if this was taken into account and this is still needed.