Page MenuHomePhabricator
Feed Advanced Search

Jun 4 2024

tomek committed rCOMMbd924bf527b6: [web] Check backup version when restoring (authored by tomek).
[web] Check backup version when restoring
Jun 4 2024, 5:45 AM
tomek committed rCOMM6a5b8410c86c: [native] Verify if the backup version is correct (authored by tomek).
[native] Verify if the backup version is correct
Jun 4 2024, 5:44 AM
tomek closed D12012: [native] Create a function returning the DB version.
Jun 4 2024, 5:44 AM
tomek closed D11942: [native] Set the DB version after registration.
Jun 4 2024, 5:44 AM
tomek committed rCOMMf010d27dcad2: [native] Create a function returning the DB version (authored by tomek).
[native] Create a function returning the DB version
Jun 4 2024, 5:44 AM
tomek committed rCOMMbe7c5a70c36c: [native] Set the DB version after registration (authored by tomek).
[native] Set the DB version after registration
Jun 4 2024, 5:44 AM
tomek closed D11937: [lib] Update DB version while running a migration.
Jun 4 2024, 5:44 AM
tomek committed rCOMM67f24417b28b: [lib] Update DB version while running a migration (authored by tomek).
[lib] Update DB version while running a migration
Jun 4 2024, 5:44 AM
tomek planned changes to D12050: [lib] Create a compaction after schema-changing migration.
Jun 4 2024, 5:33 AM
tomek updated the diff for D12048: [web] Run backup migrations.

Rebase

Jun 4 2024, 3:22 AM
tomek updated the diff for D12016: [native] Run backup migrations.

Rebase

Jun 4 2024, 3:22 AM
tomek updated the diff for D12050: [lib] Create a compaction after schema-changing migration.

Rebase

Jun 4 2024, 3:21 AM
tomek updated the diff for D12049: [lib] Add a way of marking migrations as schema-changing.

Rebase

Jun 4 2024, 3:21 AM
tomek updated the diff for D12015: [lib] Extract a function that runs the migrations.

Rebase

Jun 4 2024, 3:20 AM
tomek updated the diff for D12014: [lib] Move createAsyncMigrate to utils.

Rebase

Jun 4 2024, 3:20 AM
tomek updated the diff for D11947: [web] Check backup version when restoring.

Rebase

Jun 4 2024, 3:19 AM
tomek updated the diff for D12013: [native] Verify if the backup version is correct.

Fix compilation error

Jun 4 2024, 3:18 AM
tomek accepted D12309: [lib][web] Extract logic checking add users permissions.
Jun 4 2024, 2:45 AM
tomek accepted D12296: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`.
Jun 4 2024, 2:41 AM
tomek accepted D12295: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of `baseThreadIsWithBlockedUserOnly[WithoutAdminRoleCheck]`.
Jun 4 2024, 2:40 AM
tomek accepted D12294: [lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`.
Jun 4 2024, 1:58 AM
tomek accepted D12293: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`.
Jun 4 2024, 1:56 AM
tomek accepted D12292: [lib] Narrow types in `memberHasAdminPowers` call stack to remove `invariant`.
Jun 4 2024, 1:55 AM
tomek accepted D12290: [lib] Replace `innerThreadFrozenDueToBlock` with `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` in `useThreadsWithPermission`.
Jun 4 2024, 1:51 AM
tomek accepted D12306: [native] Remove unused componenet.
Jun 4 2024, 1:47 AM
tomek accepted D12289: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck`.
Jun 4 2024, 1:27 AM
tomek accepted D12288: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar`.
Jun 4 2024, 1:25 AM
tomek accepted D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
Jun 4 2024, 1:23 AM
tomek accepted D12278: [native] Avoid flicker when deleting during save/creation.
Jun 4 2024, 1:19 AM
tomek accepted D12264: [native] Make sure we finish saving Entry before deleting.
Jun 4 2024, 1:17 AM
tomek accepted D12263: [native] Fix Entry deletion after creation.
Jun 4 2024, 1:13 AM
tomek accepted D12286: [native] Fetch invite links when entering thread settings.
Jun 4 2024, 1:10 AM
tomek accepted D12285: [native] Stop navigating to Add Members from community creation.
Jun 4 2024, 1:09 AM
tomek accepted D12299: [terraform] Update Blob image on prod.
Jun 4 2024, 12:59 AM
tomek added inline comments to D12016: [native] Run backup migrations.
Jun 4 2024, 12:55 AM

Jun 3 2024

tomek updated the diff for D12048: [web] Run backup migrations.

Rebase

Jun 3 2024, 8:51 AM
tomek updated the diff for D12016: [native] Run backup migrations.

Rebase

Jun 3 2024, 8:50 AM
tomek updated the diff for D12050: [lib] Create a compaction after schema-changing migration.

Rebase

Jun 3 2024, 8:50 AM
tomek updated the diff for D12049: [lib] Add a way of marking migrations as schema-changing.

Rebase

Jun 3 2024, 8:49 AM
tomek updated the summary of D12016: [native] Run backup migrations.
Jun 3 2024, 8:48 AM
tomek updated the summary of D12049: [lib] Add a way of marking migrations as schema-changing.
Jun 3 2024, 8:46 AM
tomek updated the diff for D12015: [lib] Extract a function that runs the migrations.

Rebase

Jun 3 2024, 8:33 AM
tomek updated the summary of D12014: [lib] Move createAsyncMigrate to utils.
Jun 3 2024, 8:32 AM
tomek updated the diff for D12014: [lib] Move createAsyncMigrate to utils.

Rebase

Jun 3 2024, 8:31 AM
tomek updated the diff for D11947: [web] Check backup version when restoring.

Rebase

Jun 3 2024, 8:29 AM
tomek updated the summary of D11947: [web] Check backup version when restoring.
Jun 3 2024, 8:27 AM
tomek updated the diff for D12013: [native] Verify if the backup version is correct.

Update wasm

Jun 3 2024, 8:26 AM
tomek accepted D12284: [native] Navigate to invite links instead of add members modal.
Jun 3 2024, 7:52 AM
tomek added inline comments to D12013: [native] Verify if the backup version is correct.
Jun 3 2024, 7:25 AM
tomek updated the diff for D12013: [native] Verify if the backup version is correct.

Rebase and handle missing version

Jun 3 2024, 7:23 AM
tomek updated the diff for D12012: [native] Create a function returning the DB version.

Rebase

Jun 3 2024, 7:07 AM
tomek updated the summary of D12012: [native] Create a function returning the DB version.
Jun 3 2024, 7:07 AM
tomek updated the diff for D11942: [native] Set the DB version after registration.

Rebase

Jun 3 2024, 6:53 AM
tomek closed D12281: [blob] Don't check if the invite link is reserved.
Jun 3 2024, 6:44 AM
tomek committed rCOMMfda12f9dcff2: [blob] Don't check if the invite link is reserved (authored by tomek).
[blob] Don't check if the invite link is reserved
Jun 3 2024, 6:44 AM
tomek updated the diff for D11937: [lib] Update DB version while running a migration.

Rebase

Jun 3 2024, 6:43 AM
tomek requested review of D12281: [blob] Don't check if the invite link is reserved.
Jun 3 2024, 5:54 AM
tomek added inline comments to D12249: [sqlite] Implement C++ message store local ops.
Jun 3 2024, 4:45 AM
tomek accepted D12253: [sqlite] implement logic to get message store logic from SQLite.

Depends on https://phab.comm.dev/D12249

Setting a dependency on the URL doesn't work - we have to use just the diff id D12249

Jun 3 2024, 4:42 AM
tomek accepted D12249: [sqlite] Implement C++ message store local ops.
Jun 3 2024, 4:35 AM
tomek accepted D12248: [sqlite] implement sqlite methods for message store local.
Jun 3 2024, 4:28 AM
tomek accepted D12247: [sqlite] create message store local table.
Jun 3 2024, 4:22 AM
tomek accepted D12262: [native] Clean up Entry delete action.
Jun 3 2024, 4:17 AM
tomek accepted D12243: [keyserver] Allow staff to use reserved names for invite links.
Jun 3 2024, 1:58 AM
tomek accepted D12242: [lib] Allow dash character in invite links.
Jun 3 2024, 1:57 AM
tomek accepted D12241: [keyserver][lib] Deduplicate invite link RegExps.
Jun 3 2024, 1:57 AM
tomek accepted D12237: [web] Navigate to invite links instead of add members modal.

Since we don't want the users to be able to add users to community roots, we probably want to

Jun 3 2024, 1:52 AM
tomek accepted D12236: [web] Stop navigating to Add Members modal from community creation.
Jun 3 2024, 1:47 AM

May 29 2024

tomek closed D12229: [keyserver] Throw an exception when trying to create a DM on a non-auth keyserver.
May 29 2024, 7:37 AM
tomek committed rCOMMe64e7489b768: [keyserver] Throw an exception when trying to create a DM on a non-auth… (authored by tomek).
[keyserver] Throw an exception when trying to create a DM on a non-auth…
May 29 2024, 7:37 AM
tomek closed D12228: [keyserver] Don't create a thread with an admin when creating a new account.
May 29 2024, 7:37 AM
tomek closed D12227: [keyserver] Check if we should create GENESIS.
May 29 2024, 7:37 AM
tomek committed rCOMMd47601c4ec75: [keyserver] Don't create a thread with an admin when creating a new account (authored by tomek).
[keyserver] Don't create a thread with an admin when creating a new account
May 29 2024, 7:37 AM
tomek committed rCOMM3f309ce9e529: [keyserver] Check if we should create GENESIS (authored by tomek).
[keyserver] Check if we should create GENESIS
May 29 2024, 7:37 AM
tomek closed D12226: [keyserver] Add a function which checks if a keyserver is authoritative.
May 29 2024, 7:37 AM
tomek committed rCOMM77b0c5c52375: [keyserver] Add a function which checks if a keyserver is authoritative (authored by tomek).
[keyserver] Add a function which checks if a keyserver is authoritative
May 29 2024, 7:37 AM
tomek updated the diff for D12227: [keyserver] Check if we should create GENESIS.

Fix indentation

May 29 2024, 7:18 AM
tomek accepted D12219: [lib] Fetch missing usernames.
May 29 2024, 7:07 AM
tomek updated the test plan for D12229: [keyserver] Throw an exception when trying to create a DM on a non-auth keyserver.
May 29 2024, 6:38 AM
tomek updated the diff for D12229: [keyserver] Throw an exception when trying to create a DM on a non-auth keyserver.

Update commit message

May 29 2024, 6:38 AM
tomek updated the test plan for D12228: [keyserver] Don't create a thread with an admin when creating a new account.
May 29 2024, 6:31 AM
tomek updated the diff for D12228: [keyserver] Don't create a thread with an admin when creating a new account.

Don't create a private thread

May 29 2024, 6:30 AM
tomek updated the test plan for D12227: [keyserver] Check if we should create GENESIS.
May 29 2024, 4:57 AM
tomek updated the diff for D12227: [keyserver] Check if we should create GENESIS.

Don't create a thread with commbot - this is a DM and shouldn't be created on a non-auth keyserver

May 29 2024, 4:57 AM
tomek added inline comments to D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.
May 29 2024, 1:49 AM
tomek added a comment to D12177: [lib] Stop checking for entry store inconsistencies.

Currently, the data is stored in both SQLite and redux-persist. We use the data from SQLite only when checking for inconsistencies - the state in Redux is always based on redux-persist. The plan is to keep this approach for a couple of weeks and then start using SQLite as the source of truth - this is handled by the last three diffs in this stack and tracked in https://linear.app/comm/issue/ENG-8234/finish-migrating-entry-store-to-sqlite.

May 29 2024, 1:49 AM
tomek added inline comments to D12228: [keyserver] Don't create a thread with an admin when creating a new account.
May 29 2024, 1:45 AM
tomek accepted D12233: [lib] Avoid passing userStateBeforeRecovery to invalidateKeyserverSession.
May 29 2024, 1:43 AM
tomek accepted D12232: [lib] Pass userStateBeforeRecovery to setNewSession call in resolveKeyserverSessionInvalidation.
May 29 2024, 1:38 AM

May 28 2024

tomek accepted D12230: [keyserver] Print error when failing to load Webpack-generated assets.
May 28 2024, 8:55 AM
tomek requested review of D12229: [keyserver] Throw an exception when trying to create a DM on a non-auth keyserver.
May 28 2024, 6:09 AM
tomek requested review of D12228: [keyserver] Don't create a thread with an admin when creating a new account.
May 28 2024, 6:00 AM
tomek requested review of D12227: [keyserver] Check if we should create GENESIS.
May 28 2024, 5:45 AM
tomek requested review of D12226: [keyserver] Add a function which checks if a keyserver is authoritative.
May 28 2024, 5:38 AM
tomek accepted D12220: [lib] Render UserInfosHandler.
May 28 2024, 5:10 AM
tomek requested changes to D12219: [lib] Fetch missing usernames.

This solution has one issue: we always send requests for all the users even if we've just asked for some of them. The following scenario shows the issue:

  1. New unknown users appear in the store with IDs e.g. [1,2,3]
  2. We send a request to identity asking about [1,2,3]
  3. A new unknown user 4 appears
  4. We send a request to identity asking about [1,2,3,4]
  5. Identity responds with [1,2,3]
  6. Identity responds with [1,2,3,4]
May 28 2024, 5:09 AM
tomek accepted D12218: [lib] Reduce findUserIdentitiesActionTypes.
May 28 2024, 5:00 AM
tomek accepted D12217: [lib] Add useFindUserIdentities.
May 28 2024, 4:56 AM
tomek accepted D12216: [lib] Create user infos for new user ids.
May 28 2024, 4:55 AM
tomek requested changes to D12060: [keyserver/lib/web] include communityStore in the initialReduxState.

One question:
If I remember correctly CommunityStore was introduced directly for SQLite which means web clients should have it - so there is no need to fetch and return it again as this is a duplication of data client should have.
If communityStore changed in keyserver DB we should have some mechanism (updates/state sync/handler which fetches it) to get the newest data.

If my suspicion is correct this diff is not needed but I wasn't reviewing the rest of the stack and I am missing some context so sorry for confusing if this was taken into account and this is still needed.

May 28 2024, 4:47 AM