We should not be polluting the global namespace in D7101. You should not be able to use QueryExecResult without importing it unless it's in the Flow lib.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Mar 22 2023
Mar 22 2023
ashoat added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
ashoat requested changes to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
ashoat added inline comments to D6924: [keyserver] Introduce columns in messages table to support pinned messages.
ashoat added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
ashoat added inline comments to D7141: [keyserver] Display edited message in the sidebar if the source message is edited.
We can consider preventing users from sending empty edit messages.
In D7094#211792, @michal wrote:This diff seems to call getAPNsNotificationTopic with two parameters, but the version of that function in master only takes one parameter. Can you please update this diff's dependencies so I can see the rest of your stack? Please always set diff dependencies!
There's no stack for this diff, I'm calling getAPNsNotificationTopic with one argument, it's just an object with two fields.
Will this affect the height of the item? Have you made the necessary changes to the height determination code (textMessageItemHeight)?
ashoat requested changes to D7117: [keyserver] Add migration - process messages in our db for search.
nice! just one nit
just a couple nits
ashoat requested changes to D7137: [native] render thread avatars for parent/child threads in thread settings.
ginsu committed rCOMM9ea6a06baee7: [lib] introduce getDefaultAvatar helper function (authored by ginsu).
[lib] introduce getDefaultAvatar helper function
You should definitely have included @inka on this review – she is by far the expert on this code
I am skeptical that you need to be touching entity-text.js or entity-helpers.js at all. Can you explain what updates you think you need to the EntityText framework and why?
Mostly questions
rebase on master
Rebase on master
Address feedback
ashoat requested changes to D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Just a question
svc -> keyserver_service
bartek added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Please update native/expo-modules/aes-crypto/android/build.gradle before landing!
ashoat requested changes to D7106: Native Java code to request notifications permissions from JS on Android 13.
rohan updated the diff for D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
Use contentStringForMediaArray and confirm robotext is still as expected
rohan added inline comments to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
bartek added inline comments to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
[server] Update assetlinks file
tomek committed rCOMM825ba1f0e005: [server] Update AASA file so that we prove to iOS that the domain belongs to us (authored by tomek).
[server] Update AASA file so that we prove to iOS that the domain belongs to us
rohan added inline comments to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
In D7147#211972, @bartek wrote:How do you obtain the SHA-256 fingerprint? From what I understood from the diff description, it is copy-pasted from Play Console, right?
tomek added a comment to D7146: [server] Update AASA file so that we prove to iOS that the domain belongs to us.
In D7146#211968, @bartek wrote:
rohan updated the summary of D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
rohan updated the summary of D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
rohan updated the summary of D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
rohan requested review of D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
How do you obtain the SHA-256 fingerprint? From what I understood from the diff description, it is copy-pasted from Play Console, right?
bartek accepted D7146: [server] Update AASA file so that we prove to iOS that the domain belongs to us.
The new ID looks correct
rohan added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Move prekey information to top-level message
rohan added a comment to D6924: [keyserver] Introduce columns in messages table to support pinned messages.
In D6924#211756, @tomek wrote:It seems like I wasn't clear enough in my comment, so let me explain it differently. Correct me in any place where I'm wrong. So on the client side we would want to display three things:
- A robotext message in a thread telling that a message was pinned
- A pin indicator next to a message
- A list of pinned messages
As far as I understand, what you're describing handles only the 1st point. How do we plan to handle 2nd and 3rd?
update type
Task here: ENG-3377
update type
Revert the changes
• kuba retitled D6965: [lib][native] Displaying edited messages from database from [lib][native] Displaying edited messages from database to [lib] Displaying edited messages from database.
Simplified condition
This diff seems to call getAPNsNotificationTopic with two parameters, but the version of that function in master only takes one parameter. Can you please update this diff's dependencies so I can see the rest of your stack? Please always set diff dependencies!