Page MenuHomePhabricator
Feed All Stories

May 17 2023

bartek updated the diff for D7761: [native] Add utils to encrypt/decrypt base64 string.

Rebase

May 17 2023, 3:23 AM
bartek updated the diff for D7760: [native] Add base64 decode to CommUtilsModule.

Rebase

May 17 2023, 3:23 AM
bartek updated the diff for D7758: [native] Add C++ function to decode base64.

Refactor

May 17 2023, 3:23 AM
kuba added inline comments to D7794: [web] Add new edit message provider.
May 17 2023, 3:20 AM
kuba updated the diff for D7794: [web] Add new edit message provider.

Added useMemo to modalOverlay

May 17 2023, 3:20 AM
kuba updated the diff for D7825: [web] Store edited message draft in the state.

Rebase

May 17 2023, 3:13 AM
kuba added inline comments to D7823: [web] Added EditTextMessage component.
May 17 2023, 3:12 AM
kuba updated the diff for D7823: [web] Added EditTextMessage component.

Changed to the function component, addressed review

May 17 2023, 3:11 AM
kuba added a comment to D7793: [web] Added edit button to the Tooltip.

These //TODO comments make it hard to review this stack because now the diffs depend on both previous and future diffs. This diff in particular seem like it would be easy to merge with D7824. Is there a reason why you did it this way?

May 17 2023, 3:09 AM
michal requested review of D7848: [keyserver] Validate fetchPrimaryInviteLinksResponder output.
May 17 2023, 2:50 AM
marcin added inline comments to D7815: Send encrypted notifications to iOS devices.
May 17 2023, 2:12 AM
michal added a comment to D7807: [keyserver] Validate link responders.

Sorry, I should have noticed that during rebase, I will put up a diff with the validators.

May 17 2023, 1:55 AM
tomek added inline comments to D7762: [lib] Introduce a new permission for managing invite links.
May 17 2023, 1:51 AM
tomek added inline comments to D7730: [native] Create a modal where invite links are displayed.
May 17 2023, 1:46 AM
tomek added a comment to D7807: [keyserver] Validate link responders.

@michal are you planning to write validators for fetchPrimaryInviteLinksResponder? I guess it should be done during the rebase.

May 17 2023, 1:35 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7807: [keyserver] Validate link responders.
May 17 2023, 1:29 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM72310720eb50: [keyserver] Validate link responders (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[keyserver] Validate link responders
May 17 2023, 1:29 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7806: [keyserver] Validate notifications.
May 17 2023, 1:29 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM7c7b43562c94: [keyserver] Validate notifications (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[keyserver] Validate notifications
May 17 2023, 1:29 AM
Michal Gniadek <michal.gniadek@swmansion.com> closed D7805: [keyserver] Use platform details in validateOutput.
May 17 2023, 1:28 AM
Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMaee0437970b7: [keyserver] Use platform details in validateOutput (authored by Michal Gniadek <michal.gniadek@swmansion.com>).
[keyserver] Use platform details in validateOutput
May 17 2023, 1:28 AM
tomek added inline comments to D7839: [landing] introduce new header elements to header component.
May 17 2023, 1:24 AM

May 16 2023

atul accepted D7846: [native] Add loading spinner to RegistrationButton loading variant.
May 16 2023, 3:13 PM
atul accepted D7845: [native] Introduce RegistrationContainer to handle SafeAreaView.

Looks good

May 16 2023, 3:13 PM
atul accepted D7844: [native] Add SIWEPanel to ConnectEthereum screen.
May 16 2023, 3:12 PM
atul accepted D7843: [native] Split onClosing and onClosed params to SIWEPanel.
May 16 2023, 3:11 PM
atul closed D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission.
May 16 2023, 3:09 PM
atul committed rCOMM3fdb12d33cde: [web] Call `create_thread` from `CommunityCreationModal` on form submission (authored by atul).
[web] Call `create_thread` from `CommunityCreationModal` on form submission
May 16 2023, 3:09 PM
atul updated the diff for D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission.

ladn

May 16 2023, 3:09 PM
atul updated the diff for D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission.

address feedback

May 16 2023, 2:49 PM
varun accepted D7801: [Tunnelbroker] Remove usages of unwrap and expect.
May 16 2023, 2:43 PM
atul added inline comments to D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission.
May 16 2023, 2:10 PM
ashoat accepted D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission.
May 16 2023, 1:32 PM
atul updated the test plan for D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission.
May 16 2023, 1:05 PM
atul published D7847: [web] Call `create_thread` from `CommunityCreationModal` on form submission for review.
May 16 2023, 1:02 PM
ashoat requested review of D7846: [native] Add loading spinner to RegistrationButton loading variant.
May 16 2023, 12:59 PM
kamil closed D7842: [lib] fix pinned content for non-media messages.
May 16 2023, 12:48 PM
kamil committed rCOMM7b3dc8969c6d: [lib] fix pinned content for non-media messages (authored by kamil).
[lib] fix pinned content for non-media messages
May 16 2023, 12:48 PM
kamil added inline comments to D7842: [lib] fix pinned content for non-media messages.
May 16 2023, 12:47 PM
ashoat requested review of D7845: [native] Introduce RegistrationContainer to handle SafeAreaView.
May 16 2023, 12:43 PM
ashoat requested review of D7844: [native] Add SIWEPanel to ConnectEthereum screen.
May 16 2023, 12:28 PM
ashoat requested review of D7843: [native] Split onClosing and onClosed params to SIWEPanel.
May 16 2023, 12:20 PM
ashoat closed D7841: [native] Factor out loading spinner from SIWEPanel.
May 16 2023, 12:01 PM
ashoat committed rCOMM318b4a97c7c5: [native] Factor out loading spinner from SIWEPanel (authored by ashoat).
[native] Factor out loading spinner from SIWEPanel
May 16 2023, 12:01 PM
ashoat closed D7840: [native] Make SIWEPanel more generic.
May 16 2023, 12:01 PM
ashoat committed rCOMMa3a99101985b: [native] Make SIWEPanel more generic (authored by ashoat).
[native] Make SIWEPanel more generic
May 16 2023, 12:01 PM
michal requested changes to D7793: [web] Added edit button to the Tooltip.

These //TODO comments make it hard to review this stack because now the diffs depend on both previous and future diffs. This diff in particular seem like it would be easy to merge with D7824. Is there a reason why you did it this way?

May 16 2023, 11:05 AM
michal added inline comments to D7794: [web] Add new edit message provider.
May 16 2023, 11:03 AM
michal requested changes to D7823: [web] Added EditTextMessage component.
May 16 2023, 11:01 AM
michal accepted D7822: [web] Added ChatInputTextArea component.
May 16 2023, 11:01 AM
ashoat requested changes to D7815: Send encrypted notifications to iOS devices.
May 16 2023, 10:09 AM
ashoat accepted D7814: Implement method in NSE to decrypt notification.
May 16 2023, 10:03 AM
ashoat accepted D7813: Implement function to encrypt relevant parts of iOS notification.

One request inline; please address before landing, or feel free to re-request review if you disagree or if I'm missing something

May 16 2023, 9:56 AM
ashoat accepted D7631: Implement utilities and database query wrapper to create new olm session on eht keyserver side.
May 16 2023, 9:52 AM
ashoat added inline comments to D7730: [native] Create a modal where invite links are displayed.
May 16 2023, 9:48 AM
michal added inline comments to D7808: [keyserver] Convert upload responders.
May 16 2023, 9:47 AM
atul resigned from D7815: Send encrypted notifications to iOS devices.
May 16 2023, 9:44 AM
ashoat added a comment to D7789: [native] Introduced new types for Reanimated.

I was asking for links (hyperlinks) to the TypeScript types. In a previous comment I had requested:

May 16 2023, 9:44 AM
atul added inline comments to D7814: Implement method in NSE to decrypt notification.
May 16 2023, 9:40 AM
atul resigned from D7814: Implement method in NSE to decrypt notification.
May 16 2023, 9:39 AM
atul resigned from D7813: Implement function to encrypt relevant parts of iOS notification.
May 16 2023, 9:39 AM
atul resigned from D7631: Implement utilities and database query wrapper to create new olm session on eht keyserver side.

(feel free to add me back if there's something specific I can be helpful w/, don't have a ton of context here)

May 16 2023, 9:39 AM
michal updated the diff for D7805: [keyserver] Use platform details in validateOutput.

Use FUTURE_CODE_VERSION

May 16 2023, 9:36 AM
atul accepted D7765: [native] Add thumbHash prop to image components.

Sweet, thanks for addressing feedback!

May 16 2023, 9:36 AM
atul accepted D7841: [native] Factor out loading spinner from SIWEPanel.
May 16 2023, 9:34 AM
atul accepted D7840: [native] Make SIWEPanel more generic.
May 16 2023, 9:26 AM
marcin requested review of D7815: Send encrypted notifications to iOS devices.
May 16 2023, 9:04 AM
marcin requested review of D7814: Implement method in NSE to decrypt notification.
May 16 2023, 9:03 AM
tomek updated the diff for D7733: [native] Display a button and navigate to invite links if they are present.

Select action sheet theme

May 16 2023, 9:01 AM
atul accepted D7839: [landing] introduce new header elements to header component.

I don't want to request changes and block this diff, but very extremely strongly feel that we should use the existing and well understood h1 -> h6 system of categorizing text styles instead of rolling our own that "acts in parallel."

May 16 2023, 8:45 AM
Harbormaster failed remote builds in B19410: Diff 26553 for D7797: Implement olm session updater that has encrypting functionality!
May 16 2023, 8:42 AM
tomek updated the summary of D7730: [native] Create a modal where invite links are displayed.
May 16 2023, 8:39 AM
marcin updated the diff for D7813: Implement function to encrypt relevant parts of iOS notification.
  1. Validate every notification field before encryption attempt
  2. Encrypt more fields in notification payload
May 16 2023, 8:39 AM
tomek updated the summary of D7733: [native] Display a button and navigate to invite links if they are present.
May 16 2023, 8:39 AM
marcin updated the diff for D7797: Implement olm session updater that has encrypting functionality.

Allow to pass discionary of messages to encrypt. This API is more robust

May 16 2023, 8:38 AM
marcin updated the diff for D7796: Implement methods in NotificationsCryptoModule to decrypt data.

Remove unecessary 'matchInboundSession' method

May 16 2023, 8:37 AM
marcin updated the diff for D7631: Implement utilities and database query wrapper to create new olm session on eht keyserver side.
  1. Refactor code
  2. Introduce olm encrypted message types and use it durong session creation
May 16 2023, 8:36 AM
atul attached a referenced file: F541269: 661fe7.png.
May 16 2023, 8:35 AM
atul accepted D7842: [lib] fix pinned content for non-media messages.
May 16 2023, 8:35 AM
tomek updated the diff for D7733: [native] Display a button and navigate to invite links if they are present.

Use new navigation structure

May 16 2023, 8:34 AM
marcin updated the diff for D7570: Implement prekey lifecycle on the keyserver.

Adjust to new unpublished_prekey implementation

May 16 2023, 8:34 AM
marcin updated the diff for D7381: Implement prekey lifecycle in `CryptoModule`..

Adjust to new olm unpublished_prekey implementation

May 16 2023, 8:33 AM
tomek updated the diff for D7730: [native] Create a modal where invite links are displayed.

Update the approach - use stack inside modal

May 16 2023, 8:32 AM
kamil published D7842: [lib] fix pinned content for non-media messages for review.
May 16 2023, 8:08 AM
atul accepted D7835: [landing] update header strucutre to use flexbox over grid.

Flexbox is a bit more simple to use/understand

May 16 2023, 8:01 AM
ashoat requested review of D7841: [native] Factor out loading spinner from SIWEPanel.
May 16 2023, 7:17 AM
kuba updated the diff for D7837: [web] Added FocusTrap for modals.

Adressed review

May 16 2023, 7:02 AM
kuba added a comment to D7789: [native] Introduced new types for Reanimated.

Can you link the TypeScript types you used as inspiration? It will make review a lot easier

May 16 2023, 6:58 AM
kuba updated the diff for D7791: [native] Added animation to the highlight of edited message.

Removed empty line

May 16 2023, 6:49 AM
kuba updated the diff for D7822: [web] Added ChatInputTextArea component.

Change to function component

May 16 2023, 6:46 AM
ashoat requested review of D7840: [native] Make SIWEPanel more generic.
May 16 2023, 6:43 AM
ginsu requested review of D7839: [landing] introduce new header elements to header component.
May 16 2023, 6:27 AM
kuba added inline comments to D7822: [web] Added ChatInputTextArea component.
May 16 2023, 6:16 AM
ashoat added inline comments to D7837: [web] Added FocusTrap for modals.
May 16 2023, 6:13 AM
ashoat added inline comments to D7823: [web] Added EditTextMessage component.
May 16 2023, 6:07 AM
ashoat requested changes to D7775: [native] Use MessageSearchContent.

since hooks cannot be called conditionally

May 16 2023, 6:04 AM
kuba requested review of D7838: [web] Disabled auto focus on overlay when entering edit mode.
May 16 2023, 6:03 AM
kuba requested review of D7837: [web] Added FocusTrap for modals.
May 16 2023, 6:00 AM
ashoat accepted D7803: [keyserver] Add thumbhash to upload endpoints.
May 16 2023, 6:00 AM
ginsu updated subscribers of D7835: [landing] update header strucutre to use flexbox over grid.
May 16 2023, 5:59 AM