Rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 17 2023
Rebase
Refactor
Added useMemo to modalOverlay
Rebase
Changed to the function component, addressed review
In D7793#232559, @michal wrote:These //TODO comments make it hard to review this stack because now the diffs depend on both previous and future diffs. This diff in particular seem like it would be easy to merge with D7824. Is there a reason why you did it this way?
Sorry, I should have noticed that during rebase, I will put up a diff with the validators.
@michal are you planning to write validators for fetchPrimaryInviteLinksResponder? I guess it should be done during the rebase.
May 16 2023
Looks good
ladn
address feedback
These //TODO comments make it hard to review this stack because now the diffs depend on both previous and future diffs. This diff in particular seem like it would be easy to merge with D7824. Is there a reason why you did it this way?
One request inline; please address before landing, or feel free to re-request review if you disagree or if I'm missing something
I was asking for links (hyperlinks) to the TypeScript types. In a previous comment I had requested:
(feel free to add me back if there's something specific I can be helpful w/, don't have a ton of context here)
Use FUTURE_CODE_VERSION
Sweet, thanks for addressing feedback!
Select action sheet theme
I don't want to request changes and block this diff, but very extremely strongly feel that we should use the existing and well understood h1 -> h6 system of categorizing text styles instead of rolling our own that "acts in parallel."
- Validate every notification field before encryption attempt
- Encrypt more fields in notification payload
Allow to pass discionary of messages to encrypt. This API is more robust
Remove unecessary 'matchInboundSession' method
- Refactor code
- Introduce olm encrypted message types and use it durong session creation
Use new navigation structure
Adjust to new unpublished_prekey implementation
Adjust to new olm unpublished_prekey implementation
Update the approach - use stack inside modal
Flexbox is a bit more simple to use/understand
Adressed review
In D7789#232336, @ashoat wrote:Can you link the TypeScript types you used as inspiration? It will make review a lot easier
Removed empty line
Change to function component
since hooks cannot be called conditionally