Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Thu, Apr 25

will accepted D11783: [terraform] enable debug logs by default on staging.

Thu, Apr 25, 11:32 AM

ashoat committed rCOMM137b4e7c1f85: [web][keyserver] codeVersion -> 80 (authored by ashoat).

[web][keyserver] codeVersion -> 80

Thu, Apr 25, 11:30 AM

varun requested review of D11783: [terraform] enable debug logs by default on staging.

Thu, Apr 25, 11:26 AM

ashoat added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Thu, Apr 25, 11:19 AM

ashoat added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Thu, Apr 25, 11:18 AM

ashoat requested changes to D11780: [keyserver] Fix sending a user cookie when olm session creation failed.

I can review this one, as I'm most familiar with the code. General direction makes sense, but I have some concerns

Thu, Apr 25, 11:16 AM

ginsu added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Thu, Apr 25, 11:03 AM

ashoat updated the diff for D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.

Rebase

Thu, Apr 25, 10:52 AM

ashoat updated the diff for D11768: [lib][native][web] Introduce useWalletLogIn hook.

Lint fix following rebase

Thu, Apr 25, 10:51 AM

ashoat resigned from D11782: Let the user skip backup message generation and record it in alert store.

Resigning to let @ginsu review the alert parts. Overall looks good to me, but I think the skippedByUser state can be removed. @marcin – in case you disagree with that, can you re-add me (if possible) or just delay landing until I can confirm that it's good to land?

Thu, Apr 25, 10:45 AM

marcin requested review of D11782: Let the user skip backup message generation and record it in alert store.

Thu, Apr 25, 10:34 AM

Harbormaster failed remote builds in B28474: Diff 39502 for D11769: [lib] Don't set dataLoaded on authoritative keyserver auth!

Thu, Apr 25, 10:18 AM

Harbormaster failed remote builds in B28473: Diff 39501 for D11768: [lib][native][web] Introduce useWalletLogIn hook!

Thu, Apr 25, 10:18 AM

atul added a comment to D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.

In D11754#337417, @tomek wrote:

Will test generally at end to make sure things work as expected.

Is this something that will be done later in the stack?

Thu, Apr 25, 10:13 AM

ashoat updated the diff for D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.

Rebase

Thu, Apr 25, 10:04 AM

ashoat updated the diff for D11768: [lib][native][web] Introduce useWalletLogIn hook.

Rebase

Thu, Apr 25, 10:03 AM

ashoat updated the diff for D11766: [lib][native] Defer saving user credentials until successful auth.

Rebase

Thu, Apr 25, 10:03 AM

ashoat updated the diff for D11765: [lib][native][web] Introduce usePasswordLogIn hook.

waiting_for_identity_registration -> waiting_for_identity_login_in_redux
Add a check that step is inactive in order to avoid triggering auth multiple times

Thu, Apr 25, 9:59 AM

ashoat updated the diff for D11763: [native] Auth with authoritative keyserver directly from registration flow.

Suffix step names with _in_redux

Thu, Apr 25, 9:55 AM

marcin closed D11779: Add missing privacy API declarations and upgrade MMKV.

Thu, Apr 25, 9:45 AM

marcin committed rCOMMd1adda5d6bd8: Add missing privacy API declarations and upgrade MMKV (authored by marcin).

Add missing privacy API declarations and upgrade MMKV

Thu, Apr 25, 9:45 AM

marcin updated the diff for D11779: Add missing privacy API declarations and upgrade MMKV.

rebase before landing

Thu, Apr 25, 9:06 AM

inka closed D11760: [web] Fix missing relationship buttons.

Thu, Apr 25, 8:46 AM

inka committed rCOMMfa2cd2e93e24: [web] Fix missing relationship buttons (authored by inka).

[web] Fix missing relationship buttons

Thu, Apr 25, 8:46 AM

inka closed D11759: [lib][native] Stop persisting CSAT.

Thu, Apr 25, 8:43 AM

inka committed rCOMM35764971478c: [lib][native] Stop persisting CSAT (authored by inka).

[lib][native] Stop persisting CSAT

Thu, Apr 25, 8:43 AM

inka closed D11738: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to native.

Thu, Apr 25, 8:43 AM

inka committed rCOMMa05e97f0976b: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to… (authored by inka).

[lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to…

Thu, Apr 25, 8:43 AM

inka closed D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.

Thu, Apr 25, 8:42 AM

inka committed rCOMM3a63c9460ff0: [lib][native] Only reduce CSAT on setAccessTokenActionType (authored by inka).

[lib][native] Only reduce CSAT on setAccessTokenActionType

Thu, Apr 25, 8:42 AM

marcin requested review of D11781: Move MissingRegistrationDataHandler to NavigationHandler.

Thu, Apr 25, 8:37 AM

inka abandoned D11141: [IGNORE] Client hacks for testing multiple keyservers.

Thu, Apr 25, 8:32 AM

inka added a comment to D11760: [web] Fix missing relationship buttons.

In D11760#337835, @tomek wrote:

Is native also affected by this bug?

Thu, Apr 25, 8:28 AM

inka requested review of D11780: [keyserver] Fix sending a user cookie when olm session creation failed.

Thu, Apr 25, 8:25 AM

ashoat added inline comments to D11141: [IGNORE] Client hacks for testing multiple keyservers.

Thu, Apr 25, 8:11 AM

ashoat added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Thu, Apr 25, 8:08 AM

ashoat closed D11771: [native] Don't refetch nonce from identity after identity auth.

Thu, Apr 25, 8:03 AM

ashoat committed rCOMM7ad3d18e3433: [native] Don't refetch nonce from identity after identity auth (authored by ashoat).

[native] Don't refetch nonce from identity after identity auth

Thu, Apr 25, 8:03 AM

ashoat accepted D11779: Add missing privacy API declarations and upgrade MMKV.

Thu, Apr 25, 8:01 AM

ashoat closed D11770: [keyserver] Print exception that causes failed_to_retrieve_inbound_keys.

Thu, Apr 25, 7:55 AM

ashoat committed rCOMM05c178babeb7: [keyserver] Print exception that causes failed_to_retrieve_inbound_keys (authored by ashoat).

[keyserver] Print exception that causes failed_to_retrieve_inbound_keys

Thu, Apr 25, 7:55 AM

tomek accepted D11760: [web] Fix missing relationship buttons.

Is native also affected by this bug?

Thu, Apr 25, 7:17 AM

tomek accepted D11759: [lib][native] Stop persisting CSAT.

Thu, Apr 25, 7:05 AM

tomek accepted D11776: [lib] move farcaster types to dedicated file.

Thu, Apr 25, 7:03 AM

tomek accepted D11775: [lib] introduce useCreateOrUpdateFarcasterChannelTag.

Thu, Apr 25, 7:02 AM

tomek accepted D11774: [lib] introduce createOrUpdateFarcasterChannelTagActionTypes.

Thu, Apr 25, 7:00 AM

tomek requested changes to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Thu, Apr 25, 6:58 AM

tomek accepted D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.

Thu, Apr 25, 6:54 AM

tomek accepted D11771: [native] Don't refetch nonce from identity after identity auth.

Thu, Apr 25, 6:44 AM

marcin requested review of D11779: Add missing privacy API declarations and upgrade MMKV.

Thu, Apr 25, 6:24 AM

ashoat added inline comments to D11763: [native] Auth with authoritative keyserver directly from registration flow.

Thu, Apr 25, 6:04 AM

tomek closed D11758: [lib] Bump invite link accept timeout.

Thu, Apr 25, 6:01 AM

tomek committed rCOMMe959aefe3335: [lib] Bump invite link accept timeout (authored by tomek).

[lib] Bump invite link accept timeout

Thu, Apr 25, 6:01 AM

ashoat added inline comments to D11766: [lib][native] Defer saving user credentials until successful auth.

Thu, Apr 25, 5:59 AM

ashoat added inline comments to D11765: [lib][native][web] Introduce usePasswordLogIn hook.

Thu, Apr 25, 5:55 AM

ashoat added inline comments to D11763: [native] Auth with authoritative keyserver directly from registration flow.

Thu, Apr 25, 5:53 AM

inka updated the diff for D11760: [web] Fix missing relationship buttons.

Make the code safer

Thu, Apr 25, 5:52 AM

ashoat added inline comments to D11763: [native] Auth with authoritative keyserver directly from registration flow.

Thu, Apr 25, 5:47 AM

ashoat added inline comments to D11761: [lib] Extract useRawKeyserverAuth.

Thu, Apr 25, 5:45 AM

kamil added inline comments to D11723: [SQLite] add queries to decrypted messages table.

Thu, Apr 25, 5:33 AM

kamil added inline comments to D11722: [SQLite] add table to persist decrypted messages.

Thu, Apr 25, 5:31 AM

inka added inline comments to D11766: [lib][native] Defer saving user credentials until successful auth.

Thu, Apr 25, 3:57 AM

inka added inline comments to D11765: [lib][native][web] Introduce usePasswordLogIn hook.

Thu, Apr 25, 3:47 AM

inka added inline comments to D11763: [native] Auth with authoritative keyserver directly from registration flow.

Thu, Apr 25, 3:21 AM

inka accepted D11762: [lib] Don't try authing to authoritative keyserver from KeyserverConnectionHandler.

Thu, Apr 25, 2:28 AM

inka accepted D11761: [lib] Extract useRawKeyserverAuth.

Thu, Apr 25, 2:22 AM

bartek closed D11687: [identity] Allow UpdateDeviceList RPC to remove devices.

Thu, Apr 25, 12:37 AM

bartek committed rCOMMe69f415a5bd8: [identity] Allow UpdateDeviceList RPC to remove devices (authored by bartek).

[identity] Allow UpdateDeviceList RPC to remove devices

Thu, Apr 25, 12:37 AM

bartek closed D11686: [identity] Extract device list verification to separate func.

Thu, Apr 25, 12:37 AM

bartek committed rCOMM1c6533aa4886: [identity] Extract device list verification to separate func (authored by bartek).

[identity] Extract device list verification to separate func

Thu, Apr 25, 12:37 AM

bartek closed D11685: [identity] Add device list timestamp verification.

Thu, Apr 25, 12:37 AM

bartek committed rCOMM34d9d1efac30: [identity] Add device list timestamp verification (authored by bartek).

[identity] Add device list timestamp verification

Thu, Apr 25, 12:37 AM

bartek accepted D11770: [keyserver] Print exception that causes failed_to_retrieve_inbound_keys.

Thu, Apr 25, 12:11 AM

bartek updated the diff for D11687: [identity] Allow UpdateDeviceList RPC to remove devices.

Address feedback

Thu, Apr 25, 12:08 AM

Wed, Apr 24

ginsu requested review of D11776: [lib] move farcaster types to dedicated file.

Wed, Apr 24, 11:56 PM

ginsu requested review of D11775: [lib] introduce useCreateOrUpdateFarcasterChannelTag.

Wed, Apr 24, 11:54 PM

ginsu requested review of D11774: [lib] introduce createOrUpdateFarcasterChannelTagActionTypes.

Wed, Apr 24, 11:48 PM

ginsu requested review of D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

Wed, Apr 24, 11:40 PM

ginsu requested review of D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.

Wed, Apr 24, 11:29 PM

atul closed D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.

Wed, Apr 24, 6:58 PM

atul closed D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.

Wed, Apr 24, 6:58 PM

atul committed rCOMMb6c3358bdf37: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).

[web] Replace `threadHasPermission` with `useThreadHasPermission` in…

Wed, Apr 24, 6:58 PM

atul closed D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.

Wed, Apr 24, 6:58 PM

atul committed rCOMM26e18f854825: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).

[web] Replace `threadHasPermission` with `useThreadHasPermission` in…

Wed, Apr 24, 6:58 PM

atul committed rCOMM9c19d63b2e5b: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).

[web] Replace `threadHasPermission` with `useThreadHasPermission` in…

Wed, Apr 24, 6:58 PM

atul closed D11749: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.

Wed, Apr 24, 6:58 PM

atul closed D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.

Wed, Apr 24, 6:58 PM

atul committed rCOMM9b9964fa6b48: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).

[web] Replace `threadHasPermission` with `useThreadHasPermission` in…

Wed, Apr 24, 6:58 PM

atul committed rCOMM572a486f5101: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry` (authored by atul).

[web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`

Wed, Apr 24, 6:58 PM

atul closed D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.

Wed, Apr 24, 6:58 PM

atul committed rCOMM9f41d12aef51: [web] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul).

[web] Replace `threadHasPermission` with `useThreadHasPermission` in…

Wed, Apr 24, 6:58 PM

ashoat added inline comments to D11760: [web] Fix missing relationship buttons.

Wed, Apr 24, 6:32 PM

ashoat accepted D11757: [SIWE] Differentiate content for social proof and backup message..

Wed, Apr 24, 6:29 PM

ashoat requested review of D11771: [native] Don't refetch nonce from identity after identity auth.

Wed, Apr 24, 1:41 PM

ashoat requested review of D11770: [keyserver] Print exception that causes failed_to_retrieve_inbound_keys.

Wed, Apr 24, 1:35 PM

ashoat requested review of D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.

Wed, Apr 24, 1:26 PM

atul updated the diff for D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.

rebase and land

Wed, Apr 24, 1:23 PM

atul updated the diff for D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.

land

Wed, Apr 24, 1:23 PM

ashoat requested review of D11768: [lib][native][web] Introduce useWalletLogIn hook.

Wed, Apr 24, 1:22 PM

atul updated the diff for D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.

land

Wed, Apr 24, 1:21 PM