Page MenuHomePhabricator
Feed All Stories

Jul 16 2024

ashoat updated the diff for D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.

Rebase

Jul 16 2024, 4:11 AM
ashoat updated the diff for D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.

Rebase

Jul 16 2024, 4:10 AM
ashoat updated the diff for D12739: [native] Introduce getRelatedMessages to CommCoreModule.

Rebase

Jul 16 2024, 4:09 AM
ashoat updated the diff for D12738: [web] Introduce getRelatedMessages to shared worker.

Rebase

Jul 16 2024, 4:08 AM
tomek accepted D12760: [SQLite] Factor out SQLiteQueryExecutor::processMessagesResults.
Jul 16 2024, 3:59 AM
tomek accepted D12759: [SQLite] Add target_message generated column and index.

Nice!

Jul 16 2024, 3:45 AM
marcin closed D12774: [terraform] bump staging identity to 0.30-staging.
Jul 16 2024, 3:41 AM
marcin committed rCOMMb13871d5c6a9: [terraform] bump staging identity to 0.30-staging (authored by marcin).
[terraform] bump staging identity to 0.30-staging
Jul 16 2024, 3:41 AM
kamil accepted D12743: Add a new field to OutboundP2PMessage.
Jul 16 2024, 3:40 AM
bartek accepted D12774: [terraform] bump staging identity to 0.30-staging.
Jul 16 2024, 3:35 AM
tomek requested review of D12743: Add a new field to OutboundP2PMessage.
Jul 16 2024, 3:34 AM
marcin published D12774: [terraform] bump staging identity to 0.30-staging for review.
Jul 16 2024, 3:32 AM
tomek accepted D12694: [native](web) Add message_search fts5 table.
Jul 16 2024, 3:20 AM
kamil accepted D12742: [SQLite] Add a new column to outbound_p2p_messages table.
Jul 16 2024, 3:08 AM
kamil added a comment to D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling.

We should also be able to get rid of the web-specific getOlmPersistAccountDataWeb and just use getOlmPersistAccountData on web. I'll create a follow-up task for this before landing.

Jul 16 2024, 2:57 AM
kamil accepted D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling.

Awesome!

Jul 16 2024, 2:55 AM
kamil published D12773: [Tunnelbroker] simplify retrieving device token for review.
Jul 16 2024, 2:48 AM
kamil published D12772: [lib] implement sending FCM notifs using Tunnelbroker for review.
Jul 16 2024, 2:48 AM
kamil updated the test plan for D12770: [Tunnelbroker][lib] add FCM notif message type.
Jul 16 2024, 2:48 AM
kamil published D12771: [Tunnelbroker] implement sending FCM notifs by client for review.
Jul 16 2024, 2:47 AM
kamil published D12770: [Tunnelbroker][lib] add FCM notif message type for review.
Jul 16 2024, 2:45 AM
kamil published D12769: [Tunnelbroker] implement sending FCM message for review.
Jul 16 2024, 2:44 AM
kamil published D12768: [Tunnelbroker] implement errors from FCM service for review.
Jul 16 2024, 2:42 AM
kamil published D12767: [Tunnelbroker] implement messages types to FCM service for review.
Jul 16 2024, 2:41 AM
kamil published D12766: [Tunnelbroker] implement FCM Access Token lifetime for review.
Jul 16 2024, 2:39 AM
kamil published D12765: [Tunnelbroker] implement requesting FCM access token using OAuth 2.0 for review.
Jul 16 2024, 2:38 AM
kamil published D12754: [Tunnelbroker] implement OAuth 2.0 JWT token encoding for review.
Jul 16 2024, 2:36 AM
kamil published D12753: [Tunnelbroker] implement creating FCM client for review.
Jul 16 2024, 2:25 AM
kamil published D12752: [Tunnelbroker] implement FCM config for review.
Jul 16 2024, 2:24 AM
kamil published D12751: [terraform] add FCM secrets config for review.
Jul 16 2024, 2:23 AM

Jul 15 2024

ashoat requested review of D12759: [SQLite] Add target_message generated column and index.
Jul 15 2024, 9:04 PM
Harbormaster failed remote builds in B30358: Diff 42320 for D12741: [lib] Process DMOperations when received from peers via Tunnelbroker!
Jul 15 2024, 8:59 PM
Harbormaster failed remote builds in B30356: Diff 42318 for D12740: [lib] Introduce getRelatedMessages to SQLiteAPI!
Jul 15 2024, 8:42 PM
Harbormaster failed remote builds in B30355: Diff 42317 for D12739: [native] Introduce getRelatedMessages to CommCoreModule!
Jul 15 2024, 8:35 PM
Harbormaster failed remote builds in B30354: Diff 42316 for D12738: [web] Introduce getRelatedMessages to shared worker!
Jul 15 2024, 8:26 PM
ashoat updated the diff for D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.

Rebase

Jul 15 2024, 7:59 PM
ashoat updated the diff for D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.

ESLint fix

Jul 15 2024, 7:59 PM
ashoat updated the diff for D12739: [native] Introduce getRelatedMessages to CommCoreModule.

Rebase

Jul 15 2024, 7:58 PM
ashoat updated the diff for D12738: [web] Introduce getRelatedMessages to shared worker.

ESLint fix

Jul 15 2024, 7:55 PM
Harbormaster failed remote builds in B30353: Diff 42315 for D12741: [lib] Process DMOperations when received from peers via Tunnelbroker!
Jul 15 2024, 7:53 PM
ashoat updated the diff for D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.

Rebase to rely on D12764

Jul 15 2024, 7:39 PM
Harbormaster failed remote builds in B30350: Diff 42312 for D12740: [lib] Introduce getRelatedMessages to SQLiteAPI!
Jul 15 2024, 7:31 PM
Harbormaster failed remote builds in B30349: Diff 42311 for D12739: [native] Introduce getRelatedMessages to CommCoreModule!
Jul 15 2024, 7:30 PM
ashoat requested review of D12760: [SQLite] Factor out SQLiteQueryExecutor::processMessagesResults.
Jul 15 2024, 7:29 PM
Harbormaster failed remote builds in B30348: Diff 42310 for D12738: [web] Introduce getRelatedMessages to shared worker!
Jul 15 2024, 7:26 PM
ashoat updated the diff for D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.

Rework into getRelatedMessages, which can be reused for rendering search results

Jul 15 2024, 7:14 PM
ashoat retitled D12739: [native] Introduce getRelatedMessages to CommCoreModule from [native] Introduce getRelatedMessages to CommCoreModule to [native] Introduce getRelatedMessages to CommCoreModule.
Jul 15 2024, 7:14 PM
ashoat updated the diff for D12739: [native] Introduce getRelatedMessages to CommCoreModule.

Rework into getRelatedMessages, which can be reused for rendering search results

Jul 15 2024, 7:14 PM
ashoat updated the diff for D12738: [web] Introduce getRelatedMessages to shared worker.

Rework into getRelatedMessages, which can be reused for rendering search results

Jul 15 2024, 7:14 PM
ashoat updated the diff for D12737: [SQLite] Introduce getRelatedMessages.

Rework into getRelatedMessages, which can be reused for rendering search results

Jul 15 2024, 7:13 PM
ashoat updated the summary of D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.
Jul 15 2024, 7:06 PM
ashoat retitled D12740: [lib] Introduce getRelatedMessages to SQLiteAPI from [lib] Introduce getLatestMessageEdit to SQLiteAPI to [lib] Introduce getRelatedMessages to SQLiteAPI.
Jul 15 2024, 7:04 PM
ashoat updated the test plan for D12737: [SQLite] Introduce getRelatedMessages.
Jul 15 2024, 7:03 PM
ashoat updated the summary of D12738: [web] Introduce getRelatedMessages to shared worker.
Jul 15 2024, 7:03 PM
ashoat retitled D12738: [web] Introduce getRelatedMessages to shared worker from [web] Introduce getRelatedMessages to shared worker to [web] Introduce getRelatedMessages to shared worker.
Jul 15 2024, 7:03 PM
ashoat updated the test plan for D12739: [native] Introduce getRelatedMessages to CommCoreModule.
Jul 15 2024, 7:03 PM
ashoat retitled D12739: [native] Introduce getRelatedMessages to CommCoreModule from [native] Introduce getLatestMessageEdit to CommCoreModule to [native] Introduce getRelatedMessages to CommCoreModule.
Jul 15 2024, 7:02 PM
ashoat retitled D12738: [web] Introduce getRelatedMessages to shared worker from [web] Introduce getLatestMessageEdit to shared worker to [web] Introduce getRelatedMessages to shared worker.
Jul 15 2024, 7:02 PM
ashoat updated the summary of D12737: [SQLite] Introduce getRelatedMessages.
Jul 15 2024, 7:02 PM
ashoat retitled D12737: [SQLite] Introduce getRelatedMessages from [SQLite] Introduce getLatestMessageEdit to [SQLite] Introduce getRelatedMessages.
Jul 15 2024, 7:02 PM
atul requested review of D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
Jul 15 2024, 6:52 PM
ashoat added a comment to D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling.

I ended up not needing this, since I'm replacing the getLatestMessageEdit API with a getRelatedMessages API that returns an array.

Jul 15 2024, 4:45 PM
atul published D12758: [lib] Introduce `memberInfoSansPermissionsValidator` and consume in `rawThreadInfoValidator` for review.
Jul 15 2024, 1:04 PM
atul requested review of D12756: [lib] Move `stripPermissionsFromMemberInfo` out of `...-types.js` file.
Jul 15 2024, 12:24 PM
Harbormaster failed remote builds in B30336: Diff 42298 for D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`!
Jul 15 2024, 11:58 AM
Harbormaster failed remote builds in B30335: Diff 42297 for D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`!
Jul 15 2024, 11:53 AM
atul requested review of D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.

Second: it looks like there's a Flow error here that doesn't show up in the parent diff. Any context?

Jul 15 2024, 11:50 AM
atul added a comment to D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.

First: is rawThreadInfoFromServerThreadInfo just for the shimming logic that handles old clients?

Jul 15 2024, 11:48 AM
atul updated the diff for D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

address ESLint issues

Jul 15 2024, 11:45 AM
atul published D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo` for review.
Jul 15 2024, 11:39 AM
ashoat added inline comments to D12677: Implement method to query identity service from the NSE.
Jul 15 2024, 8:45 AM
ashoat added inline comments to D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys.
Jul 15 2024, 8:43 AM
ashoat added a comment to D12693: [native][web] Add fts5 extension to SQLite.

I've made a release. Can you remove patches/@commapp+sqlcipher-amalgamation+4.5.5-d.patch here, and instead update the version in native/package.json to 4.5.5-e?

Jul 15 2024, 8:26 AM
marcin added inline comments to D12750: Implement inbound notif session creation from the NSE with race condition handling.
Jul 15 2024, 8:26 AM
ashoat added inline comments to D12742: [SQLite] Add a new column to outbound_p2p_messages table.
Jul 15 2024, 8:13 AM
marcin removed a reviewer for D12677: Implement method to query identity service from the NSE: tomek. marcin added 1 blocking reviewer(s) for D12677: Implement method to query identity service from the NSE: bartek.
Jul 15 2024, 8:09 AM
inka requested review of D12694: [native](web) Add message_search fts5 table.
Jul 15 2024, 8:09 AM
marcin removed a reviewer for D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys: tomek.
Jul 15 2024, 8:08 AM
marcin removed a reviewer for D12728: Implement Android HTTP call to identity to get notifs inbound keys: tomek.
Jul 15 2024, 8:08 AM
marcin removed a reviewer for D12748: Expose function to get notifs inbound keys to C++: tomek.
Jul 15 2024, 8:07 AM
ashoat added 1 blocking reviewer(s) for D12736: [web] add std::optional (C++) <-> undefined (JS) marshalling: kamil.

Making @kamil blocking based on @tomek's comment above.

Jul 15 2024, 8:07 AM
marcin added inline comments to D12750: Implement inbound notif session creation from the NSE with race condition handling.
Jul 15 2024, 7:57 AM
marcin updated the diff for D12672: Implement utility functions to check if we have content or notif session with device.

Add error handling to CommCoreModule::isContentSessionInitialized

Jul 15 2024, 7:14 AM
marcin updated the diff for D12671: Implement notification encryption on web.

Rename ...DataContent... -> ...Data... to remove confusion around Conent keyword when dealing with notifs sessions

Jul 15 2024, 7:09 AM
marcin added inline comments to D12672: Implement utility functions to check if we have content or notif session with device.
Jul 15 2024, 6:13 AM
marcin requested review of D12750: Implement inbound notif session creation from the NSE with race condition handling.
Jul 15 2024, 6:02 AM
marcin added inline comments to D12670: Implement notification encryption on native.
Jul 15 2024, 5:40 AM
marcin requested review of D12748: Expose function to get notifs inbound keys to C++.
Jul 15 2024, 5:09 AM
ashoat added inline comments to D12739: [native] Introduce getRelatedMessages to CommCoreModule.
Jul 15 2024, 4:59 AM
inka closed D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.
Jul 15 2024, 4:23 AM
inka committed rCOMM6583cde4a78d: [keyserver] Fix keyserver allowing adding unauthorized users to chats (authored by inka).
[keyserver] Fix keyserver allowing adding unauthorized users to chats
Jul 15 2024, 4:23 AM
marcin added inline comments to D12739: [native] Introduce getRelatedMessages to CommCoreModule.
Jul 15 2024, 4:07 AM
tomek requested review of D12742: [SQLite] Add a new column to outbound_p2p_messages table.
Jul 15 2024, 3:54 AM
inka updated the diff for D12727: [keyserver] Fix keyserver allowing adding unauthorized users to chats.

Rename to containingThreadIDForPossibleMemberResolution

Jul 15 2024, 3:49 AM
inka added a comment to D12693: [native][web] Add fts5 extension to SQLite.

@ashoat I think we can make the release now. Should I do anything to make that possible?

Jul 15 2024, 3:46 AM
tomek planned changes to D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
Jul 15 2024, 3:41 AM
Harbormaster failed remote builds in B30316: Diff 42276 for D12719: Fix CORS issues with identity HTTP!
Jul 15 2024, 3:13 AM
marcin closed D12719: Fix CORS issues with identity HTTP.
Jul 15 2024, 3:04 AM
marcin committed rCOMM52aa37541e68: Fix CORS issues with identity HTTP (authored by marcin).
Fix CORS issues with identity HTTP
Jul 15 2024, 3:04 AM
marcin accepted D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.
Jul 15 2024, 2:58 AM