Feed All Stories
Jul 18 2024
Jul 18 2024
[web][keyserver] codeVersion -> 100
ashoat committed rCOMMb09298a6156a: [lib] Temporarily flip usingCommServicesAccessToken to false (authored by ashoat).
[lib] Temporarily flip usingCommServicesAccessToken to false
will added inline comments to D12731: [terraform] Migration script for for self-hosted keyserver.
ashoat committed rCOMMcc6992d6cef1: [lib] Stop requesting device lists for users that don't have them (authored by inka).
[lib] Stop requesting device lists for users that don't have them
ashoat added a comment to D12793: [lib] Stop requesting device lists for users that don't have them.
Landed this so we could include it in the next release
will updated the diff for D12731: [terraform] Migration script for for self-hosted keyserver.
feedback
ashoat committed rCOMM20f9d8910143: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
[native] codeVersion -> 374
ashoat committed rCOMM656eca26fa94: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
ashoat committed rCOMMb259101de55d: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false" (authored by ashoat).
Revert "[lib] Temporarily flip usingCommServicesAccessToken to false"
[native] codeVersion -> 373
[web][keyserver] codeVersion -> 99
ashoat committed rCOMM94e5c5d3fee4: [lib] Temporarily flip usingCommServicesAccessToken to false (authored by ashoat).
[lib] Temporarily flip usingCommServicesAccessToken to false
will added a comment to D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.
ashoat accepted D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.
Great work on this – looks really elegant!
varun committed rCOMM2bfca588eb95: [terraform] bump staging identity to 0.31-staging (authored by varun).
[terraform] bump staging identity to 0.31-staging
atul added a comment to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Here's the followup diff I promised: D12799
atul committed rCOMM3cd205451a32: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients (authored by atul).
[keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
land
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
atul committed rCOMMb84a90848053: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos` (authored by atul).
[lib] Introduce `stripMemberPermissionsFromRawThreadInfos`
varun requested review of D12798: [terraform] bump staging identity to 0.31-staging.
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
rebase before landing
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
rebase BEFORE re-removing any-cast
atul committed rCOMMc4089cbcf0e1: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo` (authored by atul).
[lib] Introduce `stripMemberPermissionsFromRawThreadInfo`
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
cherry-pick and land
varun committed rCOMMee487b75b248: [identity] increase connect timeout to 60 seconds (authored by varun).
[identity] increase connect timeout to 60 seconds
varun requested review of D12797: [identity] increase connect timeout to 60 seconds.
atul committed rCOMM9fa6dd9ff9b7: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread` (authored by atul).
[lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`
atul committed rCOMM0561cfa7544f: [lib] Change type of `ThinRawThreadInfo.members` from… (authored by atul).
[lib] Change type of `ThinRawThreadInfo.members` from…
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
cherry-pick and land
atul added a comment to D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
It's actually fine to land this as-is. If migration runs on RawThreadInfo that's already missing permissions, nothing will happen since stripPermissionsFromMemberInfo just won't really do anything:
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Harbormaster failed remote builds in B30482: Diff 42484 for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`!
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
rebase
atul updated the diff for D12789: [native] Introduce `native` migration to strip member permissions.
rebase
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
rebase
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
rebase
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
rebase
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
rebase
atul updated the diff for D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.
rebase
Can drop this now, thanks @marcin !
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
cherry-pick and land
atul committed rCOMM1dc8f0fe5186: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo` (authored by atul).
[lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`
atul updated the diff for D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`.
cherry-pick and land
atul committed rCOMM2ab735a4abc7: [lib] Deprecate `minimallyEncodeRawThreadInfo` (authored by atul).
[lib] Deprecate `minimallyEncodeRawThreadInfo`
atul updated the diff for D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.
cherry-pick and land
atul added a comment to D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.
This is purely rename diff, so safe to cherry-pick and land out of order.
atul added a comment to D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
Did you perhaps forget to remove the any-cast before diffing this up?
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
remove extraneous any-cast
ashoat requested changes to D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
varun committed rCOMM2f2e98ec0869: [terraform] Increase Identity memory to 2048 (authored by bartek).
[terraform] Increase Identity memory to 2048
varun updated the diff for D12792: [terraform] Increase Identity memory to 2048.
commandeer
varun commandeered D12792: [terraform] Increase Identity memory to 2048.
bartek is afk so i'm going to commandeer and land
ashoat added a comment to D12776: [lib] Generate P2P messages based on actions.
Thanks for all of the explanations above, those all make sense. @tomek and I discussed this in our 1:1 today and settled on keeping this approach, at least for now.
ashoat requested changes to D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.
Looks like D12784 has been landed, so this can be abandoned after you rebase
Thank you!!
inka updated the diff for D12783: [web] Add bindings for inserting into the search table.
Rename fix
inka requested review of D12796: [native] Add CommCoreModule code for inserting into the search table.
inka requested review of D12795: [native] Add message search store.
inka requested review of D12794: [native] Add MessageSearchStoreOperations.
tomek updated the diff for D12747: [lib] Enable automatic retries for some messages.
Shorthand
kamil added inline comments to D12770: [Tunnelbroker][lib] add FCM notif message type.
tomek added inline comments to D12745: [native][web] Introduce a method fetching messages by ID to SQLiteAPI.
tomek updated the diff for D12745: [native][web] Introduce a method fetching messages by ID to SQLiteAPI.
Update types and names
tomek added inline comments to D12744: [native][web] Add a method fetching messages by ID.
tomek updated the diff for D12744: [native][web] Add a method fetching messages by ID.
Rename
inka updated the test plan for D12793: [lib] Stop requesting device lists for users that don't have them.