Page MenuHomePhabricator
Feed All Stories

Jul 22 2024

inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Rebase

Jul 22 2024, 12:00 AM

Jul 21 2024

inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Rebase

Jul 21 2024, 11:59 PM
ashoat added inline comments to D12781: [lib] Reduce new PROCESS_DM_OPS action.
Jul 21 2024, 10:19 PM
ashoat updated the test plan for D12781: [lib] Reduce new PROCESS_DM_OPS action.
Jul 21 2024, 10:16 PM
ashoat updated the test plan for D12780: [lib] Introduce new PROCESS_DM_OPS action and dispatch from useProcessDMOperation.
Jul 21 2024, 10:16 PM
ashoat updated the test plan for D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.
Jul 21 2024, 10:16 PM
ashoat resigned from D12819: [identity] redact_sensitive_data config.

Looks good but would prefer somebody with Terraform / Rust experience reviewed

Jul 21 2024, 10:15 PM
ashoat accepted D12822: [terraform] bump staging identity to 0.32-staging.
Jul 21 2024, 10:10 PM
ashoat resigned from D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.

Generally makes sense to me, but would be good for one of the Rust people to review

Jul 21 2024, 10:09 PM
varun published D12832: [identity] modify get_all_user_details to return wallet addresses too for review.
Jul 21 2024, 8:54 PM
varun requested review of D12831: [identity] get all usernames and wallet addresses in get_all_usernames.
Jul 21 2024, 3:23 PM
varun requested review of D12830: [identity] check users table before reserved usernames table for user ID during wallet login.
Jul 21 2024, 1:38 PM
ashoat requested review of D12825: [lib] Turn on notifs by default for thick threads.
Jul 21 2024, 12:54 AM

Jul 20 2024

ashoat requested review of D12826: [native][web] Allow sending custom encrypted message via Tunnelbroker test interface.
Jul 20 2024, 11:08 PM
ashoat requested review of D12828: [lib] Make sure thick threads starts out with startReached.
Jul 20 2024, 10:20 PM
ashoat requested review of D12829: [lib] Specify messageID in sendTextMessageSpec.
Jul 20 2024, 10:20 PM
ashoat requested review of D12827: [lib] Reduce duplication in message-types.js.
Jul 20 2024, 9:58 PM
ashoat requested review of D12824: [keyserver][lib] Factor out joinThreadSubscription.
Jul 20 2024, 9:36 PM
ashoat requested review of D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.
Jul 20 2024, 7:27 PM
atul closed D12811: [native] Flip the switch to strip member permissions from `native`.
Jul 20 2024, 11:52 AM
atul committed rCOMMb7d5e9a1db09: [native] Flip the switch to strip member permissions from `native` (authored by atul).
[native] Flip the switch to strip member permissions from `native`
Jul 20 2024, 11:52 AM
ashoat accepted D12811: [native] Flip the switch to strip member permissions from `native`.
Jul 20 2024, 9:58 AM
Harbormaster failed remote builds in B30541: Diff 42586 for D12819: [identity] redact_sensitive_data config!
Jul 20 2024, 12:23 AM
Harbormaster failed remote builds in B30539: Diff 42584 for D12821: [terraform] make allowed_ip a list of valid ips!
Jul 20 2024, 12:09 AM
varun published D12822: [terraform] bump staging identity to 0.32-staging for review.
Jul 20 2024, 12:03 AM
varun requested review of D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.
Jul 20 2024, 12:03 AM
will closed D12821: [terraform] make allowed_ip a list of valid ips.
Jul 20 2024, 12:01 AM
will committed rCOMMe1239d588992: [terraform] make allowed_ip a list of valid ips (authored by will).
[terraform] make allowed_ip a list of valid ips
Jul 20 2024, 12:01 AM
varun updated the diff for D12819: [identity] redact_sensitive_data config.

env var should be string

Jul 20 2024, 12:01 AM
ashoat accepted D12821: [terraform] make allowed_ip a list of valid ips.
Jul 20 2024, 12:00 AM

Jul 19 2024

will published D12821: [terraform] make allowed_ip a list of valid ips for review.
Jul 19 2024, 11:59 PM
varun requested review of D12819: [identity] redact_sensitive_data config.
Jul 19 2024, 11:55 PM
varun abandoned D12818: [identity] remove user ID from "no device list" log.

abandoning in favor of D12819 and D12820

Jul 19 2024, 11:41 PM
will closed D12817: [terraform] upgrade self host image to 1.0.101.
Jul 19 2024, 11:22 PM
will closed D12815: [terraform] landing terraform config.
Jul 19 2024, 11:22 PM
will committed rCOMMcbe600f24166: [terraform] upgrade self host image to 1.0.101 (authored by will).
[terraform] upgrade self host image to 1.0.101
Jul 19 2024, 11:22 PM
will closed D12814: [terraform] webapp terraform config.
Jul 19 2024, 11:22 PM
will committed rCOMM15bcdda59137: [terraform] landing terraform config (authored by will).
[terraform] landing terraform config
Jul 19 2024, 11:22 PM
will committed rCOMMefb6e368088b: [terraform] webapp terraform config (authored by will).
[terraform] webapp terraform config
Jul 19 2024, 11:22 PM
will closed D12813: [terraform] add webapp, landing domains and rename keyserver domain variables.
Jul 19 2024, 11:22 PM
will committed rCOMM422c1c6bdb33: [terraform] add webapp, landing domains and rename keyserver domain variables (authored by will).
[terraform] add webapp, landing domains and rename keyserver domain variables
Jul 19 2024, 11:22 PM
will closed D12812: [terraform] run keyserver isolated from webapp and landing.
Jul 19 2024, 11:22 PM
will committed rCOMM105ddca5585b: [terraform] run keyserver isolated from webapp and landing (authored by will).
[terraform] run keyserver isolated from webapp and landing
Jul 19 2024, 11:22 PM
ashoat accepted D12818: [identity] remove user ID from "no device list" log.
Jul 19 2024, 10:58 PM
varun requested review of D12818: [identity] remove user ID from "no device list" log.
Jul 19 2024, 10:55 PM
ashoat accepted D12817: [terraform] upgrade self host image to 1.0.101.
Jul 19 2024, 10:20 PM
will requested review of D12817: [terraform] upgrade self host image to 1.0.101.
Jul 19 2024, 10:13 PM
ashoat accepted D12813: [terraform] add webapp, landing domains and rename keyserver domain variables.
Jul 19 2024, 10:10 PM
ashoat accepted D12815: [terraform] landing terraform config.

Same feedback as D12814

Jul 19 2024, 10:10 PM
ashoat updated subscribers of D12814: [terraform] webapp terraform config.

Don't love all the copy-paste here. Let's create a follow-up task to ask @bartek if there's a way to reduce it

Jul 19 2024, 10:10 PM
ashoat accepted D12814: [terraform] webapp terraform config.
Jul 19 2024, 10:01 PM
Harbormaster failed remote builds in B30534: Diff 42573 for D12816: Don't include .env files from self-host directory in Docker images!
Jul 19 2024, 9:06 PM
ashoat added a reverting change for rCOMM4f446cdf622e: [native] Temporary changes for staff release: rCOMMef01f2fbdb73: Revert "[native] Temporary changes for staff release".
Jul 19 2024, 9:03 PM
ashoat committed rCOMMef01f2fbdb73: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Jul 19 2024, 9:03 PM
ashoat committed rCOMM787710c803b4: [native] codeVersion -> 378 (authored by ashoat).
[native] codeVersion -> 378
Jul 19 2024, 9:03 PM
ashoat added a reverting change for rCOMM280b22427100: [lib] Temporarily flip usingCommServicesAccessToken to false: rCOMM07d73f8177c9: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false".
Jul 19 2024, 9:03 PM
ashoat committed rCOMM4f446cdf622e: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Jul 19 2024, 9:03 PM
ashoat committed rCOMM07d73f8177c9: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false" (authored by ashoat).
Revert "[lib] Temporarily flip usingCommServicesAccessToken to false"
Jul 19 2024, 9:03 PM
ashoat committed rCOMM2b6fd5af1171: [native] codeVersion -> 377 (authored by ashoat).
[native] codeVersion -> 377
Jul 19 2024, 9:03 PM
ashoat committed rCOMM1828c38a9e66: [web][keyserver] codeVersion -> 101 (authored by ashoat).
[web][keyserver] codeVersion -> 101
Jul 19 2024, 9:03 PM
ashoat committed rCOMM280b22427100: [lib] Temporarily flip usingCommServicesAccessToken to false (authored by ashoat).
[lib] Temporarily flip usingCommServicesAccessToken to false
Jul 19 2024, 9:03 PM
ashoat closed D12816: Don't include .env files from self-host directory in Docker images.
Jul 19 2024, 8:58 PM
ashoat committed rCOMMd5936957548b: Don't include .env files from self-host directory in Docker images (authored by ashoat).
Don't include .env files from self-host directory in Docker images
Jul 19 2024, 8:58 PM
will accepted D12816: Don't include .env files from self-host directory in Docker images.
Jul 19 2024, 8:57 PM
ashoat published D12816: Don't include .env files from self-host directory in Docker images for review.
Jul 19 2024, 8:56 PM
will published D12815: [terraform] landing terraform config for review.
Jul 19 2024, 8:49 PM
will closed D12810: [keyserver] run webapp, landing, and keyserver conditionally.
Jul 19 2024, 8:49 PM
will committed rCOMM083b66c6c741: [keyserver] run webapp, landing, and keyserver conditionally (authored by will).
[keyserver] run webapp, landing, and keyserver conditionally
Jul 19 2024, 8:49 PM
will published D12814: [terraform] webapp terraform config for review.
Jul 19 2024, 8:49 PM
will requested review of D12813: [terraform] add webapp, landing domains and rename keyserver domain variables.
Jul 19 2024, 8:49 PM
will updated the diff for D12810: [keyserver] run webapp, landing, and keyserver conditionally.

newline

Jul 19 2024, 8:48 PM
will closed D12808: [keyserver] remove unnecessary inviteResponder line in keyserver.js.
Jul 19 2024, 8:39 PM
will committed rCOMMc372d8492061: [keyserver] remove unnecessary inviteResponder line in keyserver.js (authored by will).
[keyserver] remove unnecessary inviteResponder line in keyserver.js
Jul 19 2024, 8:39 PM
ashoat accepted D12810: [keyserver] run webapp, landing, and keyserver conditionally.
Jul 19 2024, 8:32 PM
ashoat accepted D12812: [terraform] run keyserver isolated from webapp and landing.
Jul 19 2024, 8:30 PM
ashoat accepted D12808: [keyserver] remove unnecessary inviteResponder line in keyserver.js.

Looks like some context in D8255... web doesn't really need this route, landing definitely does, and it's not clear if it's needed at the root either. I think it's fine to remove given we'll be running landing on the apex domain

Jul 19 2024, 8:30 PM
ashoat added a reviewer for D12808: [keyserver] remove unnecessary inviteResponder line in keyserver.js: tomek.
Jul 19 2024, 8:27 PM
will requested review of D12812: [terraform] run keyserver isolated from webapp and landing.
Jul 19 2024, 5:37 PM
atul requested review of D12811: [native] Flip the switch to strip member permissions from `native`.
Jul 19 2024, 5:29 PM
atul closed D12789: [native] Introduce `native` migration to strip member permissions.
Jul 19 2024, 5:07 PM
atul committed rCOMM0748bce33c6f: [native] Introduce `native` migration to strip member permissions (authored by atul).
[native] Introduce `native` migration to strip member permissions
Jul 19 2024, 5:06 PM
atul updated the diff for D12789: [native] Introduce `native` migration to strip member permissions.

address feedback (any-cast stripMemberPermissionsFromRawThreadInfos instead of $FlowIgnore)

Jul 19 2024, 4:53 PM
atul closed D12799: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`.
Jul 19 2024, 4:37 PM
atul committed rCOMMd25e29a0be1e: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->… (authored by atul).
[lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->…
Jul 19 2024, 4:36 PM
atul updated the diff for D12799: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`.

rebase and land

Jul 19 2024, 4:28 PM
will requested review of D12810: [keyserver] run webapp, landing, and keyserver conditionally.
Jul 19 2024, 4:17 PM
varun requested review of D12809: [lib] add new selector and function to get own user's keyserver device ID.
Jul 19 2024, 2:34 PM
will requested review of D12808: [keyserver] remove unnecessary inviteResponder line in keyserver.js.
Jul 19 2024, 2:32 PM
tomek updated the diff for D12807: [lib] DMOperationSpec for edit operation.

Rename a file

Jul 19 2024, 1:34 PM
tomek updated the diff for D12806: [lib] DMOperationSpec for reaction operation.

Rename file

Jul 19 2024, 1:33 PM
tomek updated the diff for D12807: [lib] DMOperationSpec for edit operation.

Fix the types

Jul 19 2024, 1:21 PM
tomek requested review of D12806: [lib] DMOperationSpec for reaction operation.
Jul 19 2024, 1:19 PM
tomek requested review of D12807: [lib] DMOperationSpec for edit operation.
Jul 19 2024, 1:16 PM
varun requested review of D12805: [lib] introduce new device list function to replace keyserver device.
Jul 19 2024, 1:09 PM
tomek added inline comments to D12655: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.
Jul 19 2024, 12:50 PM
ashoat added inline comments to D12734: [lib] add device type to qr code URL.
Jul 19 2024, 10:14 AM
ashoat added a comment to D12795: [native] Add message search store.

Don't forget to add to CMake!

Jul 19 2024, 10:08 AM
tomek requested review of D12804: [native][web] Rename P2P messages methods.
Jul 19 2024, 8:55 AM
tomek added inline comments to D12745: [native][web] Introduce a method fetching messages by ID to SQLiteAPI.
Jul 19 2024, 8:38 AM
tomek closed D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
Jul 19 2024, 8:08 AM