Rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Dec 13 2024
Dec 13 2024
tomek added inline comments to D14149: [native] implement screen after secondary device is connected.
Dec 12 2024
Dec 12 2024
ashoat updated the summary of D13828: [lib] Only show reactions to viewer's messages in MessagePreview.
Rebase, introduce pageSize
Remove defaultNumItemsToDisplay, as it's no longer used in this file
Fix and rename
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM2df6c3842988: [terraform] Bump keyserver image to 1.0.146 (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[terraform] Bump keyserver image to 1.0.146
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM2cc1f075d305: Revert "[native] Temporary changes for staff release" (authored by Ashoat Tevosyan <ashoat@gmail.com>).
Revert "[native] Temporary changes for staff release"
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM2a46e6b48b72: [native] codeVersion -> 448 (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[native] codeVersion -> 448
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM361f61b97be7: [native] Temporary changes for staff release (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[native] Temporary changes for staff release
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMMc23658380189: [native] codeVersion -> 447 (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[native] codeVersion -> 447
Ashoat Tevosyan <ashoat@gmail.com> committed rCOMM3ce682a60a8b: [web][keyserver] codeVersion -> 146 (authored by Ashoat Tevosyan <ashoat@gmail.com>).
[web][keyserver] codeVersion -> 146
varun committed rCOMM459ec0313932: [keyserver][script] get IDs for community names (authored by varun).
[keyserver][script] get IDs for community names
Will defer to @tomek on this one – I think it's probably a better bet for him to gain the context on QRAuthContextProvider than for me
Rahul has a graphic almost ready for this! We can either amend it here, or handle it later if it takes a bit before he can deliver the final version.
Will defer to @tomek on this one – I think it's probably a better bet for him to gain the context on QRAuthContextProvider than for me
address feedback
Rahul has a graphic almost ready for this! We can either amend it here, or handle it later if it takes a bit before he can deliver the final version.
kamil published D14152: [native] implement screen when secondary device is not responding for review.
varun updated the diff for D13997: [native] update community drawer button to navigate to community joiner modal.
fix navigation param
varun updated the diff for D13997: [native] update community drawer button to navigate to community joiner modal.
address feedback
This is close, but requesting changes due to the volume of comments below
Passing back with some questions
Would appreciate @tomek's help in reviewing the QRAuthContext part... it's hard for me to track the whole flow and where connectingInProgress should be set
Thanks for explaining... not sure how I missed that. You'd think after 10 years of using Phabricator I'd be better at using it 😅
Thanks for sharing!
In D14098#393678, @ashoat wrote:Thanks for finding this. Just wondering – did you find out because something was broken through testing, or because you observed that Flow was printing an error when the code looked right?
angelika committed rCOMM470bb6f686d1: [lib] Check if device list exists instead of using userHasDeviceList() in… (authored by angelika).
[lib] Check if device list exists instead of using userHasDeviceList() in…
angelika committed rCOMMcb47dbdcae97: [lib] Don't created thin thread if call to identity server failed when adding… (authored by angelika).
[lib] Don't created thin thread if call to identity server failed when adding…
angelika committed rCOMMfa259c0d3023: [lib] Use useUsersSupportThickThreads() (with auxUserInfos) in… (authored by angelika).
[lib] Use useUsersSupportThickThreads() (with auxUserInfos) in…
angelika updated the diff for D14023: [lib] Don't created thin thread if call to identity server failed when adding friends.
Rebase and change type from ?boolean to boolean | void
angelika updated the diff for D14022: [lib] Check if device list exists instead of using userHasDeviceList() in useUsersSupportThickThreads().
Rebase
angelika updated the diff for D13938: [lib] Use useUsersSupportThickThreads() (with auxUserInfos) in useUpdateRelationships().
Rebase
Dec 11 2024
Dec 11 2024
address feedback
rewrite as a functional component
Fix
ashoat accepted D14134: [native] Move componentDidUpdate logic in MultimediaMessageMultimedia to functional component.
Accepting so I don't block you, but please make sure you've considered whether there's any risks associated with this effect potentially being run on mount
ashoat added inline comments to D14112: [native] Move render function from Tooltip to functional component.
Thank you for a detailed and thorough explanation!! You went really deep here, love it :)
Thanks for separating this out!
ashoat added inline comments to D14106: [native] Move tooltip height getter in Tooltip to functional component.
Similar feedback to prior diff: I think these getters can be replaced with the value itself. Feel free to do this all in one final diff in the stack if that's easier
Similar feedback to last diff: I think these getters can be replaced with the value itself
ashoat accepted D14103: [native] Migrate removeScreen listener in OverlayNavigator to Reanimated V2 API.
Great solution!