Page MenuHomePhorge
Feed All Stories

Apr 15 2025

tomek committed rCOMM8702a758cf22: [keyserver] Handle deleted messages when searching.
Apr 15 2025, 9:11 AM
tomek closed D14551: [lib] Don't show a deleted message in a preview.
Apr 15 2025, 9:11 AM
tomek committed rCOMM54653cd603ad: [web] Show a confirmation modal when deleting a message.
Apr 15 2025, 9:11 AM
tomek committed rCOMM71415e97d251: [lib] Don't show a deleted message in a preview.
Apr 15 2025, 9:11 AM
tomek closed D14550: [lib] Don't show a message deleting other message in a preview.
Apr 15 2025, 9:11 AM
tomek committed rCOMMca315ab5b492: [lib] Don't show a message deleting other message in a preview.
Apr 15 2025, 9:11 AM
tomek closed D14549: [keyserver] Handle unpinning deleted messages.
Apr 15 2025, 9:11 AM
tomek closed D14548: [native][web] Hide edit label and reactions of deleted messages.
Apr 15 2025, 9:11 AM
tomek committed rCOMMa24a7cb765f9: [keyserver] Handle unpinning deleted messages.
Apr 15 2025, 9:11 AM
tomek committed rCOMMa930bed31098: [native][web] Hide edit label and reactions of deleted messages.
Apr 15 2025, 9:11 AM
tomek closed D14547: [web] Disable all the actions for a deleted message.
Apr 15 2025, 9:11 AM
tomek closed D14546: [native] Update message height measurement logic to handle deleted messages.
Apr 15 2025, 9:11 AM
tomek committed rCOMM71fb511b2e08: [web] Disable all the actions for a deleted message.
Apr 15 2025, 9:11 AM
tomek committed rCOMM974d1dda7492: [native] Update message height measurement logic to handle deleted messages.
Apr 15 2025, 9:11 AM
tomek closed D14545: [native] Display a deleted message on native.
Apr 15 2025, 9:11 AM
tomek closed D14544: [web] Display a deleted message on web.
Apr 15 2025, 9:11 AM
tomek committed rCOMM741247862ce6: [native] Display a deleted message on native.
Apr 15 2025, 9:11 AM
tomek committed rCOMMe1027e8f6c24: [web] Display a deleted message on web.
Apr 15 2025, 9:11 AM
tomek closed D14542: [native][web] Show an option to delete a message.
Apr 15 2025, 9:11 AM
tomek closed D14543: [lib] Update chat selector to return an info telling if a message was deleted.
Apr 15 2025, 9:11 AM
tomek committed rCOMM98a55a09e68d: [lib] Update chat selector to return an info telling if a message was deleted.
Apr 15 2025, 9:11 AM
tomek closed D14541: [lib] Create a hook that can delete thin and thick messages.
Apr 15 2025, 9:11 AM
tomek committed rCOMMad759e247eee: [native][web] Show an option to delete a message.
Apr 15 2025, 9:11 AM
tomek committed rCOMM86010512c313: [lib] Create a hook that can delete thin and thick messages.
Apr 15 2025, 9:11 AM
tomek closed D14540: [lib] Add redux actions and client side endpoint code for deleting messages.
Apr 15 2025, 9:11 AM
tomek closed D14539: [lib] Create a DM op spec for deleting messages operation.
Apr 15 2025, 9:11 AM
tomek committed rCOMM824cd4b66144: [lib] Add redux actions and client side endpoint code for deleting messages.
Apr 15 2025, 9:11 AM
tomek committed rCOMM7e9267bb2c43: [lib] Create a DM op spec for deleting messages operation.
Apr 15 2025, 9:11 AM
tomek closed D14536: [native] Add delete message spec to the C++ layer.
Apr 15 2025, 9:11 AM
tomek committed rCOMM2f8cdca9887d: [native] Add delete message spec to the C++ layer.
Apr 15 2025, 9:11 AM
tomek closed D14535: [lib] Add DM operation types for deleting messages.
Apr 15 2025, 9:11 AM
tomek committed rCOMM7fe5d8535eda: [lib] Add DM operation types for deleting messages.
Apr 15 2025, 9:11 AM
tomek closed D14534: [lib] Add a new endpoint for deleting messages.
Apr 15 2025, 9:11 AM
tomek closed D14511: [lib] Introduce delete message spec.
Apr 15 2025, 9:11 AM
tomek closed D14510: [lib] Introduce delete message type.
Apr 15 2025, 9:11 AM
tomek committed rCOMM1de1b945b503: [lib] Introduce delete message spec.
Apr 15 2025, 9:11 AM
tomek committed rCOMM3ba756707217: [lib] Add a new endpoint for deleting messages.
Apr 15 2025, 9:11 AM
tomek committed rCOMMad5e8de95dd3: [lib] Introduce delete message type.
Apr 15 2025, 9:11 AM
tomek closed D14505: [lib] Migrate delete message permissions on clients.
Apr 15 2025, 9:11 AM
tomek closed D14463: [lib] Add a migration that adds message delete permissions.
Apr 15 2025, 9:11 AM
tomek committed rCOMMf568c36c5ed5: [lib] Migrate delete message permissions on clients.
Apr 15 2025, 9:11 AM
tomek committed rCOMM22107d4a88dd: [lib] Add a migration that adds message delete permissions.
Apr 15 2025, 9:11 AM
tomek closed D14462: [lib] Introduce delete message permissions.
Apr 15 2025, 9:11 AM
tomek committed rCOMM7e031e9590fa: [lib] Introduce delete message permissions.
Apr 15 2025, 9:11 AM

Apr 14 2025

ashoat committed rCOMMaf496024cd31: [terraform] Bump keyserver image to 1.0.161.
Apr 14 2025, 5:40 PM
ashoat committed rCOMMf6282d771824: Revert "[native] Temporary changes for staff release".
Apr 14 2025, 5:02 PM
ashoat added a reverting change for rCOMM4771c5e1eb48: [native] Temporary changes for staff release: rCOMMf6282d771824: Revert "[native] Temporary changes for staff release".
Apr 14 2025, 5:02 PM
ashoat committed rCOMMb96be8f55989: [native] codeVersion -> 484.
Apr 14 2025, 5:02 PM
ashoat committed rCOMM4771c5e1eb48: [native] Temporary changes for staff release.
Apr 14 2025, 5:02 PM
ashoat committed rCOMM4c4c3f8f8b9b: [native] codeVersion -> 483.
Apr 14 2025, 5:02 PM
ashoat committed rCOMMe8b1307db61d: [web][keyserver] codeVersion -> 161.
Apr 14 2025, 5:02 PM
ashoat committed rCOMM4b1e35f902ba: [shared] Update NEXT_CODE_VERSION.
Apr 14 2025, 5:02 PM
angelika closed D14574: [native] Fix uploading transcoded media.
Apr 14 2025, 2:40 PM
angelika committed rCOMMfbcddf5abbd0: [native] Fix uploading transcoded media.
Apr 14 2025, 2:40 PM
tomek added inline comments to D14561: [native][web] Add migrations unshimming delete messages.
Apr 14 2025, 1:47 PM
bartek accepted D14574: [native] Fix uploading transcoded media.
Apr 14 2025, 1:45 PM
ashoat accepted D14561: [native][web] Add migrations unshimming delete messages.
Apr 14 2025, 1:41 PM
ashoat accepted D14574: [native] Fix uploading transcoded media.
Apr 14 2025, 1:38 PM
tomek updated the diff for D14552: [web] Show a confirmation modal when deleting a message.

Rebase

Apr 14 2025, 1:23 PM
tomek updated the diff for D14547: [web] Disable all the actions for a deleted message.

Disable deleting thick sidebar sources

Apr 14 2025, 1:21 PM
tomek planned changes to D14547: [web] Disable all the actions for a deleted message.
Apr 14 2025, 1:10 PM
tomek updated the diff for D14547: [web] Disable all the actions for a deleted message.

Block deleting a sidebar source in thick threads

Apr 14 2025, 1:04 PM
angelika requested review of D14574: [native] Fix uploading transcoded media.
Apr 14 2025, 12:55 PM
angelika updated the test plan for D14574: [native] Fix uploading transcoded media.
Apr 14 2025, 12:55 PM
tomek updated the diff for D14557: [native][web] Handle deleted messages when searching.

Rebase

Apr 14 2025, 12:22 PM
Harbormaster failed remote builds in B33977: Diff 47768 for D14534: [lib] Add a new endpoint for deleting messages!
Apr 14 2025, 12:15 PM
tomek updated the diff for D14561: [native][web] Add migrations unshimming delete messages.

Revert error handling change

Apr 14 2025, 12:03 PM
tomek updated the diff for D14534: [lib] Add a new endpoint for deleting messages.

ESLint

Apr 14 2025, 11:57 AM
tomek updated the diff for D14534: [lib] Add a new endpoint for deleting messages.

Simplify the code

Apr 14 2025, 11:56 AM
tomek updated the diff for D14505: [lib] Migrate delete message permissions on clients.

Correctly handle thread children

Apr 14 2025, 11:47 AM
bartek closed D14569: [native] Make missing AuthMetadata message more accurate.
Apr 14 2025, 11:39 AM
bartek committed rCOMMcc686935acdd: [native] Make missing AuthMetadata message more accurate.
Apr 14 2025, 11:39 AM
bartek closed D14568: [native] Fetch platform details during restore flow.
Apr 14 2025, 11:39 AM
bartek committed rCOMMbf90254c736c: [native] Fetch platform details during restore flow.
Apr 14 2025, 11:39 AM
bartek added a comment to D14566: [native] Fix uploading images with ph-upload:// scheme.

That's right. There was a mistake here. During the review, I was comparing changes in this diff with changes from D14512 and I misunderstood changes to initialURI in that diff, making me think this diff is correct.

Apr 14 2025, 10:39 AM
kamil closed D14571: [CommCoreModule][SQLite] remove unused JSI calls.
Apr 14 2025, 10:12 AM
kamil closed D14572: [SQLite] move database version getter and setter to `SQLiteUtils`.
Apr 14 2025, 10:12 AM
kamil closed D14570: [SQLite][native] introduce `SQLiteUtils` class.
Apr 14 2025, 10:12 AM
kamil committed rCOMMa21b52612cb8: [CommCoreModule][SQLite] remove unused JSI calls.
Apr 14 2025, 10:12 AM
kamil committed rCOMM935928a8f9e4: [SQLite] move database version getter and setter to `SQLiteUtils`.
Apr 14 2025, 10:12 AM
kamil committed rCOMMa325ca34beae: [SQLite][native] introduce `SQLiteUtils` class.
Apr 14 2025, 10:12 AM
bartek updated the diff for D14568: [native] Fetch platform details during restore flow.

Remove redundant code

Apr 14 2025, 10:09 AM
bartek added inline comments to D14568: [native] Fetch platform details during restore flow.
Apr 14 2025, 10:08 AM
tomek added inline comments to D14573: [SQLite] implement `SQLiteSchema` class to wrap creation and migration logic.
Apr 14 2025, 8:53 AM
tomek accepted D14573: [SQLite] implement `SQLiteSchema` class to wrap creation and migration logic.
Apr 14 2025, 8:51 AM
kamil accepted D14568: [native] Fetch platform details during restore flow.
Apr 14 2025, 8:50 AM
tomek accepted D14572: [SQLite] move database version getter and setter to `SQLiteUtils`.
Apr 14 2025, 8:38 AM
tomek accepted D14571: [CommCoreModule][SQLite] remove unused JSI calls.
Apr 14 2025, 8:37 AM
tomek accepted D14570: [SQLite][native] introduce `SQLiteUtils` class.
Apr 14 2025, 8:35 AM

Apr 11 2025

ashoat requested changes to D14574: [native] Fix uploading transcoded media.

Apologies if the update was in progress, but passing back to you. Feel free to re-request review when the test plan has been updated (and performed) as requested above

Apr 11 2025, 11:16 PM
ashoat added a comment to D14574: [native] Fix uploading transcoded media.

It seems like you've updated the test plan to include the string "(image and video that requires and doesn't require transcoding)", which I suppose is an improvement, but very far from what I was looking for.

Apr 11 2025, 11:15 PM
angelika updated the test plan for D14574: [native] Fix uploading transcoded media.
Apr 11 2025, 11:09 PM
angelika updated the diff for D14574: [native] Fix uploading transcoded media.

Review changes

Apr 11 2025, 10:37 PM
ashoat added inline comments to D14574: [native] Fix uploading transcoded media.
Apr 11 2025, 7:01 PM
ashoat requested changes to D14574: [native] Fix uploading transcoded media.

In my opinion, inadequate testing of your changes is the reason our mobile releases have been blocked for the past 2 weeks.

Apr 11 2025, 7:00 PM
angelika requested review of D14574: [native] Fix uploading transcoded media.
Apr 11 2025, 6:16 PM
angelika added a comment to D14566: [native] Fix uploading images with ph-upload:// scheme.

It seems like we're discarding the processed media, since we're returning uploadURI to the caller (non-processed media). I hope I'm missing something here, as both @angelika and @bartek did not flag this...

Apr 11 2025, 5:13 PM
kamil published D14573: [SQLite] implement `SQLiteSchema` class to wrap creation and migration logic for review.
Apr 11 2025, 3:31 PM
kamil published D14572: [SQLite] move database version getter and setter to `SQLiteUtils` for review.
Apr 11 2025, 3:18 PM
kamil published D14571: [CommCoreModule][SQLite] remove unused JSI calls for review.
Apr 11 2025, 3:07 PM