Improve the logic
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jul 24 2024
I'd prefer to also validate on the JS side, but it isn't a strong opinion.
Address review
Address review
Addres review
Address review
Address review
Address review
Address review
Have you tested it on both platforms?
Address review
Address review
Address review
In D12692#361481, @kamil wrote:Right now two JS threads (shared worker and service worker) can concurrently modify the same key in IndexedDB. I think to make it safe we should use transactions to make sure this is safe.
Unfortunately, looks like locaforage is not supporting this: https://github.com/localForage/localForage/issues/582 and https://github.com/localForage/localForage/issues/17.
Could you do some research about whether it's safe or suggest an alternative solution?
(this could change most of the code so not reviewing details of this diff)
About to create fork with PR shortly
In D12677#361397, @bartek wrote:The HTTP request-response logic looks good; it's analogous to the existing Blob GET request logic.
Accepting but please remember to fix that semicolon. Otherwise, release builds will fail.
In D12668#361448, @ashoat wrote:In D12668#361372, @kamil wrote:I really don't like the idea (looking at this diff and the entire stack) of passing isKeyserverSession - notification crypto module should treat all devices the same regardless of whether this is a keyserver or client device, and we should only have senderID, because the current design makes it confusing. But given this is implemented and tested I believe we can proceed, you could create a follow-up task to improve it in future but for now LGTM.
Curious for @marcin's perspective on this, and how much time it might take to fix up
One thing that doesn’t work in thick threads is fetching next pages of results. This is because timestamps exceed cpp int, so SQLiteQueryExecutor::searchMessages doesn’t bind them to sql query correctly. Fixing this is tracked in ENG-8893
Jul 23 2024
Rebase
Use common C++ implementation on Android. It was tested the same way as iOS using latest staging Tunnelbroker release
Rebase
Use the API in send-utils
Make encryptNotification a part of olmAPI. This change is ESSENTIAL on web since it makes encryptNotification run on shared worker. This enables us to deterministically handle race conditions.
Still have to figure out a distinction between this and JOIN_THREAD
merge types
address review
Add the util
Add to specs
Add to specs
rename
In D12806#363499, @ashoat wrote:I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec
We can also build and run the native app as a part of the test plan.
We can consider one more thing: sorting the returned messages.