Page MenuHomePhabricator
Differential D10624

[lib] Update `ClientCheckStateServerRequest` to contain `MinimallyEncodedRawThreadInfo`s
ClosedPublic
Actions

Authored by atul on Jan 14 2024, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 5:31 PM
Unknown Object (File)
Thu, Apr 17, 2:39 PM
Unknown Object (File)
Thu, Apr 17, 2:18 PM
Unknown Object (File)
Thu, Apr 17, 9:14 AM
Unknown Object (File)
Wed, Apr 16, 11:10 PM
Unknown Object (File)
Wed, Apr 16, 1:35 PM
Unknown Object (File)
Mon, Apr 14, 3:19 AM
Unknown Object (File)
Thu, Apr 10, 12:47 AM
View All 87 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM248cb249022b: [lib] Update `ClientCheckStateServerRequest` to contain…
Summary

Update ClientCheckStateServerRequest.stateChanges.rawThreadInfos to contain MinimallyEncodedRawThreadInfo[]. This lets us remove the invariant in thread-reducer.

Depends on D10609

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
reducers/
6 lines
types/
3 lines

Diff 35592

View Options

lib/reducers/thread-reducer.js

// @flow // @flow
import { extractKeyserverIDFromID } from 'lib/keyserver-conn/keyserver-call-utils.js'; import { extractKeyserverIDFromID } from 'lib/keyserver-conn/keyserver-call-utils.js';
import type { CallKeyserverEndpoint } from 'lib/keyserver-conn/keyserver-conn-types.js'; import type { CallKeyserverEndpoint } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { defaultCalendarFilters } from 'lib/types/filter-types.js'; import { defaultCalendarFilters } from 'lib/types/filter-types.js';
import type { import type {
WebInitialKeyserverInfo, WebInitialKeyserverInfo,
WebInitialReduxStateResponse, ClientWebInitialReduxStateResponse,
} from 'lib/types/redux-types.js'; } from 'lib/types/redux-types.js';
import { useKeyserverCall } from 'lib/utils/keyserver-call.js'; import { useKeyserverCall } from 'lib/utils/keyserver-call.js';
import type { URLInfo } from 'lib/utils/url-utils.js'; import type { URLInfo } from 'lib/utils/url-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import type { import type {
ExcludedData, ExcludedData,
InitialReduxState, InitialReduxState,
▲ Show 20 Lines • Show All 54 Lines • ▼ Show 20 Lines for (const keyserverID of allKeyserverIDs) {
requests[keyserverID] = { requests[keyserverID] = {
urlInfo: rest, urlInfo: rest,
excludedData: keyserverExcludedData, excludedData: keyserverExcludedData,
clientUpdatesCurrentAsOf, clientUpdatesCurrentAsOf,
}; };
} }
} }
const responses: { +[string]: WebInitialReduxStateResponse } = const responses: { +[string]: ClientWebInitialReduxStateResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'get_initial_redux_state', 'get_initial_redux_state',
requests, requests,
getInitialReduxStateCallSingleKeyserverEndpointOptions, getInitialReduxStateCallSingleKeyserverEndpointOptions,
); );
const { const {
currentUserInfo, currentUserInfo,
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines
View Options

lib/types/request-types.js

// @flow // @flow
import { extractKeyserverIDFromID } from 'lib/keyserver-conn/keyserver-call-utils.js'; import { extractKeyserverIDFromID } from 'lib/keyserver-conn/keyserver-call-utils.js';
import type { CallKeyserverEndpoint } from 'lib/keyserver-conn/keyserver-conn-types.js'; import type { CallKeyserverEndpoint } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { defaultCalendarFilters } from 'lib/types/filter-types.js'; import { defaultCalendarFilters } from 'lib/types/filter-types.js';
import type { import type {
WebInitialKeyserverInfo, WebInitialKeyserverInfo,
WebInitialReduxStateResponse, ClientWebInitialReduxStateResponse,
} from 'lib/types/redux-types.js'; } from 'lib/types/redux-types.js';
import { useKeyserverCall } from 'lib/utils/keyserver-call.js'; import { useKeyserverCall } from 'lib/utils/keyserver-call.js';
import type { URLInfo } from 'lib/utils/url-utils.js'; import type { URLInfo } from 'lib/utils/url-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import type { import type {
ExcludedData, ExcludedData,
InitialReduxState, InitialReduxState,
▲ Show 20 Lines • Show All 54 Lines • ▼ Show 20 Lines for (const keyserverID of allKeyserverIDs) {
requests[keyserverID] = { requests[keyserverID] = {
urlInfo: rest, urlInfo: rest,
excludedData: keyserverExcludedData, excludedData: keyserverExcludedData,
clientUpdatesCurrentAsOf, clientUpdatesCurrentAsOf,
}; };
} }
} }
const responses: { +[string]: WebInitialReduxStateResponse } = const responses: { +[string]: ClientWebInitialReduxStateResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'get_initial_redux_state', 'get_initial_redux_state',
requests, requests,
getInitialReduxStateCallSingleKeyserverEndpointOptions, getInitialReduxStateCallSingleKeyserverEndpointOptions,
); );
const { const {
currentUserInfo, currentUserInfo,
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines