Page MenuHomePhabricator
Differential D10624

[lib] Update `ClientCheckStateServerRequest` to contain `MinimallyEncodedRawThreadInfo`s
ClosedPublic
Actions

Authored by atul on Jan 14 2024, 5:25 PM.
Tags
None
Referenced Files
F5095750: D10624.id35980.diff
Sun, Mar 30, 6:39 PM
Unknown Object (File)
Sun, Mar 23, 6:29 PM
Unknown Object (File)
Wed, Mar 12, 6:47 AM
Unknown Object (File)
Feb 21 2025, 11:27 PM
Unknown Object (File)
Feb 21 2025, 11:27 PM
Unknown Object (File)
Feb 21 2025, 11:27 PM
Unknown Object (File)
Feb 21 2025, 11:27 PM
Unknown Object (File)
Feb 21 2025, 11:27 PM
View All 77 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM248cb249022b: [lib] Update `ClientCheckStateServerRequest` to contain…
Summary

Update ClientCheckStateServerRequest.stateChanges.rawThreadInfos to contain MinimallyEncodedRawThreadInfo[]. This lets us remove the invariant in thread-reducer.

Depends on D10609

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D10624 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
reducers/
6 lines
types/
3 lines

Diff 35978

View Options

lib/reducers/thread-reducer.js

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines
View Options

lib/types/request-types.js

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines