Paths

Table of Contentst

Differential D10674

Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`
ClosedPublic
Actions

Authored by atul on Jan 17 2024, 3:20 PM.

Tags

None

Referenced Files

	F6181803: D10674.id35743.diff
	Wed, Apr 23, 7:13 AM

	Unknown Object (File)
	Sat, Apr 19, 6:08 PM

	Unknown Object (File)
	Fri, Apr 18, 10:03 PM

	Unknown Object (File)
	Fri, Apr 18, 10:03 PM

	Unknown Object (File)
	Fri, Apr 18, 10:03 PM

	Unknown Object (File)
	Fri, Apr 18, 10:03 PM

	Unknown Object (File)
	Thu, Apr 17, 4:01 PM

	Unknown Object (File)
	Thu, Apr 17, 10:18 AM

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMbd411a4d45ba: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`

Summary

As part of ENG-6366 : Rename MinimallyEncodedRawThreadInfo to RawThreadInfo

Depends on D10673

Test Plan

flow

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 17 2024, 3:20 PM

atul published this revision for review.Jan 17 2024, 3:31 PM

atul added a child revision: D10675: [web] Remove all instances of `LegacyThreadInfo` from `web`.Jan 17 2024, 3:31 PM

ashoat accepted this revision.Jan 17 2024, 3:36 PM

ashoat mentioned this in D10672: [native] Remove instances of `LegacyThreadInfo` throughout `native`.

This revision is now accepted and ready to land.Jan 17 2024, 3:37 PM

Harbormaster completed remote builds in B25850: Diff 35743.Jan 17 2024, 3:39 PM

rebase

Harbormaster completed remote builds in B26064: Diff 36014.Jan 22 2024, 1:18 PM

rebase

Harbormaster completed remote builds in B26088: Diff 36052.Jan 23 2024, 1:32 PM

Closed by commit rCOMMbd411a4d45ba: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo` (authored by atul). · Explain WhyJan 23 2024, 1:43 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbd411a4d45ba: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`.

Revision Contents
Changeset List

Path

Size

lib/

components/

chat-mention-provider.react.js

6 lines

permissions/

minimally-encoded-thread-permissions-validators.js

8 lines

shared/

4 lines

mention-utils.js

8 lines

mention-utils.test.js

6 lines

types/

filter-types.js

4 lines

minimally-encoded-thread-permissions-types.js

2 lines

thread-types.js

4 lines

utils/

drawer-utils.react.js

10 lines

entity-helpers.js

16 lines

native/

avatars/

thread-avatar.react.js

4 lines

calendar/

4 lines

chat/

settings/

delete-thread.react.js

4 lines

thread-settings-avatar.react.js

4 lines

thread-settings-delete-thread.react.js

4 lines

thread-settings-name.react.js

4 lines

thread-settings.react.js

50 lines

components/

thread-list-thread.react.js

4 lines

markdown/

markdown-chat-mention.react.js

4 lines

web/

calendar/

4 lines

markdown/

markdown-chat-mention.react.js

4 lines

modals/

history/

history-entry.react.js

4 lines

navigation-sidebar/

community-list-item.react.js

4 lines

Diff 35743

lib/components/chat-mention-provider.react.js

	// @flow			// @flow

	export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE			export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'primary'			? process.env.COMM_NODE_ROLE === 'primary'
	: true;			: true;

	export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE			export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'secondary'			? process.env.COMM_NODE_ROLE === 'secondary'
	: false;			: false;

				export const isAuxiliaryNode: boolean = process.env.COMM_NODE_ROLE
				? process.env.COMM_NODE_ROLE === 'auxiliary'
				: false;

lib/permissions/minimally-encoded-thread-permissions-validators.js

	// @flow			// @flow

	export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE			export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'primary'			? process.env.COMM_NODE_ROLE === 'primary'
	: true;			: true;

	export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE			export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'secondary'			? process.env.COMM_NODE_ROLE === 'secondary'
	: false;			: false;

				export const isAuxiliaryNode: boolean = process.env.COMM_NODE_ROLE
				? process.env.COMM_NODE_ROLE === 'auxiliary'
				: false;

lib/shared/markdown.js

	// @flow			// @flow

	export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE			export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'primary'			? process.env.COMM_NODE_ROLE === 'primary'
	: true;			: true;

	export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE			export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'secondary'			? process.env.COMM_NODE_ROLE === 'secondary'
	: false;			: false;

				export const isAuxiliaryNode: boolean = process.env.COMM_NODE_ROLE
				? process.env.COMM_NODE_ROLE === 'auxiliary'
				: false;

lib/shared/mention-utils.js

	// @flow			// @flow

	export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE			export const isPrimaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'primary'			? process.env.COMM_NODE_ROLE === 'primary'
	: true;			: true;

	export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE			export const isSecondaryNode: boolean = process.env.COMM_NODE_ROLE
	? process.env.COMM_NODE_ROLE === 'secondary'			? process.env.COMM_NODE_ROLE === 'secondary'
	: false;			: false;

				export const isAuxiliaryNode: boolean = process.env.COMM_NODE_ROLE
				? process.env.COMM_NODE_ROLE === 'auxiliary'
				: false;

lib/shared/mention-utils.test.js

Loading...

lib/types/filter-types.js

Loading...

lib/types/minimally-encoded-thread-permissions-types.js

Loading...

lib/types/thread-types.js

Loading...

lib/utils/drawer-utils.react.js

Loading...

lib/utils/entity-helpers.js

Loading...

native/avatars/thread-avatar.react.js

Loading...

native/calendar/entry.react.js

Loading...

native/chat/settings/delete-thread.react.js

Loading...

native/chat/settings/thread-settings-avatar.react.js

Loading...

native/chat/settings/thread-settings-delete-thread.react.js

Loading...

native/chat/settings/thread-settings-name.react.js

Loading...

native/chat/settings/thread-settings.react.js

Loading...

native/components/thread-list-thread.react.js

Loading...

native/markdown/markdown-chat-mention.react.js

Loading...

web/calendar/entry.react.js

Loading...

web/markdown/markdown-chat-mention.react.js

Loading...

web/modals/history/history-entry.react.js

Loading...

web/navigation-sidebar/community-list-item.react.js

Loading...