Page MenuHomePhabricator
Differential D10674

Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`
ClosedPublic
Actions

Authored by atul on Jan 17 2024, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 12:29 AM
Unknown Object (File)
Tue, Apr 8, 8:55 PM
Unknown Object (File)
Tue, Apr 8, 8:30 PM
Unknown Object (File)
Mon, Mar 31, 5:32 PM
Unknown Object (File)
Mar 10 2025, 10:42 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
Unknown Object (File)
Feb 21 2025, 11:55 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMMbd411a4d45ba: Rename `MinimallyEncodedResolvedThreadInfo` to `ResolvedThreadInfo`
Summary

As part of ENG-6366 : Rename MinimallyEncodedRawThreadInfo to RawThreadInfo

Depends on D10673

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 36052

View Options

lib/components/chat-mention-provider.react.js

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines
View Options

lib/permissions/minimally-encoded-thread-permissions-validators.js

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines
View Options

lib/shared/markdown.js

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines
View Options

lib/shared/mention-utils.js

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines
View Options

lib/shared/mention-utils.test.js

Loading...
View Options

lib/types/filter-types.js

Loading...
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/drawer-utils.react.js

Loading...
View Options

lib/utils/entity-helpers.js

Loading...
View Options

native/avatars/thread-avatar.react.js

Loading...
View Options

native/calendar/entry.react.js

Loading...
View Options

native/chat/settings/delete-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-avatar.react.js

Loading...
View Options

native/chat/settings/thread-settings-delete-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/components/thread-list-thread.react.js

Loading...
View Options

native/markdown/markdown-chat-mention.react.js

Loading...
View Options

web/calendar/entry.react.js

Loading...
View Options

web/markdown/markdown-chat-mention.react.js

Loading...
View Options

web/modals/history/history-entry.react.js

Loading...
View Options

web/navigation-sidebar/community-list-item.react.js

Loading...