Paths

Table of Contentst

Differential D10818

[lib] Add `threadInfoFromRawThreadInfo` test to `thread-utils.test`
ClosedPublic
Actions

Authored by atul on Jan 25 2024, 11:18 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 29, 11:20 PM

	Unknown Object (File)
	Mon, Oct 28, 12:50 AM

	Unknown Object (File)
	Oct 15 2024, 9:35 PM

	Unknown Object (File)
	Oct 15 2024, 9:35 PM

	Unknown Object (File)
	Oct 15 2024, 9:35 PM

	Unknown Object (File)
	Oct 15 2024, 9:35 PM

	Unknown Object (File)
	Oct 15 2024, 9:35 PM

	Unknown Object (File)
	Oct 15 2024, 9:35 PM

View All 66 Files

Subscribers

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM3147b6e753f0: [lib] Add `threadInfoFromRawThreadInfo` test to `thread-utils.test`

Summary

Based on feedback here: https://phab.comm.dev/D10718?id=35839#inline-65319

Depends on D10812

Test Plan

Unit test passes.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 25 2024, 11:18 AM

atul mentioned this in D10718: [lib] Remove branching from `threadInfoFromRawThreadInfo(...)`.Jan 25 2024, 11:28 AM

Harbormaster completed remote builds in B26161: Diff 36138.Jan 25 2024, 11:37 AM

atul requested review of this revision.Jan 25 2024, 11:37 AM

atul added a child revision: D10826: [web] Migrate existing `ClientDBThreadInfo`s on `web` to be minimally encoded.Jan 25 2024, 2:27 PM

ashoat accepted this revision.Jan 25 2024, 5:45 PM

ashoat added inline comments.

lib/shared/thread-utils.test.js
77	Should we use `threadTypes`?

This revision is now accepted and ready to land.Jan 25 2024, 5:45 PM

rebase

Harbormaster completed remote builds in B26291: Diff 36331.Jan 29 2024, 3:41 PM

atul added inline comments.Jan 29 2024, 5:38 PM

lib/shared/thread-utils.test.js
77	Yeah, I think @ginsu recently had a diff where he also cut/paste from Redux and we decided to use `threadTypes` instead of the "raw" number. Will update this diff.

fix

Harbormaster completed remote builds in B26295: Diff 36338.Jan 29 2024, 6:11 PM

I think it was @rohan actually

Closed by commit rCOMM3147b6e753f0: [lib] Add `threadInfoFromRawThreadInfo` test to `thread-utils.test` (authored by atul). · Explain WhyJan 29 2024, 7:16 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3147b6e753f0: [lib] Add `threadInfoFromRawThreadInfo` test to `thread-utils.test`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.test.js

136 lines

Diff 36138

lib/shared/thread-utils.test.js

Loading...