Page MenuHomePhabricator
Differential D7923

[lib] refactor updating enabled reports for using operations
ClosedPublic
Actions

Authored by kamil on May 22 2023, 11:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 4:19 PM
Unknown Object (File)
Thu, Nov 7, 10:21 PM
Unknown Object (File)
Thu, Nov 7, 9:27 PM
Unknown Object (File)
Thu, Nov 7, 9:22 PM
Unknown Object (File)
Sun, Oct 27, 10:24 PM
Unknown Object (File)
Sun, Oct 27, 8:45 PM
Unknown Object (File)
Sep 29 2024, 1:17 AM
Unknown Object (File)
Sep 29 2024, 1:17 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
michal
Commits
rCOMMdc513f56e63b: [lib] refactor updating enabled reports for using operations
Summary

Convert logic for ops approach.

Depends on D7922

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.May 22 2023, 11:04 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 22 2023, 11:04 AM
Harbormaster failed remote builds in B19612: Diff 26807!May 22 2023, 11:17 AM
kamil updated this revision to Diff 26838.May 23 2023, 1:17 AM

rebase

kamil added a child revision: D7931: [lib] refactor sending reports actions for using operations.May 23 2023, 1:21 AM
Harbormaster completed remote builds in B19630: Diff 26838.May 23 2023, 1:36 AM
kamil published this revision for review.May 23 2023, 1:54 AM
kamil added inline comments.
lib/ops/report-store-ops.js
63

my bad, I will fix this shortly

tomek accepted this revision.May 24 2023, 2:40 AM
This revision is now accepted and ready to land.May 24 2023, 2:40 AM
kamil mentioned this in D7931: [lib] refactor sending reports actions for using operations.May 25 2023, 3:03 AM
kamil updated this revision to Diff 27134.May 29 2023, 3:46 AM

rebase

Harbormaster completed remote builds in B19815: Diff 27134.May 29 2023, 4:04 AM
Closed by commit rCOMMdc513f56e63b: [lib] refactor updating enabled reports for using operations (authored by kamil). · Explain WhyMay 29 2023, 4:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMdc513f56e63b: [lib] refactor updating enabled reports for using operations.

Revision Contents
Changeset List

PathSize
lib/
ops/
24 lines
reducers/
29 lines
2 lines

Diff 26838

View Options

lib/ops/report-store-ops.js

Loading...
View Options

lib/reducers/report-store-reducer.js

Loading...
View Options

lib/reducers/report-store-reducer.test.js

Loading...