Page MenuHomePhabricator
Differential D5912

[native] [18/40] RN 0.70: Fix custom icons in dev mode
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 9:06 AM.
Tags
None
Referenced Files
F3365162: D5912.id19858.diff
Mon, Nov 25, 6:52 AM
F3364867: D5912.id19529.diff
Mon, Nov 25, 5:32 AM
F3363710: D5912.diff
Mon, Nov 25, 3:08 AM
Unknown Object (File)
Fri, Nov 22, 6:24 AM
Unknown Object (File)
Wed, Nov 20, 12:38 PM
Unknown Object (File)
Thu, Nov 14, 9:57 AM
Unknown Object (File)
Thu, Nov 14, 9:53 AM
Unknown Object (File)
Thu, Nov 14, 9:45 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM222357e6a602: [native] [18/40] RN 0.70: Fix custom icons in dev mode
Summary

expo-dev-client isn't able to show these fonts unless we preload them. This diff resolves ENG-2395, and it gets rid of the warning from ENG-1978.

Depends on D5911

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 18 2022, 9:06 AM
Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 9:06 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 9:07 AM
Harbormaster failed remote builds in B14241: Diff 19480!
ashoat added a child revision: D5913: [native] [19/40] RN 0.70: Type @expo/vector-icons.Dec 18 2022, 7:07 PM
ashoat updated this revision to Diff 19502.Dec 18 2022, 8:17 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:23 PM
Harbormaster failed remote builds in B14263: Diff 19502!
ashoat updated this revision to Diff 19529.Dec 18 2022, 8:30 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:53 PM
Harbormaster failed remote builds in B14290: Diff 19529!
ashoat updated this revision to Diff 19591.Dec 19 2022, 8:20 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 8:32 AM
Harbormaster failed remote builds in B14342: Diff 19591!
ashoat updated this revision to Diff 19624.Dec 19 2022, 8:37 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:01 AM
Harbormaster failed remote builds in B14375: Diff 19624!
ashoat requested review of this revision.Dec 19 2022, 9:10 AM

Please ignore CI until the end of the stack

ashoat updated this revision to Diff 19697.Dec 19 2022, 12:28 PM

Rebase

Harbormaster failed remote builds in B14442: Diff 19697!Dec 19 2022, 12:32 PM
bartek accepted this revision.Dec 20 2022, 3:13 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:13 AM
tomek accepted this revision.Dec 20 2022, 5:03 AM
ashoat updated this revision to Diff 19817.Dec 20 2022, 11:01 AM

Rebase

Harbormaster failed remote builds in B14557: Diff 19817!Dec 20 2022, 11:13 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
Closed by commit rCOMM222357e6a602: [native] [18/40] RN 0.70: Fix custom icons in dev mode (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM222357e6a602: [native] [18/40] RN 0.70: Fix custom icons in dev mode.

Revision Contents
Changeset List

PathSize
native/
navigation/
7 lines
1 line
6 lines
themes/
41 lines
2 lines

Diff 19480

View Options

native/navigation/app-navigator.react.js

Loading...
View Options

native/package.json

Loading...
View Options

native/root.react.js

Loading...
View Options

native/themes/fonts.js

Loading...
View Options

yarn.lock

Loading...