Page MenuHomePhabricator
Differential D5897

[native] [3/40] RN 0.70: iOS stuff
ClosedPublic
Actions

Authored by ashoat on Dec 17 2022, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:55 PM
Unknown Object (File)
Mon, Nov 18, 10:36 PM
Unknown Object (File)
Mon, Nov 18, 9:31 PM
Unknown Object (File)
Mon, Nov 18, 8:54 PM
Unknown Object (File)
Mon, Nov 18, 6:11 PM
Unknown Object (File)
Mon, Nov 18, 5:05 PM
Unknown Object (File)
Mon, Nov 18, 4:32 PM
Unknown Object (File)
Sun, Nov 10, 5:55 PM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM8383c5541411: [native] [3/40] RN 0.70: iOS stuff
Summary

These are the non-Podfile iOS changes from React Native Upgrade Helper. The project.pbxproj parts had to be "reverse engineered" from the patch there and then manually reapplied using Xcode... since those are pretty complicated, I'll try to describe inline.

Depends on D5896

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 17 2022, 7:26 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 7:26 PM
ashoat added inline comments.Dec 17 2022, 7:29 PM
native/ios/Comm.xcodeproj/project.pbxproj
1019 ↗(On Diff #19460)

Updated everywhere to be consistent

1041 ↗(On Diff #19460)

Related to this: https://github.com/facebook/react-native/issues/34102

1044 ↗(On Diff #19460)

Updated everywhere to be consistent

1146 ↗(On Diff #19460)

Reanimated is updated later in the stack, and the build for the new version of Reanimated was failing without this change

1546–1553 ↗(On Diff #19460)

Had to add these to get things to compile

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:29 PM
Harbormaster failed remote builds in B14226: Diff 19460!
ashoat added a child revision: D5898: [native] [4/40] RN 0.70: Android stuff.Dec 17 2022, 7:31 PM
ashoat requested review of this revision.Dec 17 2022, 8:07 PM

Please ignore CI until the end of the stack

tomek accepted this revision.Dec 19 2022, 4:41 AM
This revision is now accepted and ready to land.Dec 19 2022, 4:41 AM
bartek accepted this revision.Dec 19 2022, 5:59 AM
bartek mentioned this in D5907: [native] [13/40] RN 0.70: Expo upgrade.Dec 19 2022, 7:57 AM
ashoat updated this revision to Diff 19802.Dec 20 2022, 10:59 AM

Rebase

Harbormaster failed remote builds in B14542: Diff 19802!Dec 20 2022, 11:03 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
Closed by commit rCOMM8383c5541411: [native] [3/40] RN 0.70: iOS stuff (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM8383c5541411: [native] [3/40] RN 0.70: iOS stuff.

Revision Contents
Changeset List

PathSize
native/
1 line
ios/
10 lines
Comm.xcodeproj/
50 lines
Comm/
136 lines

Diff 19802

View Options

native/.gitignore

Loading...
View Options

native/ios/.xcode.env

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/ios/Comm/AppDelegate.mm

Loading...