Page MenuHomePhabricator
Differential D5906

[native] [12/40] RN 0.70: Update to react-native-video@5.2.1
ClosedPublic
Actions

Authored by ashoat on Dec 17 2022, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 7:34 AM
Unknown Object (File)
Fri, Mar 14, 12:44 PM
Unknown Object (File)
Mon, Mar 3, 5:55 PM
Unknown Object (File)
Mon, Mar 3, 5:55 PM
Unknown Object (File)
Mon, Mar 3, 5:55 PM
Unknown Object (File)
Mon, Mar 3, 5:55 PM
Unknown Object (File)
Mon, Mar 3, 5:55 PM
Unknown Object (File)
Mon, Mar 3, 5:55 PM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM7df23036ce33: [native] [12/40] RN 0.70: Update to react-native-video@5.2.1
Summary

Upgrade necessary due to this issue that occurs on React Native 0.69.

Depends on D5905

Test Plan

Tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 17 2022, 8:02 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 8:02 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 8:03 PM
Harbormaster failed remote builds in B14235: Diff 19469!
ashoat added inline comments.Dec 17 2022, 8:06 PM
native/react-native.config.js
8 ↗(On Diff #19469)

We used to force some old version of the Android video player (the non-Exoplayer one) for compatibility with old versions of Android, but we don't support those versions anymore, and the new version of react-native-video only supports Exoplayer anyways

patches/react-native-video+5.2.1.patch
10 ↗(On Diff #19469)

This was necessary for the build to succeed, since otherwise the tag pointed to nothing. This appears to have been fixed in the repo but I can't find a non-beta release with the fix...

ashoat requested review of this revision.Dec 17 2022, 8:09 PM

Please ignore CI until the end of the stack

ashoat added a child revision: D5907: [native] [13/40] RN 0.70: Expo upgrade.Dec 18 2022, 7:59 AM
ashoat updated this revision to Diff 19496.Dec 18 2022, 8:15 PM

Rebase

Harbormaster failed remote builds in B14257: Diff 19496!Dec 18 2022, 8:16 PM
ashoat updated this revision to Diff 19523.Dec 18 2022, 8:28 PM

Rebase

Harbormaster failed remote builds in B14284: Diff 19523!Dec 18 2022, 8:48 PM
ashoat updated this revision to Diff 19585.Dec 19 2022, 8:20 AM

Rebase

Harbormaster failed remote builds in B14336: Diff 19585!Dec 19 2022, 8:30 AM
ashoat updated this revision to Diff 19618.Dec 19 2022, 8:36 AM

Rebase

tomek accepted this revision.Dec 19 2022, 8:59 AM
This revision is now accepted and ready to land.Dec 19 2022, 8:59 AM
Harbormaster failed remote builds in B14369: Diff 19618!Dec 19 2022, 9:00 AM
ashoat updated this revision to Diff 19659.Dec 19 2022, 9:52 AM

Rebase

Harbormaster failed remote builds in B14408: Diff 19659!Dec 19 2022, 9:58 AM
ashoat updated this revision to Diff 19811.Dec 20 2022, 11:00 AM

Rebase

Harbormaster failed remote builds in B14551: Diff 19811!Dec 20 2022, 11:12 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
Closed by commit rCOMM7df23036ce33: [native] [12/40] RN 0.70: Update to react-native-video@5.2.1 (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM7df23036ce33: [native] [12/40] RN 0.70: Update to react-native-video@5.2.1.

Revision Contents
Changeset List

PathSize
native/
ios/
6 lines
2 lines
6 lines
patches/
13 lines
27 lines

Diff 19811

View Options

native/ios/Podfile.lock

  • This file was added.
// @flow
function parseSQLiteQueryResult<T>(result: QueryExecResult): T[] {
const { columns, values } = result;
return values.map(rowResult => {
const row: any = Object.fromEntries(
columns.map((key, index) => [key, rowResult[index]]),
);
return row;
});
}
// NOTE: sql.js has behavior that when there are multiple statements in query
// e.g. "statement1; statement2; statement3;"
// and statement2 will not return anything, the result will be:
// [result1, result3], not [result1, undefined, result3]
function parseSQLiteResult<T>(
rawResult: $ReadOnlyArray<QueryExecResult>,
): T[][] {
return rawResult.map((queryResult: QueryExecResult) =>
parseSQLiteQueryResult<T>(queryResult),
);
}
export { parseSQLiteResult };
View Options

native/package.json

  • This file was added.
// @flow
function parseSQLiteQueryResult<T>(result: QueryExecResult): T[] {
const { columns, values } = result;
return values.map(rowResult => {
const row: any = Object.fromEntries(
columns.map((key, index) => [key, rowResult[index]]),
);
return row;
});
}
// NOTE: sql.js has behavior that when there are multiple statements in query
// e.g. "statement1; statement2; statement3;"
// and statement2 will not return anything, the result will be:
// [result1, result3], not [result1, undefined, result3]
function parseSQLiteResult<T>(
rawResult: $ReadOnlyArray<QueryExecResult>,
): T[][] {
return rawResult.map((queryResult: QueryExecResult) =>
parseSQLiteQueryResult<T>(queryResult),
);
}
export { parseSQLiteResult };
View Options

native/react-native.config.js

  • This file was added.
// @flow
function parseSQLiteQueryResult<T>(result: QueryExecResult): T[] {
const { columns, values } = result;
return values.map(rowResult => {
const row: any = Object.fromEntries(
columns.map((key, index) => [key, rowResult[index]]),
);
return row;
});
}
// NOTE: sql.js has behavior that when there are multiple statements in query
// e.g. "statement1; statement2; statement3;"
// and statement2 will not return anything, the result will be:
// [result1, result3], not [result1, undefined, result3]
function parseSQLiteResult<T>(
rawResult: $ReadOnlyArray<QueryExecResult>,
): T[][] {
return rawResult.map((queryResult: QueryExecResult) =>
parseSQLiteQueryResult<T>(queryResult),
);
}
export { parseSQLiteResult };
View Options

patches/react-native-video+5.2.1.patch

  • This file was added.
// @flow
function parseSQLiteQueryResult<T>(result: QueryExecResult): T[] {
const { columns, values } = result;
return values.map(rowResult => {
const row: any = Object.fromEntries(
columns.map((key, index) => [key, rowResult[index]]),
);
return row;
});
}
// NOTE: sql.js has behavior that when there are multiple statements in query
// e.g. "statement1; statement2; statement3;"
// and statement2 will not return anything, the result will be:
// [result1, result3], not [result1, undefined, result3]
function parseSQLiteResult<T>(
rawResult: $ReadOnlyArray<QueryExecResult>,
): T[][] {
return rawResult.map((queryResult: QueryExecResult) =>
parseSQLiteQueryResult<T>(queryResult),
);
}
export { parseSQLiteResult };
View Options

yarn.lock

Loading...