Differential D7564 Authored by michal on Apr 21 2023, 7:57 AM.
Details Summary No logic changes. This is done to avoid ayclic imports between message-types and files in types/messages after adding the validators Test Plan Run app on web and ios, check if they throw any unexpected errors.
Diff Detail
Event TimelineHerald added subscribers: atul, ashoat. · View Herald TranscriptApr 21 2023, 7:57 AM2023-04-21 07:57:30 (UTC-7) michal added a parent revision: D7488: [keyserver] Introduce convertObject function.Apr 21 2023, 7:57 AM2023-04-21 07:57:52 (UTC-7) michal added a child revision: D7565: [lib] Reorder types in `media-types.js`.Apr 21 2023, 8:00 AM2023-04-21 08:00:43 (UTC-7) Comment Actions Makes sense! I wonder if we should put the new file in lib/types/messages, but I don't feel strongly Harbormaster completed remote builds in B18650: Diff 25541.Apr 21 2023, 8:15 AM2023-04-21 08:15:03 (UTC-7) This revision is now accepted and ready to land.Apr 25 2023, 3:14 AM2023-04-25 03:14:31 (UTC-7) Harbormaster completed remote builds in B19023: Diff 26054.May 4 2023, 3:22 AM2023-05-04 03:22:11 (UTC-7) Closed by commit rCOMMf5d32b6ac8cd: [lib] Move `messageTypes` enum to a separate file (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 5 2023, 5:46 AM2023-05-05 05:46:25 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 26054 |